From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDF9C41535 for ; Tue, 19 Dec 2023 04:05:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 920C28D000A; Mon, 18 Dec 2023 23:05:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D0A98D0001; Mon, 18 Dec 2023 23:05:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 723188D000A; Mon, 18 Dec 2023 23:05:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5C87F8D0001 for ; Mon, 18 Dec 2023 23:05:09 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2CFBF1A0365 for ; Tue, 19 Dec 2023 04:05:09 +0000 (UTC) X-FDA: 81582227538.07.FDD5B41 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by imf12.hostedemail.com (Postfix) with ESMTP id 893DD40006 for ; Tue, 19 Dec 2023 04:05:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UrGz1+Ec; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf12.hostedemail.com: domain of sohil.mehta@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=sohil.mehta@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702958705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qv4KZnXygKUEIgLMLvbTLmQQ+V+ZED9ufGYjhGzZ2qA=; b=gKiGSO9lQTvSx4SgwxKF2kQa+FewTg0S1ufIpnRp3j955N0EIVAOkGNhP9NvKLfc9yoElz rdVWRUHNLo6mED6AjywOqcKbkD+yfSJydCI8GlMNOqalGYyb+dwVg0LjtlRhHIkHrPC+yU Yb9jwoa+v3K0cXRK9+q2DKXMdDVCZVQ= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UrGz1+Ec; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf12.hostedemail.com: domain of sohil.mehta@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=sohil.mehta@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1702958705; a=rsa-sha256; cv=fail; b=fKQTcMiIkj6Eziuq7XUl0l2wIKHKK3ldpGb3P8F8za63dauOCTwlWebgoQ9cuyKr7yv0/4 0ULCofAqUR+g6S4Qx9hRT7qxo/WwrfLTfiiXRmBcxoK6FwvvXcORXziJDdATAxYoaRGutT NTJwfEIz8ZE4okIe4KyFcPE+mkSVPmo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702958705; x=1734494705; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=lAIBHAnKQLNk3H2ZVeUuXmX5TifiObDmxlqSoFlzUX8=; b=UrGz1+Ec/xc1MBIjEYsWL3jcfDYHs+TRixNySKv6NEXPWn2mpXGa+xR+ 60cKt30RPNn8nSw7rj1CPjoCkGSpry9WKq7C2Ij8T5cgcSTmhzVQoluNi u8weIe6bzwkdJV74KannSg8SPTF0VzDbWigcdfHQiHDEAD2HpkAwvWuAF fGXZluHwO0qT99AOoTqXaE0l1IOqdq54Xio6iCW7tztxU+ehp56Nru+Cz 8bxweFj+hhc0yfxYgsWhKG0p/TfrZkZ+JhHO1thxoxSWP9XYJyRpIaiTY XnWk6ls0Zbxo/P00v6YWutUKWgIH9FfLedxtfZVcE579QyXiqfhGAoTQs A==; X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="375094621" X-IronPort-AV: E=Sophos;i="6.04,287,1695711600"; d="scan'208";a="375094621" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 20:05:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="899214701" X-IronPort-AV: E=Sophos;i="6.04,287,1695711600"; d="scan'208";a="899214701" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Dec 2023 20:05:02 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Dec 2023 20:05:01 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 18 Dec 2023 20:05:01 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Dec 2023 20:05:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jg+keC518cSGUOM6qHJ2uTzakMT/vprQo/PbiPO+rlXtWtrOqBauuIDDElApIJQZlTmz+bS+vbS/kNbz52E9Hegkd7XHk5impJJG5Xhj2ege/IcXBM9eeNbb110WC85cPDSuOHHUps3+VRpspawByWkBxC0qXUJFuQmADcJFTp2IoslwHZD8AoybvXSGX3fLUk4IN7o+wHcGpYsK6itFGtcJIGOyOAUhv95K8xuBNl12IWVnh0Q57UWdZwDYTlzTsMtskskkNclEF6xlMIJtH407IaerXJlv8v9hbTlPzWpcqhLx6MtbiB43RicPgG6mkJNIJq3hnKhkdKvXIzZPnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qv4KZnXygKUEIgLMLvbTLmQQ+V+ZED9ufGYjhGzZ2qA=; b=XwtZiZFNeJLB04AH4Cx2nRD2udgMO5yJVU5nuNfNf6Yox4ISyVKOrblmKcMIS+/Lnm8Pj4Wq4a6C0114LlPycc+uGouR6C3AjDDsVGfN6C2C9VOvEKXB7X1tL1XDXHvKYl98TuY04pQaBnFWA8Ye8Gd1B/5kkr1je26PyjdMyBT8Hh2VosIJGoar3XsywZEQuuTYeXjFE0RkPxhN2QhoFOKc+HmhaAztvYY6+Qfs7ArYWKbaqnsZYrDKXtxob1Dy36l8FTl7jzZ4BaCOJ0bgl+pvdh/Oje1N46t2zOwph6Y1/pJCA9FpUv/qYZcSxNV70HVWpJTzzmGTGisDNacayw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3320.namprd11.prod.outlook.com (2603:10b6:a03:18::25) by DS0PR11MB7681.namprd11.prod.outlook.com (2603:10b6:8:f0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 04:04:59 +0000 Received: from BYAPR11MB3320.namprd11.prod.outlook.com ([fe80::6609:2787:32d7:8d07]) by BYAPR11MB3320.namprd11.prod.outlook.com ([fe80::6609:2787:32d7:8d07%6]) with mapi id 15.20.7091.034; Tue, 19 Dec 2023 04:04:59 +0000 Message-ID: Date: Tue, 19 Dec 2023 09:34:49 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include To: Kent Overstreet CC: , , , , , , , , , , , , , , , , Borislav Petkov References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216024834.3510073-4-kent.overstreet@linux.dev> <76af02dd-1f16-41ad-86c7-3202146d0085@intel.com> <20231219020605.edmlnz2hgjb4h4im@moria.home.lan> Content-Language: en-US From: Sohil Mehta In-Reply-To: <20231219020605.edmlnz2hgjb4h4im@moria.home.lan> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0037.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:98::16) To BYAPR11MB3320.namprd11.prod.outlook.com (2603:10b6:a03:18::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3320:EE_|DS0PR11MB7681:EE_ X-MS-Office365-Filtering-Correlation-Id: 23a89228-5bc1-499a-057e-08dc0047ab25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UzGcglnHTXrp8g7VRcBMa/4fE6TTXyA/TbKfKQoE/4Oa14oY2NbaN5yoLo1DuwR84zq7wgl88H9/C/aFK3YtmEk7ZMYlQjCYkY2i3UoLqM+CyQ01XAwnFxzIXreV9gGi1P+5H5IBcl8m/rAzQdnij+ldSuvewHPq/7FThFpjDPi1C5gep2BSGZ50OQynJ9ADSyy+BQUyn7xj5pxTOnXkrPDhLrfV5dRYxq9IHKVPIo4+eDC7aNtfS9FyCvyJeYb6CE2JNRiX+ZdLDTm14VLv6FOLAJykKX2W2D2vZxhCwRilRRMWBAMbuCwCvrxY0fqnN+Q8KMxMBUJNdFlLV7KRkht/IGbJ08rkwqr52kQooCsCMFluOCWzu8paL2OzSGtqGLqkFpoDlNpfXMBlN9Qn+zyXseoVQJxEIlU4aro5qhZMKa7YGUnoQ42m+m2vAfVYlueyI+W0V7iKicT7TK549EgHDnsvG2Dbdy0y1PhDSYzzZcX6r+vKjUSTF+RaQx8nEl/Fr1IaCUCNOyVKxQ0IDWLpzIXvgY6bohxt8f4/NOUJ2df5/OVNkSPmD6oXQKADhsMNnbXGYTBs3+bj76gBxPEBXApQh7lXPWhwxEVA/lmQ7B1MFj3xb8nMuTpiPjq5PLcwr342ycHm12tgJ5e/4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3320.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(136003)(396003)(346002)(39860400002)(230922051799003)(186009)(1800799012)(451199024)(64100799003)(66556008)(66946007)(2616005)(6916009)(316002)(66476007)(478600001)(38100700002)(6486002)(966005)(26005)(44832011)(8936002)(4326008)(8676002)(6506007)(6512007)(53546011)(31686004)(6666004)(7416002)(5660300002)(4744005)(2906002)(86362001)(82960400001)(36756003)(31696002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnFGVWF6cysrVkFkRzZnaWc1Ui9CcG56YytTVVdMZzNHdmdBZWR1aEtNQytB?= =?utf-8?B?MVFNamtwNFlPRDEvWUxqSDBiNytKZW1lY1JOM241ZlJXOGFlK1J3cFhyUS9K?= =?utf-8?B?eGhjSGRtN1AzS3F1SXpkc0ZvbmRGVGRmZDk1VGF1a3AxREVhbytsU1B4UHlO?= =?utf-8?B?enkrRjVmUTg5dGpxTFJkZjVieVhrYUxzSHdBY2E5eERkYzBMMUZydXRGSUsw?= =?utf-8?B?VHNqVDY3VzdGSzBvZko1SDVqS2J6TVIwRk1SNUt0TjVWbGhZWjk2eEoyVjJY?= =?utf-8?B?RU5lNG9aNVpRM3JzNEJaSHNmR2o1QzRCMVZGUEpFZDRjeFg1RjdFYW5zSmJz?= =?utf-8?B?UmFqMlY2M0l3TEsrcGlOVmhvc2d1Mm1oK1ZlNytybTExVkc2c3dMNkdqRDN1?= =?utf-8?B?YjZUVS84VFpnNlpkaUxQSmtYL3ZDYzNBbnNqaXl4Rzk3KzI5bXN6UVU5SnhO?= =?utf-8?B?ZTM5Yk9oN0RiZG1qT1NJc21SZWNwTlQ2VGgwZU1hQWZoVVRNQmI5R3U3UStD?= =?utf-8?B?UGNQL0RXMml3RXcyRzdVYlNvTmI3WmxnMHZoNE9vaytDU1dRV2hiOUI3ZWhV?= =?utf-8?B?WTR6OFhzdjhoaTQ2SEJ2Ty9SaU9WeHczWnZ0QXFMOWVNR0FNcEpQdU01MXU0?= =?utf-8?B?WmdEM3I5SnF5eld0UTRRczFxRFo2dWtGVHRSRFhLeVMyYWJ0U2EvS2xjbjZY?= =?utf-8?B?VFdlOXlvQ2ZnSVdlR2cyQm9jS3dYLy9Ta3ZBOFVERXYyV2tCeDJ2Nnl4dEh0?= =?utf-8?B?QWxzWHBDb0N1N2UwNTd1MzJ6UkFtMkNBVi9YeVJNNXplRHZFUlZnQzFBcnlo?= =?utf-8?B?Z05CNkxYdnZjSXhITlB5cUFYdjNyZkVaMllhbjMwaThkQkgyalYzSkFJcG04?= =?utf-8?B?S1N6eStmT3N5M2U0THNrQ0M1eW9jdCtaZVBGQVA4Ti9zZDF1T3pMb29KQ3kr?= =?utf-8?B?dEcrOTlZRG4rU0tNdk55SHY3UnRWMUd1QWswZ3hwN1NWcW9TUitTbGZwT1Fl?= =?utf-8?B?ODY0WkR3VGNhejJFNGZRUGZBZms4MVh1VnB2aS9FVWkyKzRQRFRmT010byt6?= =?utf-8?B?a2svUXZFZUVBOHA5VnlGVnVuOEUvNVd6a3NJYmdXOW9JaXhHRVl1cThCc0dw?= =?utf-8?B?UlZHMnVBVHRhS0thSHZxUi9EbEI5ekVNQ256bnR0VUtQRjdzekdzbE5SWGZl?= =?utf-8?B?cUV0QmxOakVVTXJvamt6aVQwMzNPNmxkbm9QTTEweTRhWE1BblFNTUNLRk9n?= =?utf-8?B?RUdQUmxsWmJVdmNQNVYrNXlTYXFMS3N0bzRaT2p0cU9KZ1o4Y1lmSkdrK3FG?= =?utf-8?B?b3J3bTZBc3EwM3A5S05zejVyQ2dkL25yeDN3djUyY2VadThlT2QvelpKYkc5?= =?utf-8?B?akF5MUdGQndoMHZ0M29OTG5vaFhxbDJscVlhenhsaHVtNXZmSXhJVVUzNXFl?= =?utf-8?B?NkhJWTJmeUdjTXQyMXBHWDltVGRHZWtDZFJKVjBSdFlrRlQwNkFaTnArR2JI?= =?utf-8?B?a2syU2dmVHJGS2pQNytrSGlEbHZsY3V6TmZkS3E4bm14bStSeTNEWVBJaHVw?= =?utf-8?B?N1J3bXJPdXJiR3I0YUhFRmVJbE1EbVVwUTRZWE1xdUVhaWlOOGtUTFEvYUda?= =?utf-8?B?RThlNUZRVkc4dDAxVm5BNXlVR0hXN1pSSmIxVjBJb3FnZEJGZnNYNFVRM20z?= =?utf-8?B?cVlsVm5LUjlYZUtrNk5rYWIzOGtEUXBDMEdhN0Y2am0vdmVMKzdxN2JxVmZq?= =?utf-8?B?QUx2UEsyWUdpcDVVTlRLSXBoZWdwa1dFRWNGNU1OMExkckk2Um9KdklyWmtM?= =?utf-8?B?TUQyZDQreW9XR24zeHhpZHdKcGVXaEhadDk2djJyb1h3VlZ2TzBhak5KWS9H?= =?utf-8?B?WmY2eHVlcitVSlVmUm9HNmVlNDU1Q1hnNnZUYTRxYTl2MEhlT0ovR1ZYRDRn?= =?utf-8?B?K0Q1QXVkejNDNXUweGY5MzJBVWsyMTFuT0liR1JYZHBFT0U2OHYzZ2pvdkJW?= =?utf-8?B?Tk81OHhWN3FhUGtDb2NHQkJMVFZVcGdQWXRINTNBQitZV1NlaC9hR3B3UW1u?= =?utf-8?B?dlRYYXB0cFJHMU1tbkhLTXJRdW5pdFYzTzhOMmF6WmI2WndjN0Vqai9OL1lQ?= =?utf-8?Q?zH7pAM+DHiqtYB1PgBrby3/Xp?= X-MS-Exchange-CrossTenant-Network-Message-Id: 23a89228-5bc1-499a-057e-08dc0047ab25 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 04:04:59.7357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hD1SeqiR9hH/AFSGCFUfqY1I+JDJWmmC91VDxm3cvr0UtT6PNBWsVQB+InBBHRq+Eod6+1f/r2VCuXaNqIMYcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7681 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 893DD40006 X-Stat-Signature: z96sd7yfjq13mn3iqf78e5xmxmcdtrfz X-HE-Tag: 1702958705-816690 X-HE-Meta: U2FsdGVkX1+GYvloLsBDHRVY2ehDRGvlxaH5V9oh52knHvupJCzqgA2FJMRZ2JYsvCstWeI6zwgLOG94X7NswzGVMJdKNFh8QyLROdUHGjYFSAEyAHmdv7l/s7pJhAZ7PVoWtab4YPEqU56dhAN9sYQaEv6Qwh5YAhyIKNY6zaKJnKh0m9GeH4ikxcx6tXXsdULIEBujlmNg7JDCsxHcRqNu/4SP+Y4ZFcW+BqMCKmYQEdR7mjR0pWDZ0/M6FxbNxtHQcOMRYT93/d1dKRLCjKGhNxj9whRQDuBXQXW6w218XxqgVpE0ECdez2MEBT4FJBl/fCLYS7VnudCqDw+oUeu4r4xV0HdV02dSEkkmo9na3tpKIIozY8l3Os4gIKHLrAqNIrFKrqf1pUdKJEPqHEnOuaYFVbkJ01/QmTcyGxSUj0dYw3sL5sMVDfGJCwZVUU3+AtLZUXN+SEQY6Ezyr99Z/Uq7bksjiHHcmUmkF9qampNtRS59KlM50CEsr7CvhsKN3gAQzroY7jmMK779XFm/nNHclzfOjFrIo3FtPKeoaxUM//R/oEnnjBNbtnnOUl4/edKeL8M4n8lLDEXnHZeyjyfiK2Ff5zBBLhvpSxbtZk0SNL352oEgOaxnznlJP+QuKagLN/DW7+ePwwxiwIIei977fO8XToFutvotJDivtBqbaP6aAwrjAYwjMALdIbILOw8BNHDNBmHoON3u1p+XU/c0MH5QsviFPqyN8rhs87ISmg/rFt24wLkpAx6PDeYkWjxhApLKvcPh+o0k/AzYROTNjVkzZOAjE6DmYcKaTPyHtY2T4s/Fn3KDhwy/WpRAdhsof46Rfpbnh0ixDNm6x6O9R1u/XUozUPfQOetu89VWA1bllFpE9fyp97EvM8tki5qJAgik6eanHoJPSw3zYRwRdWrQxnwo1H++BIQObgug5841q/wyA2irZMbWazoaRv0ZsG2WYTnjcDf 9KZUR9lW Cz9GJ4Ja2VfZaRuDKEQ/Rqr0P02C4ffGvBymNnahJBIb7je1ixdIld7H5yzj/RIgrOhfBcFZrQm3zilAqjvR+wvoiNHHfUPqx8Bk4VcTOXGfhQrPeElk62X3zP4VswqZLNRixAZevUJRvfcyYTVV3dskEEZ0Tc3pBs7a/P9s3/kh1EF6ccBECnH0BuVS5zVK0mZKKLiZXZqtCu07dahxax2rJyKI4+Gh6GJKuSjsMEE2ACIz8/Xm25i9yFnqpCK/kABYC52CH1xvT9bjrdAhm6+uOSJVo0VLR3wemgudoxJGgTBkpxO/6nPr7Rhkd09iAwhxyue/fGc3q7wDd58k+0AkBMWr5+TTz+QMLVuYk4QOJKVjMLEAwaW2zXdGAKaA2QXVDxMZRd82qHd6o6Xu3GPSqUpqZSLwT67GbmBUJEXFKZekuPTYtAOAaV53El9RpLxXf5PIyhkRnEE/fHdNIrt3INQB2KcDV3iBh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/19/2023 7:36 AM, Kent Overstreet wrote: > On Mon, Dec 18, 2023 at 04:18:29PM +0530, Sohil Mehta wrote: >> I believe the norm is to have the linux/ includes first, followed by the >> the asm/ ones. Shouldn't this case be the same? > > I haven't seen that? I generally do the reverse, simpler includes first, > not that I have any reason for that... I couldn't find a kernel Documentation link handy. But, I found this email from Boris: https://lore.kernel.org/lkml/20190411135547.GH30080@zn.tnic/ I believe at least arch/x86 follows this for the most part. One simple reason is to make it easier to find headers when a ton of them are included in the same file. Sohil