From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 610B3C3271E for ; Thu, 4 Jul 2024 15:41:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC8586B008C; Thu, 4 Jul 2024 11:41:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E50426B0093; Thu, 4 Jul 2024 11:41:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7B1A6B0096; Thu, 4 Jul 2024 11:41:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F08D6B008C for ; Thu, 4 Jul 2024 11:41:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 20647A41BA for ; Thu, 4 Jul 2024 15:41:47 +0000 (UTC) X-FDA: 82302485454.19.6312B30 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id D287380021 for ; Thu, 4 Jul 2024 15:41:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QBYydbnX; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720107692; a=rsa-sha256; cv=none; b=PYge1ufM5i/Yj9Ophbv17/vf2SZ6aUdF9LEw9CgoP26x/c6+otx3+O0ZqZ4/Fgq0IdasUE SQg5AssV3OaI5Usy1D3HiddiGncYY8FNEyKtuhb7L9nysJ36dnFpZNpPoH6lwy0MEDl8r1 D8MGAHZx4tMK3wXSC5wUqdyViAFAPqs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QBYydbnX; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720107692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b/guLxSHeFfZm60bqfRYgec2x5BpfKtwP3VHSwDVju0=; b=c+Q8BhcvCM7Hi98zb6Crq1Thyy8MmN/JeaSe6MRPujRlWjBS/GVXUsACIB4ITrcYDglnyc 73qEN7B3LRYXOr6c9PeanTmPvYgjMfPq0gSf7bYMvAQpKEc9t1oAgZsMo9Y4nInJaD5Czf l9GZ5erVBGuN6eVVxr7y1adtUHC+vWk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720107704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b/guLxSHeFfZm60bqfRYgec2x5BpfKtwP3VHSwDVju0=; b=QBYydbnXwZewgkXcuDjap1lRDAPPxWECug1qZmkaSyabQYImK1dl+LxovzcnynhlPeTcq5 JxgkOXZvIXc5qGa76CzMEn0oiXaPvlwLYAfE2Rd7noIf3/dGxPuGZC5cDiGBr+ZRNjHR4r w8PIdhIM8qdXp/D5Ek9Nbnf0tgYtJS4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-hopxnc4oP5m-Dx62VqUUTw-1; Thu, 04 Jul 2024 11:41:42 -0400 X-MC-Unique: hopxnc4oP5m-Dx62VqUUTw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3679aa0ee0aso507542f8f.2 for ; Thu, 04 Jul 2024 08:41:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720107701; x=1720712501; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b/guLxSHeFfZm60bqfRYgec2x5BpfKtwP3VHSwDVju0=; b=ab8KDpGNvsR/ka7RIq8UBbhbvHNx6wx4jg23eznwEEU7lH5EPTvLV4Qd+NGhsDZ31C 4dkB79gAwxkclPpFss184+agBgLhTXUCBqx6gRoyZsFEOtAlK5/ZrWIRleebzf4viPEl aJe3h2+knn7KMesXw5V+CS5xqYzpbbfanJv2UmP50AQl9nv3WDst81iAOn4a2H2tYv0t MzpHEaqT70VvDbqH0nQoyOKwiOj8bZGnUxGK6P9MgqepxYvGqSLbxWttvpYT2IgNG/cM K52QBDkaHnYeGBF9P2Sjl7TuhFbqucjQTRN+CKTfZwWAdovMi7mb2LDbfHdTBnfc/VsX XmFg== X-Forwarded-Encrypted: i=1; AJvYcCVP7CrUJtYmFX2o5snK7FxTXpm/j3JRXdz8gqb1Z+H7mjpaARM33dvZ6c+i5y7kHvA5PkFF5341odWCVub7ADRTtbk= X-Gm-Message-State: AOJu0YwqNy7Nk6xhFFndekJialEtQKLjdklAHvR4MXfhH0IWa+6Ym/Cb djNuODH9CFlICFfm6i6xSLanXnZFPUCcvNzXIubbZqE5FwgaLoI0QL+GhGmQ7Yewv0CxxRRrbzn Y3x67rAtcdo41Qf274FQL2W77QRRik2LcSp/ItlH/YuCjZmJC X-Received: by 2002:adf:f2d2:0:b0:367:9792:8bd4 with SMTP id ffacd0b85a97d-3679dd65208mr1367701f8f.43.1720107701722; Thu, 04 Jul 2024 08:41:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvifDljnLTl51EWIff/gzGB+bulX9OAvOSzHrPj0EubUhit2RcrXbNd9B4uizJswZo9uPVmw== X-Received: by 2002:adf:f2d2:0:b0:367:9792:8bd4 with SMTP id ffacd0b85a97d-3679dd65208mr1367685f8f.43.1720107701272; Thu, 04 Jul 2024 08:41:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:8600:f05d:97b6:fb98:2bc1? (p200300cbc7158600f05d97b6fb982bc1.dip0.t-ipconnect.de. [2003:cb:c715:8600:f05d:97b6:fb98:2bc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0cd66fsm18988535f8f.8.2024.07.04.08.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 08:41:40 -0700 (PDT) Message-ID: Date: Thu, 4 Jul 2024 17:41:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/45] mm/pagewalk: Enable walk_pmd_range to handle cont-pmds To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , Muchun Song , SeongJae Park , Miaohe Lin , Michal Hocko , Matthew Wilcox , Christophe Leroy References: <20240704043132.28501-1-osalvador@suse.de> <20240704043132.28501-6-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240704043132.28501-6-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: jqzgwh3a85di4jdi1iutsuqagdecno63 X-Rspamd-Queue-Id: D287380021 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720107704-397735 X-HE-Meta: U2FsdGVkX1/SdbtTmP5j6jKlfIUA5Yfyi6OOARuYSkyteP0l4tDK1rkq/Uaj9tx2fqP1lWV6lDPPYDRyEnFWJthK+kLPLe4/0QPk1CRRT0Xq91XLceCZLGNzjpNlCOpecXJZnySDr6BSyY/fB9adI3Ptg1CAwfGkQ5bGK60RXN66904N33+2dQNWvEEB+KzWSd4/nHD3UvVeNlA2feEoBQf6cOWUOQV1eXFlJ5EzKPgW3rh5llow2xSTZY9eade/UBWWDMq4pkZ7RX78PCtyGWQ4aM61sQEtcwnXd9bFpkr+yqCFCJIoWz3lqxyEBz6WjAL4rRpD2cYzsSKxwECIYYRuenYHCXzJ4x7i1ytLW0ClMa7N1IMCNq5KwZKSE956Gb5AdtrgpTYT181/cSbuaxJlB9jkKaUJR6pMHG75yxshGHscbc1UIq9KQIDFjF5yPWzBhd9ZAzErNEUCdDFKzPKHUY7JhLgER+n7ahx9ZzblWiAfuT2KaAW4zwCwZlrMU6sv8b5cbVGLwPrtHi+rDx8d11geK02mgkvWmy5e3aMCdZRIP7IMw180mQgjYGiIggdMlVJivAobMl+Xyuiia62UdB/g3kDIJtDs44Ua6e43fl7ttSwk9nKen1IrWHSjTQKm/ZRSwbErPV/Qy4pgOKGhnJl342s8lolK2SIFw9L1/P9+dVTcUpiKTRRch9FyODLTgUvR6DVu+EIcB/uSanLsh8jp2C+R/psA7fg4U0sTanzEmBjDIPTP0eMVWjN2hOKcpiCYLS3l681nSaza/ul7Z29R9HJK4yGrfLwgLpOSlitoVADFufvRlTvvkPQbgWO+rq2MIWZfa9Lmlx3osvkgHSBFJLKtKZPFegjXQym/bOic0v1QBKD90jMSILOwi0YV1zGGhHWPTec4gZst8IJsBnK8aGmUSmKt4kPn8szMetw1N7afym8PS+ykYv/+H/YOPcp8NdEgUN6mAEN 3JLVEVZV 1P0iOd5//iNeQNNUyftTEoiPdnKQqv8E3AOwgv9yYM+mSLvzrWetNVf2qJqcxjbd+/QiiyUssKbo4fwdYikv1LeIK8MiUAOQaRwSiDr7LMYvI4wtTCdgMZMLsapzp1azC9rvZa1yfF7acqjl7tN6D/zX9EegizjZ4kyHdHsnsKi2yp45l7wU+J4xlcwKR8MRxUM51F9YmtMp4XCiOq+Mn/E5xRxyzlZltD7HR7iJWwfDSoIdHb3ovlyzXC8vne+hOWar2ldHJSi6WI1Iw+FKBRGEhI5qZc9tqEXmE5kX5JoMeYDUvaP6xIZCkLkzaRjFKcTtGImR1XFMPaXpT7CjzTyxSgwCqwI6A4MR2eRIOyMs+HTsfVsHD6x+s1206My8EfKI6YJNc4Jn9mQr0oqPJXBOnBpOnnHbKD+NtR1D5wzmkbU8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.07.24 06:30, Oscar Salvador wrote: > HugeTLB pages can be cont-pmd mapped, so teach walk_pmd_range to > handle those. > This will save us some cycles as we do it in one-shot instead of > calling in multiple times. > > Signed-off-by: Oscar Salvador > --- > include/linux/pgtable.h | 12 ++++++++++++ > mm/pagewalk.c | 12 +++++++++--- > 2 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 2a6a3cccfc36..3a7b8751747e 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -1914,6 +1914,18 @@ typedef unsigned int pgtbl_mod_mask; > #define __pte_leaf_size(x,y) pte_leaf_size(y) > #endif > > +#ifndef pmd_cont > +#define pmd_cont(x) false > +#endif > + > +#ifndef CONT_PMD_SIZE > +#define CONT_PMD_SIZE 0 > +#endif > + > +#ifndef CONT_PMDS > +#define CONT_PMDS 0 > +#endif > + > /* > * We always define pmd_pfn for all archs as it's used in lots of generic > * code. Now it happens too for pud_pfn (and can happen for larger > diff --git a/mm/pagewalk.c b/mm/pagewalk.c > index d93e77411482..a9c36f9e9820 100644 > --- a/mm/pagewalk.c > +++ b/mm/pagewalk.c > @@ -81,11 +81,18 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, > const struct mm_walk_ops *ops = walk->ops; > int err = 0; > int depth = real_depth(3); > + int cont_pmds; > > pmd = pmd_offset(pud, addr); > do { > again: > - next = pmd_addr_end(addr, end); > + if (pmd_cont(*pmd)) { > + cont_pmds = CONT_PMDS; > + next = pmd_cont_addr_end(addr, end); > + } else { > + cont_pmds = 1; > + next = pmd_addr_end(addr, end); > + } > if (pmd_none(*pmd)) { > if (ops->pte_hole) > err = ops->pte_hole(addr, next, depth, walk); > @@ -126,8 +133,7 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, > > if (walk->action == ACTION_AGAIN) > goto again; > - > - } while (pmd++, addr = next, addr != end); > + } while (pmd += cont_pmds, addr = next, addr != end); Similar to my other comment regarding PTE batching, this is very specific to architectures that support cont-pmds. Yes, right now we only have that on architectures that support cont-pmd-sized hugetlb, but Willy is interested in us supporting+mapping folios > PMD_SIZE, whereby we'd want to batch even without arch-specific cont-pmd bits. Similar to the other (pte) case, having a way to generically patch folios will me more beneficial. Note that cont-pmd/cont-pte is only relevant for present entries (-> mapping folios). -- Cheers, David / dhildenb