From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C425BE7717F for ; Tue, 17 Dec 2024 21:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 404406B007B; Tue, 17 Dec 2024 16:00:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B4976B0082; Tue, 17 Dec 2024 16:00:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A30F6B0089; Tue, 17 Dec 2024 16:00:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0E0B46B007B for ; Tue, 17 Dec 2024 16:00:46 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7EC24A09FD for ; Tue, 17 Dec 2024 21:00:45 +0000 (UTC) X-FDA: 82905667866.17.36FD95A Received: from 008.lax.mailroute.net (008.lax.mailroute.net [199.89.1.11]) by imf18.hostedemail.com (Postfix) with ESMTP id 87F311C0017 for ; Tue, 17 Dec 2024 21:00:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=xMsxShaM; spf=pass (imf18.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.11 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734469229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yzGOi3NneZYR9bDxI9UvolmGdtoJM/NJwZQblAerzBw=; b=OihtfzThMdtGTiztFfFFPIqcMN+YwCxpMHTUVdYvjsOxWjWz1Qaj53Wz3hlPx+R9DkrkVe q22aAYVXQLIvAR7M3nB9yg9YIzdJtpA/5xw9AE0RcpyBWvthq8iPyU8w8y6zuLM82yFHru WuZv0iGF+tuwSiDq2pDbxHncq6let70= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734469229; a=rsa-sha256; cv=none; b=YnPRodwEizFpcYrZmdbvEzJ4p86qu0FVJ4jjbRhs7n/nf8YMyPCNp6/BtzjavEMAJkZFrT nIpx0+MlbUo/ZxyGyEgRMGt0eBumJSQhfg5GHGKYLC6PT6oTGidpw2Ih/x35RGhMEXgHrz L7o5L7e/U7AUbVIDL7RZ1UAwnqehayE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=xMsxShaM; spf=pass (imf18.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.11 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org Received: from localhost (localhost [127.0.0.1]) by 008.lax.mailroute.net (Postfix) with ESMTP id 4YCTjk2KGPz6ClY9B; Tue, 17 Dec 2024 21:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1734469234; x=1737061235; bh=yzGOi3NneZYR9bDxI9UvolmG dtoJM/NJwZQblAerzBw=; b=xMsxShaMUHaL8dRP4HYD6O66fFleU39uHO+HIuCD GQ5jN4D1DZysGFmgqmPeiaGjpi8kwNKj0tpW6ZjU7SZ7f0RMNvYxDtnIr0RV9VjO yeagNhzqgBBcZzEMMCcz0MTL2mNcKczlvbuwaXZJp6O6kjK2l+wEEC6l8lGydl8K x6UXJovpiGP6PuuKldfeS4jIY9kmcruq9UnGDf/aGvk2vymwSZptfURnVYlVyAGC 6jxONNxHNQKL8T265JNhVfSwbwT0tKLoBmbVsSSwa1b0icoyI3sY65XbuQx94ZHe op93Kjghvd2xrWGjy/sVnbD5mgU/PTo/zFFpF0WfkfYCvQ== X-Virus-Scanned: by MailRoute Received: from 008.lax.mailroute.net ([127.0.0.1]) by localhost (008.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id aFjAikwuH6uN; Tue, 17 Dec 2024 21:00:34 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 008.lax.mailroute.net (Postfix) with ESMTPSA id 4YCTjT2220z6ClY97; Tue, 17 Dec 2024 21:00:28 +0000 (UTC) Message-ID: Date: Tue, 17 Dec 2024 13:00:27 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition To: Luis Chamberlain , willy@infradead.org, hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org Cc: john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-10-mcgrof@kernel.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20241214031050.1337920-10-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 87F311C0017 X-Stat-Signature: 9odxqtfyawor5ydi9e8dzmxqa7oeqd89 X-Rspam-User: X-HE-Tag: 1734469229-97543 X-HE-Meta: U2FsdGVkX18Voe6eoBbLtGLTuknPMhF04/++7Ab2w+QyzYByjICzPHwOmn8+4kDjh/GaaOeEuzn7vqHtc6rV4vp7QrinNTpkRTFBKil6kn7Ph1LbEeGZ6TdnUL8W9yjnMli4OXJpZSSN1sGGxH08VMDzDP877F31E+zQP/XV84z429pjcVnxFSDUnroUWgXlFlz5fsJTbL9gjtdCaxL8l1ELjpRUe8EO8Co1mo6DPnXsZH5xkHdtMcpJzxZLvq1VWWDNrk9vp+8ClUCEB3G3B/mZ+gZd8kyopmsNzBlf+Kz/TM+da3nonQ+uxvU2C+mVdMXEb0epCMp06wthSMi9f0ddy4RW5QbMFqHuE8MR330aCoUO2yLdjoK6wNDeGqaYarfAnl8GWewinqVJJrC1DeaB6HH1Xr3JTpek+p2WY1ObCFdyMjsR++YH8aPK0Q+S6Lw55FSOwyfj4V7JASHxDfIsxgD3gWoBan1mRZRhMt4uwDvLq15m0HxgGJVkRihFwsCLCRhoJWHq0yYAv5/Rvuov8IDxAfa1qOIvr6KAcJOg26M+JMJe8roc+QTP1YtoLLfgOUZi4a2TDhLG6LjjlXDwEkuI3Z8cGrgQZUnJHoZhv92+HKk8qytU1Lk+zfcJe2vmlOyi6y8wQnWD/9StZght5kDDgc/82CgcLElUphGxLZb/Gj69WzjrINvpC1GQGG/iStl8yzUMHB2LBPVkMKFnFbXfaosZHqNTI7UkyEOMbjWaZcwgg4xm3u/l0djSl5Tn5D27PtwMlFqhQoHXtoIbkwe+Yy1oFomYCI6BDkaocFIu5OPbiJAV9YUFZbL3Ed0re7vzMVUmA65WIFMeb+mNbyRuK3LCB0a2hKkXc9CgH0gDd4spz0vghJj657eN4Qh5ltCG0COjGjqmU8vV02FmsHJ8ioS+TGAJs2D7H0SMve7uVOMzEKYsD6xAOnLkS01ebdgxnt7ZSDemKXz GvvXcdse G0f3J6z9g9kBlPCfsG4LDDuAnb8i9Fm7G/YAEeTC2t2/SMFM9df3HetPxz3s24ZGIXkQqSI/3USzdpiwQPYa9Y82lut1D6hpePL4wxusS7pdDkrWuf1t7+bVUV85a8K3q7/TYrqfphp+0FC9x3M3RmUBhTKWbLTVBmd/7cu4kQAY2lpNZrmvxlMVW16mfNmP4sT+AjdBj5g4aNVfU+UCYXhpK1VPajbXB+Kp3NPnbJc9BJmm2BwadiFHaoBVdlcxfEAa5My2GlHlfy1dJyCOcYBEUjdverGYKxB+ziBSasVT6/XlKvxB4la3INw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000799, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/13/24 7:10 PM, Luis Chamberlain wrote: > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +/* > + * The hard limit is (1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER). > + */ A closing parenthesis is missing from the above comment. > +#define BLK_MAX_BLOCK_SIZE (SZ_64K) > +#else > +#define BLK_MAX_BLOCK_SIZE (PAGE_SIZE) > +#endif Parentheses are never necessary around constants since the definition of the constant should include parenthesis if necessary. Thanks, Bart.