From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42B5C7EE2C for ; Thu, 25 May 2023 09:57:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A1A86B0074; Thu, 25 May 2023 05:57:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 251B9900003; Thu, 25 May 2023 05:57:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11962900002; Thu, 25 May 2023 05:57:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0274C6B0074 for ; Thu, 25 May 2023 05:57:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8FD31A0B31 for ; Thu, 25 May 2023 09:57:07 +0000 (UTC) X-FDA: 80828324094.27.E05587D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id 1125D18000F for ; Thu, 25 May 2023 09:57:03 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MZDYBRU9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="0t/2LQU/"; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685008624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4GNSHGfIZxQ1UhhiGEkHCb26Lr2vl2sDD7sOPkyvdkU=; b=45cSgO5gh5mI0X5698c95u4CGWxuOK2S+8pfS+GFrs8IqAvDyP5vBr7i2bNLGLNtTISc2x IETtSi2iHPqu8yvwrZ5EW30LC+1gl0gCQ5hSj16UnhBVbkYzX7D3+puwu/ILJP1tVytgv3 a58LONSRaFxi2aqN1JS2FyYh8jj2MRY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MZDYBRU9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="0t/2LQU/"; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685008624; a=rsa-sha256; cv=none; b=XSxjkb61F4cHQVAJTmJDJxJyu7HsB/8GnxY4M8lVwG6ZIy1zztygN+HErn9BLNI3O6+WNl SYiVl0IIKfsxmHCXhsXHXCPjFx1vMGAUwJoT2YjsBQ2e/CGWHfu4XuHK8KuexvIelwuMyc SxwErXeA/VZHebpWdCL462i862mEyEI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3F9481FDEB; Thu, 25 May 2023 09:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685008622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GNSHGfIZxQ1UhhiGEkHCb26Lr2vl2sDD7sOPkyvdkU=; b=MZDYBRU9Bci0RIKRdZfhb12KZdd9o1+5028a4eYfDixTe4z1IdRWSXjk66QO6tzlNaulQy WZ1dBfkrIItBPmayNV/8uTD00kaoo20NBU8WkD1phAjgkj00Xdl7uTivdEejt7FHwMMCZp mVxs9mvTLhPm9+eWdNcEDUTZV59bBtc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685008622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GNSHGfIZxQ1UhhiGEkHCb26Lr2vl2sDD7sOPkyvdkU=; b=0t/2LQU/B8+fh1GulagPyChZ0uVz9Rj1PtNj04VJ1wXRvIb7YwU/hyR/vQYuKzI5gEJeTc ZL4xpARQQtIMHCBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1BEBE134B2; Thu, 25 May 2023 09:57:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 51s1Bu4wb2TzagAAMHmgww (envelope-from ); Thu, 25 May 2023 09:57:02 +0000 Message-ID: Date: Thu, 25 May 2023 11:57:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/4] mm: compaction: Ensure rescanning only happens on partially scanned pageblocks To: Mel Gorman Cc: Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML References: <20230515113344.6869-1-mgorman@techsingularity.net> <20230515113344.6869-2-mgorman@techsingularity.net> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20230515113344.6869-2-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1125D18000F X-Rspam-User: X-Stat-Signature: ga7xzhe1guigbthc1y4s8b6g6qb9t9xr X-Rspamd-Server: rspam01 X-HE-Tag: 1685008623-890047 X-HE-Meta: U2FsdGVkX18lcRaWfqMXWC2p2TkpQAtMQH45fJBgg/XVXtfaigoDeQ7C2WYrE0RhjSaycW9AiWdZYp4Vi9LYNcYGTSnWvVfe07KSafxhGD/yjyCTtNA9t7mZ8X2DViYsbt1lbeeIn0anbLDxWTE2f8QApIctDgNpqOmpdwucoGAzRvTkw6epMKjYT/RZu/Fa6riVXAUDRh3wthvtG5YQXaMcrK2pEO7paT7AvnOpFWav69I8Xwsv7ry+Xk8cBiduZxKT/dHWKmbgJ1zhsnV4X8Fnx/Z0Ci0sQAzAvw+D+Np7bVfBWPNc2m/iw1oimWR/N8N8Zqfp6P9nSJlbS9KJE6AL0iOXTcdi3VWy5e+wgUkVZgdAdPdYVXhqviFLaphjBE5JcjJInbiZQvITWTlb04LYYUjWqphdhGDV1/7UaF2tdTxxqkhLp6/jrWp/W/YQEdGWOupUl/pO4WC5OSD32yEMaj8E7cI44Gy2DIdY4CPaf7xrOzGLIsYD6l/S/ygUEVwwPtDWh7zucICS7pul8xgcjCAi4cFeL3HEu9LEg592Jak8ZzwThMflEC6qup+IyD0u3kF3WHnn1+lJhOlu7l1g2Ze+2sSdTKgF+QHiHPnhpQBZPjPfNWCUjNUXjmm0YJa7C/NmoRlcDNGhDG8xi1uGxAaJ8kMyYrPXmkfSTWzC+n0pk4hfZiryDbeS/+5HEC1saxVrZ9b7otHMYGJzP0lu17zm41ApjXUbdBhFhSTYHCu2IFOKSt/V33tOMwinn0mYC0gUtw8Vf0nKoV/y6/wWsIUMzJvhH+FAu57r021QTDrhOxWffmwMNaZ9scoO9n7n6ItWLoLqrouU26Se35WfXU6khP/dClCX4VO5CQJBaTxLWQVQyqiEVkEXgdqIWtOs2mGn1t4xBHW1vn8F7IqviKJQH5jEY2LbCj/Q1qegFfYtbNKMyE66RUW3zihPtv72SI8NbODWTsFQ+yy 6IGTGvY6 7YDMQb/FdPbj5u4nbVXjLfTanu1QQvsCRvBMyvEXrRATwPngbiKuhYl2mEc/gxln79YIGqUA41o6x30z6OOXdMlDf2OKiHOSi5sYTmwp8zsj7EPKXSsWn2VS05kP0cdqK2tjqZyCmyyU5w8M70QHj3IP10rxElsmSRvScazbydu3ZHuvZAevZKPCGF81vcQF8gs6oCk9ybEV0Qw6nbOQr8yKwgW7l+rqR68cvSnpEpmYaVqSJR9gHqtWUy1Jb+grbYeM6YYIaMVwT8MGQw1JXX67UwrXLCHs8Ium56DLrQEL/OB9w58tOo8eIveTkPjfikD8ss5eqMTCFOjo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/15/23 13:33, Mel Gorman wrote: > compact_zone() intends to rescan pageblocks if there is a failure to > migrate "within the current order-aligned block". However, the pageblock > scan may already be complete and moved to the next block causing the > next pageblock to be "rescanned". Ensure only the most recent pageblock > is rescanned. > > Reported-by: Vlastimil Babka > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > mm/compaction.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index c8bcdea15f5f..81791c124bb8 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2464,8 +2464,9 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > * fast_find_migrateblock revisiting blocks that were > * recently partially scanned. > */ > - if (cc->direct_compaction && !cc->finish_pageblock && > - (cc->mode < MIGRATE_SYNC)) { > + if (!pageblock_aligned(cc->migrate_pfn) && > + cc->direct_compaction && !cc->finish_pageblock && > + (cc->mode < MIGRATE_SYNC)) { > cc->finish_pageblock = true; > > /*