From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEDFAC5AD49 for ; Tue, 3 Jun 2025 15:06:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DD6E6B049E; Tue, 3 Jun 2025 11:06:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B4806B04A0; Tue, 3 Jun 2025 11:06:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A3956B04A1; Tue, 3 Jun 2025 11:06:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 41BF56B049E for ; Tue, 3 Jun 2025 11:06:27 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0303160C93 for ; Tue, 3 Jun 2025 15:06:26 +0000 (UTC) X-FDA: 83514415572.25.6A1901D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 32254100005 for ; Tue, 3 Jun 2025 15:06:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gYFA6hab; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748963184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+IDnu3HxZinHnGOlo/4w3jT7mB19VJYiXAiyvOcajjs=; b=nWyPFJZ2Ah9FkNo0pcaYxPWpr36Ai575u2sGYPjNeekBd9ErLevUBaW/QXhLccm/r6FAG2 LxbONWQUOqZRcNxgV87OO839yHC1RnmXsfWoSM/xah35cob8IlaV1UrN/nMFqJrPdRNlLK crFoql8xz1hEmn6y78fceyv2NbM9AVA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gYFA6hab; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748963184; a=rsa-sha256; cv=none; b=cHnOJg56+S5ejDnTKUCF5jTDYMkoZg79lF3w3M2VXqF1vOqrdpcR/mkqUETkEg+WDLiDub X9QISL4lLRubeWHtC8Qu3SLlcCYWNVNouayc9/hcihVnNbnA1P2yhrcl+PMi9LapL86lrZ LsmdJuAAzerwx2nNl3T5kmnL3rLUaTU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748963183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+IDnu3HxZinHnGOlo/4w3jT7mB19VJYiXAiyvOcajjs=; b=gYFA6hab9wKunI+zbwBmXO8cwPBOHpuTfRPrB8Ro7PZZPw7gh4lDWlAHiH2JqC9bkiUybH QNsCfFfKNnLQzimeNFLBDEL6tU8fRTxGuPqV1vgy/qdZi6qMiPamY2qqyP+IS8P2HxMOJX 9JwkGNF99O0d3CML9erdwz/Qako6oKY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-nekxktdSPO2Jmh11Z3aWXw-1; Tue, 03 Jun 2025 11:06:22 -0400 X-MC-Unique: nekxktdSPO2Jmh11Z3aWXw-1 X-Mimecast-MFC-AGG-ID: nekxktdSPO2Jmh11Z3aWXw_1748963180 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4f8fd1856so2106032f8f.2 for ; Tue, 03 Jun 2025 08:06:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748963180; x=1749567980; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+IDnu3HxZinHnGOlo/4w3jT7mB19VJYiXAiyvOcajjs=; b=js3HNzFJatglPRKgMgNR7/6GtmxRldv4kvg+tP1j8Wghu94cq2HX3ejF0tVOx6ThWa pMeonDRPJ9sdn5xqSji9MdZT5o5a7xu3eAp5+igywhrOqRrByx1op+G9X2MYpK+keIIE P4/h8t1leAP7AWNurdoolfMkZqyU9SNI9A4bJqf0czxjGrFVIXIBIWJ4bPo53etqnxBf FboXW9WcGP5z78a0lDnmKXaRj7qGi3AlyCCzANRKwJl/7mOwn1G8KAVfRAjv2BFL0KK3 lwMcWgnKCYmwTRd03wP0NeKhPQ718f5Yx4grFLs/WE5yRdvJUGqbbKR8+Wq8linAMIEl 5Ifw== X-Forwarded-Encrypted: i=1; AJvYcCUcHFJ/65YXpj+tXWTROlV++HY6fh2fmFX9XyyqbNhNcq1kVOy0xkXutQHrvEKjz1djfySItS9BSA==@kvack.org X-Gm-Message-State: AOJu0YyGDZ135HMHuNDvhrJJrE/sg5UA6n30ZE69U4ikZXMP3+cAm8ml ngtwrJCyzrO32WHJt+LD+iqPfd8yV+3V44HHblYSHPrbo/Szhl9gE90/huTyS6MAToy8WG/W0Ni oNAzUYizw7+EnRAYiKyNvjYYnmSQ7gQOEcTwjNaT4oZJEwO24JSvG X-Gm-Gg: ASbGncs+StYRFJ9WVFQy8ppsw1b1hPNpK6v81wO197GkFZL/CIqg31oLsH9wFiJvPqr Cbf7kxynl/hCZTxZPf/B39Pefv/ZVRXh5S0Qlt+nEnnFnJBmRp6/yblvDY7iZTphpT70e83rYBN 7IST2uJ5BvFAB+M8yomBDhaEQCtPOU3Kha7aAaZWy/o1Efg0p5+0ZUCJNgpD7GOuAaiV9fiZ1uZ VeWPROQX4mdl2OBHE2qsnn+qNnUG1e/gZlqnECAaqDRK8ogwC/hjllx5pIRYG6mDqwJ9CYe/DDR 5zO+5QaXz1DVBhnOEnxIURCwxEtq1G8iZlceiOqK2t/nnUbOqQwDsrVcnYGjjUHRbu0xodL0BHq hV9pzFEK41xX7W6J5MN4aSRGesLIGzP6XzjwEsn6DkkUeT7HpiA== X-Received: by 2002:a05:6000:2511:b0:3a4:f6cc:a8c8 with SMTP id ffacd0b85a97d-3a4fe3a7decmr10116632f8f.51.1748963179708; Tue, 03 Jun 2025 08:06:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOWCebAzAqIR1f1Iem5WqF2v6FDj/UiOd99keJ5jx81zJTABKQoXYo+9VaL5cadMRmx4+O3w== X-Received: by 2002:a05:6000:2511:b0:3a4:f6cc:a8c8 with SMTP id ffacd0b85a97d-3a4fe3a7decmr10116574f8f.51.1748963179132; Tue, 03 Jun 2025 08:06:19 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe6c866sm18866643f8f.32.2025.06.03.08.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 08:06:18 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 17:06:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] selftests/mm: Report unique test names for each cow test To: Mark Brown Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-3-ff198df8e38e@kernel.org> <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PdB8R1Efomm7h0vTkJyM1xFVrSJBATVkxT4LN2uKKnw_1748963180 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 32254100005 X-Stat-Signature: f9oc991tqmdwudozuijco7r1f1xkjsg4 X-Rspam-User: X-HE-Tag: 1748963183-62848 X-HE-Meta: U2FsdGVkX19XjAklDWdOkLEQpBZS6VA3SPsaTfCbkz53yln6dI/DCkUyYfmi1hAwafQ05cO26FWJTqOpbnyXHvMhg//3p5rBRLT1bw54nvUwVGriOApb1vScGYddj4wZbiBqPAsxlbLi78O9gjKpm7ie2UF/YJQlX/Ly5EzvuEdhnVgSnTASSk1COUxBhmst5kpd5yUriXjxjBIyLG+Os8oGUApdavJ2mvrAMm8O4t8EHdgwwOGEovhRJHmLKqZJDxZGCoXuvgXWnGzA2GnbgXxYLTsn29RVdiM1L+wEL1ghmsVCQiNcjG/YRVnHKUhLEFT49KNxRgzKNYP9PVqjvSGq8VjBOAkgen4yH7qNvAAKdELCP20DSipytgvRIuY2/X3pFSLWozmCHm+bzXCQRM7jzOJipL7276NatvMF7bh08HRy+IlXCZkIiWg0g4iCxrpZi5ow+q/f5Zk2PewwMG2/1nHf6HqRI+NMvZPEJBE8RHOsEMeTyRPvdEXbLebNmQkNW86USjGPyjoxuGENB7UIdeurhfyiQuDF0LlV59EO5xBktTPaim/6Su4cYVfh1u3RPSiMcsS+jvEgGKUPU+0fVYSY/SQMoNt8zGRIDm2a0B26YO/5YFNPcV+3lJAEp4YEOzPuVxCp/nStgHuwRKNjGwQ/CbWFJUMe+NyBnmte1srZkAqWk8aLFhemSucWwuhxyxV1CFndWl2t6gcQqlsLkaetUs6ybJ62IPzAVJ7jzzLIJpGgUkohrRxN9En2PpePr6AVeiVNrLT3Y2tCz8Q5RSon94RLkOgf2iVb8vq2UEvpmH9cAlvXozUL1GDPh7hhlRgkgz+lBull0G7eU6BEeYGg9JwnoaL5KPP9unpjuI659ufQI0YVPHYCRAq04c4DAvZl4kWItZP1iGvzkR0xo8YD8t0FbCXWowjpsYv0kKySRLn9qalQv8ZHrOxlZxv7pbmEPoqOWFehds7 CHw8uCLY NfxNxuwxoHJqZ5sVX213M2b2/K6YYySpGePluALAVKwX5hubh0xmnsMBMx6CP0ADqnxq/Ffbb/O9brTxHEHSW6TRzMhKj3Do1tHpfIKBCtwwnmSB8gF6AR9TlXN7/J7Xoz2MS9BqobmYXe/Jn9cvSabFs0D+SkKmx3XkWxLvv5wHIOSu/a/3mZTag4Qwjyi4eLdjQVp1YFm7eiwyEebImcYfcLId7HPOyFP2wYLh4iRbW9oEShB8cWQv/q/nsvvYsEBpUhuIQyDe3hf9acf9FHKqfPCJHwLQ0Sch57yDikiPWqwvCnXT1CoPe18TIvhUjNAd7jOx74f9E7HCU+G2NP9fAQFoqM5qaxjOz6I8yI2M26UhOq0VlQBlTsDUDq+GngXuK2TDXHp4AoslRFvFFjlkLlg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 16:58, Mark Brown wrote: > On Tue, Jun 03, 2025 at 04:15:42PM +0200, David Hildenbrand wrote: >> On 03.06.25 15:21, Mark Brown wrote: > >>>>> } else { >>>>> - ksft_test_result_fail("Leak from parent into child\n"); > >>>> Same here and in other cases below (I probably didn't catch all). > >>>> We should log that somehow to indicate what exactly is going wrong, likely >>>> using ksft_print_msg(). > >>> Can you send a patch with the logging that you think would be clear >>> please? >>> I dropped these because they just seemed to be reporting the> overall >> point of the test, unlike the cases where we ran into some error >>> during the setup and didn't actually manage to perform the test we were >>> trying to do. Perhaps the tests should be renamed. > >> ksft_print_msg("Leak from parent into child"); > > Can you send a patch showing when/where you want this printing please? I'm really busy right now, unfortunately. > Like I said I suspect the test name is just unclear here... I would hope we find some mechanical replacement. E.g., ksft_test_result_pass("No leak from parent into child\n"); becomes ksft_print_msg("No leak from parent into child\n"); log_test_result(KSFT_PASS); and ksft_test_result_xfail("Leak from parent into child\n"); becomes ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_FAIL); -- Cheers, David / dhildenb