* [PATCH] mm: remove extra empty line
@ 2022-09-01 6:37 Yuan Can
2022-09-01 7:37 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: Yuan Can @ 2022-09-01 6:37 UTC (permalink / raw)
To: akpm, linux-mm; +Cc: linux-kernel, yuancan
Remove extra empty line.
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
mm/mmap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 6445fd386f04..2504f89d519f 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2804,7 +2804,6 @@ SYSCALL_DEFINE2(munmap, unsigned long, addr, size_t, len)
SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
unsigned long, prot, unsigned long, pgoff, unsigned long, flags)
{
-
struct mm_struct *mm = current->mm;
struct vm_area_struct *vma;
unsigned long populate = 0;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: remove extra empty line
2022-09-01 6:37 [PATCH] mm: remove extra empty line Yuan Can
@ 2022-09-01 7:37 ` Christophe Leroy
2022-09-01 7:48 ` David Hildenbrand
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2022-09-01 7:37 UTC (permalink / raw)
To: Yuan Can, akpm, linux-mm; +Cc: linux-kernel
Le 01/09/2022 à 08:37, Yuan Can a écrit :
> [Vous ne recevez pas souvent de courriers de yuancan@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Remove extra empty line.
Don't you have anything more exciting and usefull to do in your life ?
This kind of standalone patch is a waste of time for both you and the
reviewers/maintainers.
Christophe
>
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
> mm/mmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 6445fd386f04..2504f89d519f 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2804,7 +2804,6 @@ SYSCALL_DEFINE2(munmap, unsigned long, addr, size_t, len)
> SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
> unsigned long, prot, unsigned long, pgoff, unsigned long, flags)
> {
> -
> struct mm_struct *mm = current->mm;
> struct vm_area_struct *vma;
> unsigned long populate = 0;
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: remove extra empty line
2022-09-01 7:37 ` Christophe Leroy
@ 2022-09-01 7:48 ` David Hildenbrand
0 siblings, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2022-09-01 7:48 UTC (permalink / raw)
To: Christophe Leroy, Yuan Can, akpm, linux-mm; +Cc: linux-kernel
On 01.09.22 09:37, Christophe Leroy wrote:
>
>
> Le 01/09/2022 à 08:37, Yuan Can a écrit :
>> [Vous ne recevez pas souvent de courriers de yuancan@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Remove extra empty line.
>
> Don't you have anything more exciting and usefull to do in your life ?
>
> This kind of standalone patch is a waste of time for both you and the
> reviewers/maintainers.
While I agree with the general idea of that message, we could phrase
that a little differently I think, after seeing:
$ git shortlog -s --author "Yuan Can <yuancan@huawei.com>"
2 Yuan Can
The linux-mm list is currently fairly overloaded (lots of new material,
reviewers/maintainers having a hard time to catch up), which is why such
simple cleanups that could essentially be done semi-automatically by
tooling (coccinelle scripts ?) are not of general interest and rather an
unpleasant distraction for reviewers/maintainers.
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-01 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 6:37 [PATCH] mm: remove extra empty line Yuan Can
2022-09-01 7:37 ` Christophe Leroy
2022-09-01 7:48 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox