linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
	Yuan Can <yuancan@huawei.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: remove extra empty line
Date: Thu, 1 Sep 2022 09:48:34 +0200	[thread overview]
Message-ID: <df6f3926-da31-9361-b19e-e19ac3937ebf@redhat.com> (raw)
In-Reply-To: <0e2ea2d8-5b0b-107a-c679-7d5a7e37718f@csgroup.eu>

On 01.09.22 09:37, Christophe Leroy wrote:
> 
> 
> Le 01/09/2022 à 08:37, Yuan Can a écrit :
>> [Vous ne recevez pas souvent de courriers de yuancan@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Remove extra empty line.
> 
> Don't you have anything more exciting and usefull to do in your life ?
> 
> This kind of standalone patch is a waste of time for both you and the 
> reviewers/maintainers.

While I agree with the general idea of that message, we could phrase
that a little differently I think, after seeing:

 $ git shortlog -s --author "Yuan Can <yuancan@huawei.com>"
     2  Yuan Can


The linux-mm list is currently fairly overloaded (lots of new material,
reviewers/maintainers having a hard time to catch up), which is why such
simple cleanups that could essentially be done semi-automatically by
tooling (coccinelle scripts ?) are not of general interest and rather an
unpleasant distraction for reviewers/maintainers.

-- 
Thanks,

David / dhildenb



      reply	other threads:[~2022-09-01  7:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01  6:37 Yuan Can
2022-09-01  7:37 ` Christophe Leroy
2022-09-01  7:48   ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df6f3926-da31-9361-b19e-e19ac3937ebf@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yuancan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox