From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BB5C47DD9 for ; Mon, 26 Feb 2024 02:38:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCE596B0135; Sun, 25 Feb 2024 21:38:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7EE26B0136; Sun, 25 Feb 2024 21:38:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1056B0137; Sun, 25 Feb 2024 21:38:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D5F06B0135 for ; Sun, 25 Feb 2024 21:38:38 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 468F240666 for ; Mon, 26 Feb 2024 02:38:38 +0000 (UTC) X-FDA: 81832396716.17.FC5274C Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf04.hostedemail.com (Postfix) with ESMTP id B72F440007 for ; Mon, 26 Feb 2024 02:38:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eH+ZF+JS; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of fengwei.yin@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708915115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=scjENN/qjh19I0kT4aAGIGIdpbJ1E/Pwt9pRDAHvP4M=; b=0l0kUFqryjs4R14/7q38IuXuo+WS0SrRw3oaMkDOlJ9JSJqVtFl0s7JpDHLWlr3T0m66Bd xedYVESv64buTkpGQAJ4d6EvpOfjOxTN5FcUHe+/5yGp980tUFs0zOf0TyrP7UG+ivayV1 UUk4Q7JQzdwD1KhSGiWwyaLCjKv4kx8= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eH+ZF+JS; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of fengwei.yin@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708915115; a=rsa-sha256; cv=fail; b=GwEss4FfkFrr3amolYrYX186J3cJjUZyXps21ZEJbuv8jjkSFr6gK4+U/yVRZaCnXhE2bv EMwvdW6VXS/hAHcUiYDhSLOoqOBk6syzNVrwumNO3F8b5ZhZVJCrHfMWS46uPNEg+wc3dN BHjprYj0JeHmqaLL6N7+QoqVP3pO2tM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708915114; x=1740451114; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SKO+sEShajXk3qW4mNhlBRXz23Yc792hOqYx0hl4Wu4=; b=eH+ZF+JSrmHQh4HPohkwDyraBGIka07/Wm4ALW/SCsfvYWFQZTqxWski 3QAHfxqeMFJVJz1s8avB3uJrOEW/+pluNqAyO2r/tfcKqSHPtzQ7ere1h qHNZp95//yO8+4yBtdPibyJQ8Ho9r2cPEtT6FHlJdDvvFnOXJB1M4ixXT z5CsUDLrsZlDK4igobN7TiRmtOGgLjocKUHzfIqim7JjLwKAD+gpYiriI h/vwVyEiWfbxk1XjIdnEuGXAJsZ9FhBtdPtxRzfoInE88rDWIKMoPSLpS IwxPDGYA2JfEMe2hC+Zw5ZzleevNaWEIqRc2bodtedYen6nF2y/L+Cb+7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="13825517" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="13825517" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2024 18:38:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="11230594" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Feb 2024 18:38:30 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 25 Feb 2024 18:38:28 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 25 Feb 2024 18:38:28 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 25 Feb 2024 18:38:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e5o4b1whu4uIisGoFJlPLHRlpe5emSbHESh8JnpPehAHYXGVv0WLDCOy7DcwxCh77AblEpcR6qhNvcK9iZPAV+/SyBm9nLc/PMERSe2xU7R54bLdo9f3NFnmkLsCNlPiP8EUOfHI9tM2udoP1yDBYABp5F954ZwxmH5C/Twm3t1umGiW6mOgcLwQFL+/5IjZkeHIPaZFZukkx9AcBJPic9lxH4aRNJCLQrnuyo63c1iU4Unz3yyPcaSaWOXW9lJBtiE2E+xLYuXVMO/COLV14PBWj7bLWS8qnBTeJx3a1/xsUOY4G/N3Sl8XCtQYtiqwHWTveMElSzkIlnfp2gZs7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=scjENN/qjh19I0kT4aAGIGIdpbJ1E/Pwt9pRDAHvP4M=; b=csimTRcKxGyIAw1ACbYTnurVchAQKbpc2BbZOGmk1ADSCM62qs+TfsZzYKSju9IPGShcojTe5t4jWA8ddFXdo02s62qLeBq1n4cACpvYaAb6wOUKNl/9vk2lQdO4bn+n5d1jO0vEyia+5oUfmqWQ8JYT5dGoUIHsPPd0+D1R1aMl26lw2K+a1ZOMrW4mgEOQH1pFi0GUgmpWQQ4RtuKO+B4T3ELc/icq+Ps6sUsIz576sHjbxXChMa3+OSKwC2SMb1X6CzqYzdnjdqH/z2EjwDEKK1gsPMFPvk0dfnqSyjHFCX4qeQ0CyD2ErsWUhxGLEQe+pg3KSfn2NCvl3lD/VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by PH7PR11MB6402.namprd11.prod.outlook.com (2603:10b6:510:1fa::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.22; Mon, 26 Feb 2024 02:38:26 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::65ce:9835:2c02:b61b]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::65ce:9835:2c02:b61b%7]) with mapi id 15.20.7339.022; Mon, 26 Feb 2024 02:38:26 +0000 Message-ID: Date: Mon, 26 Feb 2024 10:38:31 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free Content-Language: en-US To: Lance Yang , CC: , , , , , , , , , , References: <20240225123215.86503-1-ioworker0@gmail.com> From: Yin Fengwei In-Reply-To: <20240225123215.86503-1-ioworker0@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|PH7PR11MB6402:EE_ X-MS-Office365-Filtering-Correlation-Id: 94a13e8e-57e1-469a-228a-08dc36740231 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9UlpUevnK08kwJbO7a022V48T4E+IPbophu72CQKj7mqDJWZo/00wMbZfN3RU79DHPqYDmzTJWOHAgJYxhr8X2KKFeuoGGJo6HxKxXFSw3zxl4SxvZgNMVpocsH43ehFvmNIzWl6qbFVKMfaFlCvCv8Wz+voF2zdJHQE+axiibDHih/v4o5jD/FWmLyq1g7hrbX9xHxSaoWo3UpgoNvNzMWj5AUSCAXXan2AjDTLc5lmABHto6/5a71p9eirqO0CjU2Lu+jnP6236ksz9NA4S+6kYJRbtN8uRwLoMRI+4smwOEkRc2IItjaNjRsauNR7EWbPYQtEeFWxZxxEvu5EnWtrBzrcBZWg92tba5CleGXAufBH/v0cEqeMi7T1o7et1qviJ2azEHFEcXFSr/sgdAAazaXtZ6bt4cFMREPry3mxOsEqoX0XtN0d/gmTLkqazCymdNzvBCbxgP2PIOsiM/809Jv4sQnSQtusCK0wcD91YZW0Nr9+0MGQrXJ44FbgV13iXtvJhhJZtobiZQO713imMusM99D/y6biYKGDUWZ9mpkNqG0BltFQNdtmJNAWoJ+xLbvqaf/ygx0se8i6Pf4HgDlEu9X5BcDxjm7UE3hNJXmFEtvYXbIHjIqvuRjF/WX9bLBcaO2i5NlFfFt/9w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGRvRG5SbU5Pb1VGMWVXZzc2MlhkTStuQ2sySTNKK2grVGtQM3hXdHA0cmhE?= =?utf-8?B?NDEwb0dMYlV0cFZHK25ubXBHRnN4OWFocWczSnY1RGFTdlFhbHlleFQ3OTRn?= =?utf-8?B?d3hoOXo4RkFTU0lucEtCSCt5ajNUM0dTcS9kNkJxS0R6cFJibU5iZ0l4MzY5?= =?utf-8?B?OUNGUXA2ZGh4NGxIa0ZZbnhGZXczZUtvdk8rZXFsSnZML3FQSm8xV1BvSTZH?= =?utf-8?B?NFBudHhrRDU1UXZSQ2dndmxkenJOYzBkdExDQitacC9HaHJDMlJFZjllQUFw?= =?utf-8?B?Nkl0ek51OWYrdVpJNkZkdU9BQ1kxQkl0M0IwN2VaSjFBSktiYW43MDQxRlFX?= =?utf-8?B?VGxJaC9ya3VlWXdGSGhneUdBQmMwSVJNRDR0VkJUK3pKdDlmMGtuMThmb1Bm?= =?utf-8?B?Z1lmcGJIdmZXeXAvSFFueFo2U0NKNmt2YzRjbmxhcXArT2dRd3FpZmVodHVI?= =?utf-8?B?UjFnM1pwSWF0dXlVZDh5cUV1OW4yODFVcGtGV0hwbzVVWHNVaDRzendENEVS?= =?utf-8?B?azk4SEtWcGFoUmhYbG94bkwyVUJ5V2lRN2tVbVF0OHlBZDFVL3UyQUlrcE5v?= =?utf-8?B?Z2IzUEE0S1Z4RndmTmN0cXVuQTgyRm5Xb3ZVbXpkcCtJQVo0R1NaRUlxUnpM?= =?utf-8?B?Ny9JYmpjU2Ird1VJNHZVc3NkV2I1VS8yQVlXb0JsODJ6ZzBFK1VGSkVvTFdO?= =?utf-8?B?aUdTNWp5U3d0R0tkeUdMTGlDa2hYNlZWVVRXVzNzcFJlWm9WbFRBcHhkMmxk?= =?utf-8?B?U0MxTWkwNVBhQUJmcXVpd3A1a3o3MmZGNWtISFlmSTA2YXVOUkgxQnAwSEhG?= =?utf-8?B?UUdyTmh5Z010Z3I2MW5BcTduOTlLWFBJNEhrMWdIVXJKYWVNZlpFOEhwa21y?= =?utf-8?B?M2dlU1lFdEYyNG5rS0VBZXk0RUJxdmZ1cHFjK1ljZDh0TE52RDZSZ2JrM2Jy?= =?utf-8?B?Z09ZSTc3c3ppdFNoZ0VPVjE5aWZKcU01SE9tdW5ZbjNlVGt2bzBLN09HYVNx?= =?utf-8?B?VExqaW8wTzhjSEtkNGc1Tlp6YSs1ZTFBTUQyMzZtUzR6YzlkVThFN2ZMV0t6?= =?utf-8?B?SERCRmZiUXV3STB2M3NiNTYzekhsbUpZSkc0R1hLQVFuNFpsUXQyYkFldmds?= =?utf-8?B?SUxIYmNHdmR2bnMyZFdzQk9sT2tacWRncTFZeFd5RHFQOHd5OW4zTStiazg4?= =?utf-8?B?Yjd3UHR6RWFQY0UxcWVhbm1mTXdhMzE3NXJrbDdlMG1LODJBWDRkYmJCaDNa?= =?utf-8?B?Ykd0V3lnT2F5dTNZWktVQkI1K09leklOQndKVHcrZ1RvMTlOOUVYVWx4T1lB?= =?utf-8?B?SjFMNkw2OFZPNXExZFFQK2grdTMwRTd0bm5KNnBtZE9MQ0tTRjZZTTlSVUJ1?= =?utf-8?B?K3F0NnhRYmxQR0V3NWxSQllkTnpjcjhZUEcwZFgxb3hMd3c0d00rWTdzOE9F?= =?utf-8?B?V00zdGcwRHdSVmJVTXg2UnBlS0R2QzhxRG0vcUNDL2V4MzUzWlBvbmxaalUx?= =?utf-8?B?YTRPTHZGeHJFamtjekdubUhlWkk2MEhqTklYclpKZ00zNVpPL2FoenpvTDBU?= =?utf-8?B?RmhLaElvTUdMeE9hWWhDQWk4TFBabmdqRWNPZ1RwS1h2eDh5UW02WUgvRFN6?= =?utf-8?B?WWh6MzN3cnFZQ0s4dWZzYWc3aHBzZUV1eHpVdHhTZXlNRnkyaTJXZkJEYmFu?= =?utf-8?B?VGhDQTB0L0FhZWdQTVZtVFVkc2ZPcE9JQkJwSDNubjFlQ3hCSFpUZkJEdUpU?= =?utf-8?B?Wnc2QnZISTB1cFBlalJJZkg1T1VHNGNydUhDc0w4dVc5enQ1a0M1NlEwUXRB?= =?utf-8?B?Rysrd1l3ZCtCaVNTSGZpOFZ6NE53TERvMjljbW80K1N1encwcDV3SUVLcDkv?= =?utf-8?B?b3JIM3pPL1B2STlOQkIxMXZVczNidlJVTEZXNTJHZGhGN0g1TFdtVEFiVCsw?= =?utf-8?B?NVNoT3Ezcm9FcmxodW9oOUJlSEE0TFRPemlzQkJ4dEVmdzkvV2dNODd6SjJq?= =?utf-8?B?ZSt0aVNzMWdFMzJheVVObDFwaDNiK3A5czlzUUJFdkFOR25UYTQxYmJuSUs5?= =?utf-8?B?ZWFmQS9LOGFYTWludEhZM3A2aUZwUFV0ZEo0dVBoWkJqMWhjVFlLYUR3Rmdw?= =?utf-8?B?ZVUxNXloWWI2WlhZRXQ4bHBESVNoVndiNlFvUmVSTHM3RkQ0RDFhWGs1d3Bs?= =?utf-8?B?MkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 94a13e8e-57e1-469a-228a-08dc36740231 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 02:38:26.3396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9wRKsgOVMak6KMANWBmZ6WiWC9AWZkVpNiZHHIrNZWyQJTvz6n9puk9YwDkpyKBfWpxkGQ6AXclix6DZoXcHbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6402 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B72F440007 X-Stat-Signature: 38ddgaefgsf8gnds64t9hjst89gqiihr X-HE-Tag: 1708915113-62333 X-HE-Meta: U2FsdGVkX19dMxk744oT1JwYS9xh2ssbJ3wZ/5XD7eMkiatasao+XNXlwQctE5r3UtqC0I9jG3k4OiSsShqxaxIMAeg6podmVWpPa7qKKGQw09GQVzk4jex26sjRVCO9dnVh4T/i/n0xCq42fM6ZESZM34GhKT2ucjOcP/eJA9pdMjO5Y3LNKBXDlCgZM5IUv8QdOj95io4Yr40DlfosxqlqvKhu+1QNZ/KLmBcTnsRi2pSmQk/jPolEc0ySZ1ObwOVjhYzTTTQYJoDztWVS0Um+0H2uA79Zbqmuk9cniOgyxM9I8cVOixgfT1244JvDVbFBFWQmWm0fq/tPXx+OwmVRtDn740ycL9Syeejr+hNI/mKar5YY7GkwbbnOKxAt3q1nyshcGbx7fxGQ70RKVBvZLYpiJ08XH4J4TXXNyFv4lhwTtZD4EA//FN+qtlG9nBK0TsWMb4+CbMB0q4w3cC09yGYpwqEUC20tpXAGAdrjC0NI79qQY5oOhB0IWJHqSgtKeb3REVOa1BDGqKQ1KnE696YT5OU0U9RzSW9eqdHs5Hqp8TtcTv1B5TqObk0Th5cIUxbV4hlztgJH2GLZ5EDeFGwqapZXZgtl0f08WYr7HzlVgpPojHrM5zzIAW9Aw0CN8HNY2PY+56VrYddbiR5iis5PpDeuDipQvgUT1r6mghGohz+B15aTMxkZQAYS1sNclrXTtL/rEo0Sk/2VJPuJCRKHIPk8yIgwDExWh6P5Jm/uZCeetvxgEnn543EAI/OM7km+wpZk3sCRayHrlcCJftg4rfk6HgDi9zvgezt/GWKzQn0F5X3AANGnB4xWWC6fRMmtI2B0rHtIc4M5AzMzaZVT4CvNx7CcNWtqOQwDi6CT9X8vDLQ2AUDsh1xzD62afBW2sJpTWRSvvo0Xx+wDoDo6zEnfeZBC9kfqg7vu1RoOi0L5hSfc7v+nlO6znr0MWbSjFXZk41NnIqh klEtlm8s XNkz5BjBBhS9B40KYKI5UCcqVpuiP3VwRR2Gjby96DRL/N3k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/1/70 08:00, wrote: > diff --git a/mm/madvise.c b/mm/madvise.c > index cfa5e7288261..bcbf56595a2e 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -676,11 +676,43 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > */ > if (folio_test_large(folio)) { > int err; > + unsigned long next_addr, align; > > - if (folio_estimated_sharers(folio) != 1) > - break; > - if (!folio_trylock(folio)) > - break; > + if (folio_estimated_sharers(folio) != 1 || > + !folio_trylock(folio)) > + goto skip_large_folio; > + > + align = folio_nr_pages(folio) * PAGE_SIZE; > + next_addr = ALIGN_DOWN(addr + align, align); There is a possible corner case: If there is a cow folio associated with this folio and the cow folio has smaller size than this folio for whatever reason, this change can't handle it correctly. Regards Yin, Fengwei