From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C561C48260 for ; Tue, 13 Feb 2024 20:25:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 890678D0012; Tue, 13 Feb 2024 15:25:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83FCF8D000E; Tue, 13 Feb 2024 15:25:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DF858D0012; Tue, 13 Feb 2024 15:25:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5DE188D000E for ; Tue, 13 Feb 2024 15:25:15 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CC230A16C2 for ; Tue, 13 Feb 2024 20:25:14 +0000 (UTC) X-FDA: 81787910148.01.4314C06 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf11.hostedemail.com (Postfix) with ESMTP id 14DE740002 for ; Tue, 13 Feb 2024 20:25:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=BMVTDFy4; spf=pass (imf11.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707855913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCGixdHWsWgr0kpLRiyA21Y2NwWmOitF91ZlZjMh3kg=; b=LOMcUC9Gb9WW20RNpj/gFqIm8ikJpsRQAi6H6gw/UbOWSVyaNsNPxcrU9mYnw4UJm4vmUZ kpvLBtGbMh0J4HJJ9t4AcZ7OQ5XqQSFKTSI2lIWcFpLfcfqz8fcsNlwnUGbfTjyae0qmhb dMnk0pEezorSxrkDITkGDEMQiQcvccM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707855913; a=rsa-sha256; cv=none; b=hrSKOfaTC56nBYA6JFehi19JjXNRjsjcKRCsbHZaBceQskNPwjxu/CEVp8OUxv5pAtgogI sQSD36n28RlkEY+EFciLiL9CcWmV8jCjJaGFA2VkfnEtaKl8vbKkM/TDwckztNL8J/feLO uu5G0kU1KUULSzabye3yzh+EBSvDL0A= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=BMVTDFy4; spf=pass (imf11.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1707855912; bh=P9vMmHmk4NQr49aA6KTl5XBWw5rmaRyY/3LRJfNYz/Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BMVTDFy4P2KoGWV1cFjgJk/Z2iwbE9COqomLBtRzciQn4MOcdMZxH4Yx4H+N6rFct 75b1ouPchajvOCIzq/urVZEiaRNjBhwJkFVRd08p93Ts8T/Qhw05GqtP4Ap58OVFoR kXpHWlDZBMuKtvoCEwQhycVscvhcJ3A7tEGbH3Pn/Xl7YoJ+IowPnL8nO6SRXILUOP dUnaIV4NdTQirgC9eQbZAAl5ZwsVm8HyvB4C92mcosjuigmXBPzX7tkNi1ZRX1c5pN JbgKlwiEm/CePGQksZS8s05mBYMfkWxcBCZFHyGxrFh85UrZk4QLm2dZqXEgBXJ2aA d1iYF7K9nxa9w== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TZCVv5CSJzYVb; Tue, 13 Feb 2024 15:25:11 -0500 (EST) Message-ID: Date: Tue, 13 Feb 2024 15:25:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/8] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal Content-Language: en-US To: Dan Williams , Linus Torvalds Cc: Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Andrew Morton , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka , lukas@wunner.de References: <20240212163101.19614-1-mathieu.desnoyers@efficios.com> <20240212163101.19614-6-mathieu.desnoyers@efficios.com> <65ca95d086dfd_d2d429470@dwillia2-xfh.jf.intel.com.notmuch> <65caa3966caa_5a7f294cf@dwillia2-xfh.jf.intel.com.notmuch> From: Mathieu Desnoyers In-Reply-To: <65caa3966caa_5a7f294cf@dwillia2-xfh.jf.intel.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: nfchpyyxj8iw6pdearfk9qgo6436b9ms X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 14DE740002 X-Rspam-User: X-HE-Tag: 1707855912-550320 X-HE-Meta: U2FsdGVkX19e0Y57Vk/RRpmiaW0azcumTtpTeQDLM+LwIYtwU0RORCnWa+b95WUhWEGfo6tcyCOmbS1xs+c+NzK8yEqG+tL1s3Z6EQQmdXK7daDTO7NIFuHhJtV1T1YzwP2E9n9vKDJqziQIVPf0nsQCYhrCpCgyDu2vzmbfPbFMDdwD/sE7DgzgtePoyALqoUBIQ7ITLJIhqSHXJ9Q8rudMdpW1Pv9WGoY46Ng9VjpGGbIPcBEnKY8ZesMa+OWaZInwyvtkUkr0yMt8rCP5kvy0Z997FWax4XDAocVIMZNgIB1XAQTwUZUE0qRoI/WRuUZmb53EL9/ZkJkVxPX2+5Gocks+V2wGY1Pws1ArkiEbhjLxvymIYSaX1Il3PqwJzACMYrLQqSzLOT/40EnXu7d8MMn2C1M+AmV6dwsEhIBYEwrfr/27oYtqTzrPohdiBTMJlQiugRMDO7My/Bjwh8PlRva8N+rPf2yD84LSk6nOrDCaZlJqyYvbQdGp9ajK9NgOwpB0cjymMrmnBc8FwRIlNdQyKng9RjmyjoNmXIapr01OscRPz6doBuesZU9lxRAtOtnlou9UZ/8aFkBjozFhVv+E3sqauBeSknkBEpoYkFWnxF8PE6ZmDVLC1YOCc1BwLyo22TeRNWZk/ojTsBZr2UMVsRY5KIp5OsmCGgfFSNbnlgdRbQ/ikuv88jssBdZZLw5DHz/EPhHmCimPwkZDFNskxejkGMRZOLajE7BvxLkcwFN0lEkprVE4wSAWAhP6CR0jH7MulUOKt0YznXtnbDVJSD/opxLQUQpar5rssRAhPXhYKuGkxmorCQC71pJnlonOoJ0yLz+BQogkxI7JDb0ByLVEL27H3+FWRybcw5Q8icU4WGmCAYDZzEF721P0HxogIBBi17AIscaeCyd78YLw1XdDrOPd9o+WFquBT4btEqq/RB8IgXN1KHQ/+YK0krUnAlFay53vY68 KyT3/RUz Gt4JpcWeMuCDQUepd1RYTGE6hcDCp5jFMswRJfkV6yeRYnGrpvLKtWWwQ52kZ5WpYBVbMjB7Bfz22hpsvJ9ehn8Ys14NAfjnjBWp2kxu5Nrs/OMt1ndbpRdSqTtuOjoNfQHtSquDmvH7JLq3c60dKFc+nLyI7UIk/Tc+SVfZNq/rFBXVNtMhlUVjy+mE44kR/1oP5h1aR/tGYbtX0Ho/4nYNrpHzQUpwRxQsnP2Fu39BChdQrhfmhN3AFZYSqvfUvsHZy6Du9EDY5z/qbwNoeZVt6G0Qb4ksXs69mg6lJOprsvIpq9pg0AumP/khHmd9yCWMvHhH5S89Noq8LpD+sK1ZbMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-02-12 18:02, Dan Williams wrote: [...] > ...and Mathieu, this should be IS_ERR_OR_NULL() to skip an unnecessary > call to virtio_fs_cleanup_dax() at function exit that the compiler > should elide. OK, so I'll go back to the previous approach for v6: DEFINE_FREE(cleanup_dax, struct dax_dev *, if (!IS_ERR_OR_NULL(_T)) virtio_fs_cleanup_dax(_T)) and define the variable as: struct dax_device *dax_dev __free(cleanup_dax) = NULL; Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com