From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35822C678D4 for ; Mon, 6 Mar 2023 13:49:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C215280002; Mon, 6 Mar 2023 08:49:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 524ED280001; Mon, 6 Mar 2023 08:49:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DA3280002; Mon, 6 Mar 2023 08:49:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2841D280001 for ; Mon, 6 Mar 2023 08:49:41 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0046C40493 for ; Mon, 6 Mar 2023 13:49:40 +0000 (UTC) X-FDA: 80538606162.24.BEED034 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id A161B40021 for ; Mon, 6 Mar 2023 13:49:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OI3+9jkP; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678110578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8cP7M7fJa+CiXjUaB/Z/GeLdvX1vVsRhtfliOYgNW40=; b=h34uyv/qPn7JAWMORwgIozkHY5hCbmnu65+UI18f6eeBMJTZffcPDof3/gvWfd4y/Ekyys GsEcSC6g9zO9WnTlXnwCoIrTgLBXVXg7RqIPa6bUiO2g9NsXv03KXMSdxYt5FwILVBesbH 0PZs4RNxY9bqRFnL1om34iZ8ggrMyF4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OI3+9jkP; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678110578; a=rsa-sha256; cv=none; b=ajKfO0P6ozaFaEOzXYG9rjJ3jImm1zjKnUwu8wU47MXmtN9Gdj1ltxMQjnPe67dzf4V5jr iLbJf6wab+5/MfV+75EFUknn9zxnSpk/PhM0y4oRCDxWqIbOSGSxRBLj503QGBqlIoMaxV RqhFvs3MZ4cst2ExL8vYFEsqt0kMXoc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678110578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8cP7M7fJa+CiXjUaB/Z/GeLdvX1vVsRhtfliOYgNW40=; b=OI3+9jkP3A4iIE3zP0cN76rMZqcQCanTs6rDN5uh9GIb4G9f+ZlQcf+a89awzVFIem2XjO OaBDEvsCILeYsTPXDcBiINz48EsJ4pbSXcistsvhxkUqmxYKwF/0Qr8ZOiAMfGCaa2IYXI 7Q65dUMnxeDbA3GM53+WZbLoDBZvE6U= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-QCur6szEP1GB4_vDbLGvpQ-1; Mon, 06 Mar 2023 08:49:36 -0500 X-MC-Unique: QCur6szEP1GB4_vDbLGvpQ-1 Received: by mail-wm1-f71.google.com with SMTP id k36-20020a05600c1ca400b003eac86e4387so6766379wms.8 for ; Mon, 06 Mar 2023 05:49:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678110575; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8cP7M7fJa+CiXjUaB/Z/GeLdvX1vVsRhtfliOYgNW40=; b=38SHBpuM1C+ADv3QyXgjIIuvalkNGgoDc2SgP4YtsL8ujuG/GUim9vEmEna7ZjUKgo YWTovidKWshAZW8Y7ec2JYs8Ao4/Y3Etocn1Dl32EEl5OgRJO9tkrBI1qEG0iZFyKQCw amTk0NPq6j2ZK7ZOzMRF7cT47kSh3qCOgVutg15ET4UcOKIkI6fCeARrAO11AjIqbQAp 0jdVh2nxzWNBgrSE30WnFSyrv/UzZqhYQw6I39HDLkogqWIK7DNYozxEYys++4HKkn// noaFVci03taKZAjk2hWBWgTg2djiTjkU4RKem9EXpHVP5WoPszCAi8JGuaeLbdyAatgP NgaA== X-Gm-Message-State: AO0yUKXN1d0PnrP6VJ2jDfTBh4scjiwk7Gpq1vPSXmdLYMPh7jNCaLqu 3aBpmx1fS4Fko2HvYQfbWr2KAJIBfVp2Lfs0CynnTJkquW48v+1NuLW60dqXTXsS+PQfGcio6Za 924T2LJkJvPI= X-Received: by 2002:a05:600c:a05:b0:3dc:42d2:aee4 with SMTP id z5-20020a05600c0a0500b003dc42d2aee4mr8471201wmp.25.1678110575724; Mon, 06 Mar 2023 05:49:35 -0800 (PST) X-Google-Smtp-Source: AK7set/V0qYAHNZZr8AnPKR/CcJ+o9o9/kovvogYCJVbCzpbcLU9tlAyaT2cAzLtC+FSfpsmzbHjqQ== X-Received: by 2002:a05:600c:a05:b0:3dc:42d2:aee4 with SMTP id z5-20020a05600c0a0500b003dc42d2aee4mr8471179wmp.25.1678110575407; Mon, 06 Mar 2023 05:49:35 -0800 (PST) Received: from ?IPV6:2003:cb:c704:3500:b8a3:191c:eae:cc05? (p200300cbc7043500b8a3191c0eaecc05.dip0.t-ipconnect.de. [2003:cb:c704:3500:b8a3:191c:eae:cc05]) by smtp.gmail.com with ESMTPSA id z1-20020adff1c1000000b002c70c99db74sm9950215wro.86.2023.03.06.05.49.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 05:49:35 -0800 (PST) Message-ID: Date: Mon, 6 Mar 2023 14:49:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm: remove redundant check in handle_mm_fault To: Haifeng Xu , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230306024959.131468-1-haifeng.xu@shopee.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230306024959.131468-1-haifeng.xu@shopee.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A161B40021 X-Rspam-User: X-Stat-Signature: rohsqabt68m6f7rx1eq6wof4x5ucks5x X-HE-Tag: 1678110578-882350 X-HE-Meta: U2FsdGVkX1+r8hJCd4biF91IA8sZeg85Zvm0O3HiheYnI7S5FYhraLp8j9Y3Gf8MWIoFHP9zttpPLA9sfHOnL/vAP7nqozmAnPwlPQY8rWStWlAgA2wyjYsrlNkpqSsdHCZTQBhZmQYKZXQiwKvlFnZb8LfuoM+WdsYFN5bC3ikPkn2PocW1h7yjEra5slt2IPmTg9UtJgfIJ4fTj6ghx4rsqnoMt7pBG3z0yOJa36R6Rry+7uBh44zSa1UEUWz7MnYC+KOXeZB2e5Y0wHAXZ38joeWlpUsQzW9IavPE4oN9+c2ueiQrgXMCyawXjjzfqOPNZpbDAqo5KJiaREoGGlMRBHkRZrfBTzvpLwRWHrqKZh9ELhb5Iro8LVj22XuqvsD6fYrOp4tRtBSU1Btlf2L4wKMPN5zfYOQ6+iwWV5lhEBBrpsH7pfb6IlmkcuT6NDe1S0Big7QT9jWfAE5Ug5acHunzRWfQAil9iD+qn3Ru/7vk9JsM7YwOQJoCTvmyCprrRqb8UHhNCj0oc0LLTcnjZnL0+wncndOSqXiTrlovaMsZBob3j/A8c8opGk+Z/A07inKq6wj31BdMhuAP1WhmTbuuwojBwpmHjndFUcEyiWW2sDBJef4Sfzv8C6oVFgJQWPNiMvPi2RDDFjyPuZ8gNKQhpdhq2fVq1kVnF9V4MivwY+YbpPe/ATkmbnDNuiVC8dFEH98K0umOTeB1fEB5suRhK1bSIdfurxUyCXLb2jUx5bwqJUpUOPD6y+P1T/2eLNYnS4A4Zft+9rPjG71oHAF/kgigqz9EcokV0fVII/a72xAbRD4IKwDwPocy7kiJk/Hf64xr8MF9mlP+36WgbgHUikrkbYmeqvJt/eWq4tisZzqIIQPXNpHEEo8piULdBVJAipGdubIjSu8//xfYXP5eevlJmOkb7waF9FGxhUToDP7v7I1gny2UQaIvOlcTFGlQnyUyo67mVSV VnnAL4Hd KevGjAllbVaMn+nPGmCE5ygpE9PGCJOjledDJ5oLJxviP9zCj2MF51gkgvuMIhSQUaW1buB8BD8sMPvqZaEuSEj44zA16mOxy3xkWuOwa23RNQP7XS38lAmMF45SEE28jg3b1G3rP4hHVFxhEZzgjIlUEUYtoGWbPJmPqN6gTUlSghblYKETLZWoxc2hm4B2rcfmojyhOKF+B+qXyrX+6Y5p8qo1WHhjZJHaRoVDZCQppMv6ZkKfbfqd4D+oJ5dkMPeeCv80UXYWKBmhJKf1Hcvja/NiFy19A9uLF8PayksgYABKxNjPdTH2d2elzM4YeoWjZOEvI+BRaZvKWrneArxUblP9TGc78aqGCDDX2jZ3zICIaN6IPayo+SKv5TzIYYuc8/zXP3lDrSKRX9+jx6hQyWrt07OLKxnP9YG5n23nIlDywq12/s7C7dQ955Xjr7nap X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.03.23 03:49, Haifeng Xu wrote: > mem_cgroup_oom_synchronize() has checked whether current memcg_in_oom is > set or not, so remove the check in handle_mm_fault(). "mem_cgroup_oom_synchronize() will returned immediately if memcg_in_oom is not set, so remove the check from handle_mm_fault()". However, that requires now always an indirect function call -- do we care about dropping that optimization? -- Thanks, David / dhildenb