From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C57EE49A3 for ; Sun, 20 Aug 2023 00:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02E848E0006; Sat, 19 Aug 2023 20:52:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F23B98E0001; Sat, 19 Aug 2023 20:52:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE8E78E0006; Sat, 19 Aug 2023 20:52:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CE56C8E0001 for ; Sat, 19 Aug 2023 20:52:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 945CC1606B1 for ; Sun, 20 Aug 2023 00:52:08 +0000 (UTC) X-FDA: 81142656336.06.FD33299 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id E5D23C0005 for ; Sun, 20 Aug 2023 00:52:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GDPo+eqA; dmarc=none; spf=none (imf22.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692492727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c94fHYxIWl9lBifgcspinxKU2QHJURmIgDdd+1otOjo=; b=PvGNhei0+PzqtCp77O2zeqDmtb1c+npuzGVwEfuv5D9zRX+SblMjYzpSbgobyxQW6UZOOm uJOqf0Nj8kAxe78VnZTLlQjrBf1QovqaVT6kykE12U6Bd560sX0qsa2UG5XRJwcazr5FAu eD8c/XM+B1bnGjXc1jd/JCFqnYsxgYc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GDPo+eqA; dmarc=none; spf=none (imf22.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692492727; a=rsa-sha256; cv=none; b=GpGtf5eBwEkgWbsb3ZBADwAQepfV0yRVi07ILgwCWkdd9czevNo25DD2hfVjKzs6V7JN51 hblJaGj+F9DGfrG6kYreSJoY49Nb37bIlwOEYQEjlhbqvirP9+8dKybQz3RMdw/YskSb9b m24rcawzNq/XDBVOD1MkrxMaKmr3+9Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=c94fHYxIWl9lBifgcspinxKU2QHJURmIgDdd+1otOjo=; b=GDPo+eqAkD2WDQPmJ2y2konEcv fp4a5Zv29YS4L903aE7mPxLttTS8765T5saJnuvJPvyLla6eC4H2k15yRLsZk3R7Ki3u/Lvn+Z6zE TGWQQ/eEvCNmfI5O51mNrdR+vrat/83NmlbCiG0Fm+d+ri9Km+r67lVW3RYuVeaYKW7ngGHR5K5Si zK6NheDXhSjOVaSmWrHbtKSoO6sXELTTK5D77Co26QjB5BuNUzGZ8UtJO7lZS2QwY/IwZQuYup6w+ GTVhZEM9xaKiFQzvO2CwBclmBFzETmmMymycokOU0UkC254WwvrdvT3PfUFGAUDDFCZPe1AlAbuNf YcJfsVmw==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qXWfl-00BHp7-1H; Sun, 20 Aug 2023 00:52:05 +0000 Message-ID: Date: Sat, 19 Aug 2023 17:52:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/4] mm: Fix get_mctgt_type() kernel-doc Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Mike Rapoport , linux-doc@vger.kernel.org, cgroups@vger.kernel.org References: <20230818200630.2719595-1-willy@infradead.org> <20230818200630.2719595-3-willy@infradead.org> From: Randy Dunlap In-Reply-To: <20230818200630.2719595-3-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E5D23C0005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gndy3kznbrz7g819mwd4cc5k9pbioird X-HE-Tag: 1692492726-624691 X-HE-Meta: U2FsdGVkX1/sCsEwKH7dJ7R9ebrdEpcZ+/Un5J48NdmCW487zfr6WWPxmg/Th43+vUHDSVTplH6Q2IVKpMDOqzDZZxyPExq3o33lpIzNgSRRqFEm9HPS6yzyLQVhYnNoevi1SMq/Zwf1CKBpLIbyH9+j1OG8FjY8AvCa5GWdV60EGServ1iQwsU/xygubBlcD0ZfA1RPDIOMuRZxcvw/k0/LgdNzPsz7Ta9UiDdvwzQborPLTYQ1ANrl0o4sPCxZ5MBP+KrUqzUAFbYP7OY3aCN12y7kNeVfNH5JOaBLrHuI6Q/ouDhAoBLrmIxbz79onZFVIpah6RfZbkXojX4uiiF+Y1k+xmgy1KBy4CMgroYB7zgsb7IAf1bAkXkcj8f/J+6HbVaWA3cEFsEKHD+TG2yefBSz7q+vy4EQMoGbMd8WCnr+i1C5eCn4+ZbPfoVz1aW/pw5zH7SZt/spFEWLpFpFNSDmkq/EjKD4peUkJumJBObcbHwtwXM2z2JM6D5MZzqce8Dj9YMDhGVavPzbGRFNe6uZZxwORbHOAirzMDlkHSozfLyc+4Iz3kEMii0XuM4opkqy7I8pj3TdpPi5CN3t3HL1fHSka3ZJLN0yhEfOaYJGjVaNNaFmIRpghFm9HlLHp1EQF87PxER++nvjTNkZUgKuXO6RBWZslMBSJehqOcDYgsflkYJicZShIgQ0RcDEN1goXJ+OkdLU5wBILuGSSYG8tYHo+x73vgGjk12fmO4mfA1Jo3ZGR/wACeNprMVCFKRPm+FK7BmS65EZnK6EAPzqxlylIU55mBEyLX/oW83rk1FRlc4YL50BTct7pzpLJ6o2IJPG+AO73ckv0qr/PqN46VB4G/y/ZWyPajaa6MpA9IikFi27iln1L98G9iJg97O/E8ogDwvU+RXCjkGrohW5X0OV4hKFVWNzhM0PXrQhV4J/eXdxSJRPO1SB7pBhIMAGu6WhIdMfOxq YMNbUNkJ MsvZPfI0Ujvz+3zcYCIoDnWPSeZW3nRzUizPnh+JO5KdUcaMYFth2SdQ5RKPR/9aspahLmo2Eup72Mbfv7tSwjwdYgwhLF3USkoxqRShYUhCrqTOSeSR2ufx4bRVKQYYCtwLlxfJDt80y++ZkzUgrJEnG94uo6HWHnTiUdlsm0+kMzj+Qj9JRLS7SVua9hWs24f4x8Zs7V++8JmoIolGHDj1nucM8GpnAr62Lpfcm6IaMqDODJSfCVR9RR6K5QaqFrk1lPGIaGM8MFtaATJafazMkmuY6MQnX8vhAVyp+NuC5cvaA5PykbuFDSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/18/23 13:06, Matthew Wilcox (Oracle) wrote: > Convert the return values to an ReST list and tidy up the wording while > I'm touching it. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/memcontrol.c | 31 +++++++++++++------------------ > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e041ba827e59..cd8b3ae6b8d9 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5850,25 +5850,20 @@ static int mem_cgroup_move_account(struct page *page, > * @ptent: the pte to be checked > * @target: the pointer the target page or swap ent will be stored(can be NULL) > * > - * Returns > - * 0(MC_TARGET_NONE): if the pte is not a target for move charge. > - * 1(MC_TARGET_PAGE): if the page corresponding to this pte is a target for > - * move charge. if @target is not NULL, the page is stored in target->page > - * with extra refcnt got(Callers should handle it). > - * 2(MC_TARGET_SWAP): if the swap entry corresponding to this pte is a > - * target for charge migration. if @target is not NULL, the entry is stored > - * in target->ent. > - * 3(MC_TARGET_DEVICE): like MC_TARGET_PAGE but page is device memory and > - * thus not on the lru. > - * For now we such page is charge like a regular page would be as for all > - * intent and purposes it is just special memory taking the place of a > - * regular page. > - * > - * See Documentations/vm/hmm.txt and include/linux/hmm.h > - * > - * Called with pte lock held. > + * Context: Called with pte lock held. > + * Return: > + * * MC_TARGET_NONE - If the pte is not a target for move charge. > + * * MC_TARGET_PAGE - If the page corresponding to this pte is a target for > + * move charge. If @target is not NULL, the page is stored in target->page > + * with extra refcnt got (Callers should handle it). I would s/got/taken/. > + * * MC_TARGET_SWAP - If the swap entry corresponding to this pte is a > + * target for charge migration. if @target is not NULL, the entry is stored s/if/If/ > + * in target->ent. > + * * MC_TARGET_DEVICE - Like MC_TARGET_PAGE but page is device memory and > + * thus not on the lru. For now such page is charged like a regular page > + * would be as it is just special memory taking the place of a regular page. > + * See Documentations/vm/hmm.txt and include/linux/hmm.h > */ > - > static enum mc_target_type get_mctgt_type(struct vm_area_struct *vma, > unsigned long addr, pte_t ptent, union mc_target *target) > { Reviewed-by: Randy Dunlap Thanks. -- ~Randy