From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DFAEB64DC for ; Tue, 18 Jul 2023 12:56:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B266B0071; Tue, 18 Jul 2023 08:56:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A57A6B0074; Tue, 18 Jul 2023 08:56:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2454D8D0001; Tue, 18 Jul 2023 08:56:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 109A16B0071 for ; Tue, 18 Jul 2023 08:56:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C7CA4B0729 for ; Tue, 18 Jul 2023 12:56:28 +0000 (UTC) X-FDA: 81024731256.16.F8D5943 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf24.hostedemail.com (Postfix) with ESMTP id 7547F180004 for ; Tue, 18 Jul 2023 12:56:25 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689684986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=38/HcavGMLdOTdEvWvrDYrwSNnsmKOja8fA+/259gms=; b=75K5hVHkeWl7dIl9sdKDPr6wDGC4Dk4gGUndnPIJZOhu0fQ9f7bpCShwxJIuh26GJ+2EOX V6oIILUDHl5JlgtLEzzblTvWx9CWER0D3/aqpGLnzBMxX/JPux1zSN3wdWH7lJe7GNj+Xt 6Lup8nM21RMJy/JqCNRThGNA4LNg4Ww= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689684986; a=rsa-sha256; cv=none; b=1bd528/qvrjUSxARUx4rsYdKkotviHuUZOE9dKwTlwiWYnYfhOVZShPc7lwdeYShp3k4NV ePl5WKtQjTA+HL0fLlY3x+3WWmQNmezVEV1v0BgbX2soVyhDAV/nq+SNIKfg2fAbU3LoJB ka4b2HO+u8GJKZeJnlT2BhufJ+9FDUY= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R4zQJ1GN1ztRBF; Tue, 18 Jul 2023 20:53:12 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 18 Jul 2023 20:56:17 +0800 Message-ID: Date: Tue, 18 Jul 2023 20:56:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read() Content-Language: en-US To: Matthew Wilcox CC: , , , , , References: <20230717132602.2202147-1-zhangpeng362@huawei.com> <20230717132602.2202147-2-zhangpeng362@huawei.com> From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7547F180004 X-Stat-Signature: weduk86k7mas498ogrxyh3gjixmbn5az X-HE-Tag: 1689684985-982627 X-HE-Meta: U2FsdGVkX1+knNWlzHhmKy9xuMuQzJFbPIefEUFUHBU9mbimFBHac7w35jgUC4UmGseZbsAeex+Le/+KBIMtGJoDxC00eKe8tfCkUvgy1Ke6AKRnbieaBxaBuF5QXhFbLQNh6VGKpcDQAzAfRyQkGQB2QI9AeQbr+Kq/C5Fqh4MnYzbySQdKNwwrZPBNQr2/8IDVrTn+yyTWGOW7ce38gFHLMqZI2DjfGy9iAB5COBsZ24HOf6xwdYlBeUtQrumtSm3f0SytSM4zp68HL+ZAC5is3x71T/RzoOGreptEC6WQTTGYKJcNnu1OAk67MhiThYX/tJMyviZBjN5tUMvhC8KxoPJI2SwRR7QuvfbLV5CDatd832Dg+fKn7u4U00EPuXhPkVPoxcpvr4X2Z1qhnQPKg6mHNGEG+yJe0yrefsvVdodQBYVdtQDeUUlyMvvm9H8d6NAjKVBHxFzffoql9EACPjzIIEtRAUVsrmLE2eVS1BEzcQEP/bzXCVksWWdpDPmlXXUooYvNwNIiIn80qd+6Qq8Nb7EgkqvXCY0pxGfN2BVx71XibEMdeK80moBxdxAHZHvqyw/hbCAuLAsxK49hcHuKYvwsMcWm8cEdENsM+mALuboj/dmgbgv25xShUedQkxuYtFOM42Yyv5v0wmu4B/VZqr0ItmJsC0Rnjo4OoU0izFhYoJ/gGjQlsFduoZcsJIAg+jFVH3UNtM1sCMB/43CBVvG1WQrb4rygqRuq5ib/EtxUl9D909AoJjGFx6i/xC+FdXLlXMxMvinbT4ASlZmenvpwc967KK+0RkLPFT2pyBt0QqSPfyMuAOt3A8Y0qlLrzAA51lVasVnIzUQp4RgeTQ8nHD6Tqmsqgs3sb9fz9XZrrDPF12ohYWthJ3N5+ZnZhIcZLvxfi71uFwai8rwVtYHPKmNdwz+wm/184Kcw6/3EjOjBLcd07QPhSw1ggycd9H7XVJ0ALqu HeVgJmal 9Ew0262jcomUL5oEeARozIf7FULoTyewIGFCswabruKi1tjr0NzAGeab9e0/5+x+FEeD1yCo2toSCQWZqZK502RLjUTN+7Hb1OT6A2wDVrxAslDyti8rqW4+mPeuII9Ai0Za+9HDUblQiHn9Zf8wjAjAGgkWzlQV483Y68pGcBtoEkorGD6Dxbcri9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/17 21:34, Matthew Wilcox wrote: > On Mon, Jul 17, 2023 at 09:25:57PM +0800, Peng Zhang wrote: >> +++ b/mm/page_io.c >> @@ -58,18 +58,18 @@ static void end_swap_bio_write(struct bio *bio) >> >> static void __end_swap_bio_read(struct bio *bio) >> { >> - struct page *page = bio_first_page_all(bio); >> + struct folio *folio = page_folio(bio_first_page_all(bio)); > Should we have a bio_first_folio_all()? It wouldn't save any calls to > compound_head(), but it's slightly easier to use. Yes, I'll convert bio_first_page_all() to bio_first_folio_all() in a v2. Thanks. >> if (bio->bi_status) { >> - SetPageError(page); >> - ClearPageUptodate(page); >> + folio_set_error(folio); > I appreciate this is a 1:1 conversion, but maybe we could think about > this a bit. Is there anybody who checks the > PageError()/folio_test_error() for this page/folio? Maybe wait_dev_supers() checks the PageError() after write_dev_supers() in fs/btrfs/disk-io.c? >> + folio_clear_uptodate(folio); > Similarly ... surely the folio is already !uptodate, so we don't need to > clear the flag? Indeed, the folio is already !uptodate. I'll drop this line in a v2. Thanks for your feedback. -- Best Regards, Peng