From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A4AFC432BE for ; Thu, 2 Sep 2021 07:22:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8EFB66108B for ; Thu, 2 Sep 2021 07:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8EFB66108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2E1508D0002; Thu, 2 Sep 2021 03:22:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 290FC8D0001; Thu, 2 Sep 2021 03:22:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10B1E8D0002; Thu, 2 Sep 2021 03:22:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id F25368D0001 for ; Thu, 2 Sep 2021 03:22:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A36381828B325 for ; Thu, 2 Sep 2021 07:22:12 +0000 (UTC) X-FDA: 78541789704.20.9D8E559 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 583774002087 for ; Thu, 2 Sep 2021 07:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630567331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42sePlUoTEJ3Zl3ac3OCtw6kHqBXzy/OlkftRmelHeU=; b=c2pmT89Eny0Y6+1X9n57AaFRK7xhrfHZUjCUNZlWwXQLrGXnydHlPKhm5I5YMyQgDHOSWb TpHuLZ4defufvVCD4b4PdyrxXp76x23hKtTWu+YTeTGINVdtGDSQ491gM6SuL/oALrgfzf 8LARplUbxNVrW/nOKQehAB006gMDjFw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-33-7V62KocwPFSBvQOWlZdWvA-1; Thu, 02 Sep 2021 03:22:10 -0400 X-MC-Unique: 7V62KocwPFSBvQOWlZdWvA-1 Received: by mail-wr1-f72.google.com with SMTP id n1-20020a5d4c41000000b00159305d19baso228526wrt.11 for ; Thu, 02 Sep 2021 00:22:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=42sePlUoTEJ3Zl3ac3OCtw6kHqBXzy/OlkftRmelHeU=; b=t6X16TpC4TnrV7V2r2bOZlLceUOhSfG+MJTgcH99atzxaYi8hRfkeClfrIfHXNs4Jq f/UsbSZ0BSmHqOoRvn6cYzr0usKMnseweMC9jafTNrVQ/gXAj66v3514y1MR3p9LPvuH 3E6PWMQA3fAugq9rIDhJb7+LTvuy1GQuNsOiAJV6pol5OCZNcENzB0NuSa195LYIYQCG Is4FX5knEPx1EicCqz+uM+inPW89OvCJalGHZIGtfj2Izk8qsv+H2YinMrnV+/ONW4aG z374XszeT2DPO/sqmeVx/h3BKwhWfkCrAz+XtG+12MQOaOFMa/984fedauOerV5xSxqB GHzQ== X-Gm-Message-State: AOAM530rIdFyQIYIrr9tEu/lxtsqiSHAUP+sL8AweZrU7v4Q65ghnhm7 w/KiK7ZBFs0pSWJH0a61eL1TTMtdVFHBSY3q4T8ncAB6mRxFHSQCfYxi6rJ+W7CpFf/MG6fVa6w 2t8e5Yi+hYW4= X-Received: by 2002:a05:600c:3b0e:: with SMTP id m14mr1627014wms.118.1630567329307; Thu, 02 Sep 2021 00:22:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCnxqjp/k4WCfBgiuxEZM5XZ8ZWr+a2MUH+SGtJOZiYwAZ8KfLSEAEhro9ry2pg6UuY5YSBA== X-Received: by 2002:a05:600c:3b0e:: with SMTP id m14mr1627002wms.118.1630567329146; Thu, 02 Sep 2021 00:22:09 -0700 (PDT) Received: from [192.168.3.132] (p5b0c60bd.dip0.t-ipconnect.de. [91.12.96.189]) by smtp.gmail.com with ESMTPSA id c24sm972873wrb.57.2021.09.02.00.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 00:22:08 -0700 (PDT) Subject: Re: [PATCH 3/5] mm: Drop first_index/last_index in zap_details To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrea Arcangeli , Mike Rapoport , Jerome Glisse , Alistair Popple , Yang Shi , Andrew Morton , Miaohe Lin , "Kirill A . Shutemov" , Matthew Wilcox , Hugh Dickins References: <20210901205622.6935-1-peterx@redhat.com> <20210901205622.6935-4-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Thu, 2 Sep 2021 09:22:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901205622.6935-4-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c2pmT89E; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 583774002087 X-Stat-Signature: antug3tyoccdd1q8k53mqcgduww7t3nq X-HE-Tag: 1630567332-392675 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.21 22:56, Peter Xu wrote: > The first_index/last_index parameters in zap_details are actually only used in > unmap_mapping_range_tree(). At the meantime, this function is only called by > unmap_mapping_pages() once. Instead of passing these two variables through the > whole stack of page zapping code, remove them from zap_details and let them > simply be parameters of unmap_mapping_range_tree(), which is inlined. > > Reviewed-by: Alistair Popple > Signed-off-by: Peter Xu > --- Looks good, thanks Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb