From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AABF9C3DA4A for ; Mon, 19 Aug 2024 07:24:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41EEB6B007B; Mon, 19 Aug 2024 03:24:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CDFA6B0082; Mon, 19 Aug 2024 03:24:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26F496B0083; Mon, 19 Aug 2024 03:24:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 08D746B007B for ; Mon, 19 Aug 2024 03:24:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 89E1CA10B6 for ; Mon, 19 Aug 2024 07:24:24 +0000 (UTC) X-FDA: 82468156848.09.79C4CA2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 371631C0009 for ; Mon, 19 Aug 2024 07:24:21 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S3SEZNvh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=o9x9pfpj; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S3SEZNvh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=o9x9pfpj; spf=pass (imf20.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724052186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JjblsRBqQt9XjsCMWCyWHK13e3lgdICqrKWEtbCBKW0=; b=cof2VAvvK4uYuWzxCV+sPJciaJeYz7a4W+gKJMo/CXnYfpl+dEZCfCF9k4CN92gMut82iM fgMMqBcaQCQf/oDWEaiOGDX2M9RvbTVsdT05GcAEBbO4pHBO4964eyKE+9Jcat3C9xVysy 1JMtSs58Flu+Wd/eCuyU5CT6lAExZfs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724052186; a=rsa-sha256; cv=none; b=7RDny9h2PTpa3SEq213/DDWLCBrC8xBWruQXClg9vM8dnhEu1Q1NXMHr4kOa5ITb/meMWn ZZoKHpKDstPSvEOlfqRW0WdBR3SzQluXnI8tNcZpvd3vo8EmXPVevk3pk394Y7vZDHXYWC pA10NYjZmiMPxse3kymkTgd54Vytsq8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S3SEZNvh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=o9x9pfpj; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S3SEZNvh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=o9x9pfpj; spf=pass (imf20.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D4D71FE59; Mon, 19 Aug 2024 07:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724052260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjblsRBqQt9XjsCMWCyWHK13e3lgdICqrKWEtbCBKW0=; b=S3SEZNvhm9WB02+Yj0iwxpTwMArolRzc6wnybGvn2J+8qGiR0rfoTcvpg5Max5nb5FJfJd iO6jIN7L+PKGiqNssWaSwHmAVL1uWTjvxbCH3UQoZn1UaLE+89H0uyp5OeJxseArFFpk9c ZwZMxdcYpcFG6Sv0k53zd4KjDIOn2J0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724052260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjblsRBqQt9XjsCMWCyWHK13e3lgdICqrKWEtbCBKW0=; b=o9x9pfpjBRSjUbmYsJp+Oxan5rNjzeol4LQ03/xrnaphM7kOi9rB2OdaoTYn6QbL3GlebK PEluzKmCRGkqW/Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724052260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjblsRBqQt9XjsCMWCyWHK13e3lgdICqrKWEtbCBKW0=; b=S3SEZNvhm9WB02+Yj0iwxpTwMArolRzc6wnybGvn2J+8qGiR0rfoTcvpg5Max5nb5FJfJd iO6jIN7L+PKGiqNssWaSwHmAVL1uWTjvxbCH3UQoZn1UaLE+89H0uyp5OeJxseArFFpk9c ZwZMxdcYpcFG6Sv0k53zd4KjDIOn2J0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724052260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjblsRBqQt9XjsCMWCyWHK13e3lgdICqrKWEtbCBKW0=; b=o9x9pfpjBRSjUbmYsJp+Oxan5rNjzeol4LQ03/xrnaphM7kOi9rB2OdaoTYn6QbL3GlebK PEluzKmCRGkqW/Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 85C051397F; Mon, 19 Aug 2024 07:24:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vW8EHyPzwmZWfwAAD6G6ig (envelope-from ); Mon, 19 Aug 2024 07:24:19 +0000 Message-ID: Date: Mon, 19 Aug 2024 09:24:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 00/10] enable bs > ps in XFS Content-Language: en-US To: David Howells , "Pankaj Raghav (Samsung)" Cc: brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, Zi Yan , yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, mcgrof@kernel.org, ryan.roberts@arm.com References: <20240818165124.7jrop5sgtv5pjd3g@quentin> <20240815090849.972355-1-kernel@pankajraghav.com> <2924797.1723836663@warthog.procyon.org.uk> <3141777.1724012176@warthog.procyon.org.uk> From: Hannes Reinecke In-Reply-To: <3141777.1724012176@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 371631C0009 X-Stat-Signature: 5exuuwan4eztb3bkrn6x38ufc8d6zofm X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724052261-404883 X-HE-Meta: U2FsdGVkX19wpmKfOhfFUcQZ1lolM1XY4/XmXgV+XulNIFPgZYkHeP3pbUE1fxFO+5rNTyyGsDBESrqU6oD4l9cg02sosKEyV9OwOeebRFWXdNKH4Scan0lT/lw8qq06tH4ZtKrdkkGbWtYqWDVyK0HT3v01iarM58goUpt2XrQJWMZBri6X0ZIfuh1FtoKfrRlG+7hjjxCsmmZSEz7BZjV4J8juBlqVwjkJ/jn2VkTbavLWJ8pzJgSoe+Q3odRHrEAmf40pDwk+T1yw2lnP3Huz/N5IoNulu1y2dsUIqPi41MfWGT+4DMEkoAMFj7xOEkHUTnyyliPjkNeVFptu8Ni6IP24Uyp4omfOmrOMzfDg9779Sfv26hDfX/BXkHh04/5/lkgHUbqWbM3RkgSgGRpA1+13OkUfqgSH4lvYovxMayxY1P6pR7ZFDQ5sfBqs93UaGHC1P9Twbhd03v+6SDLJuVeeyvWiJ0BIGXUbXPycJnQB3O1eUNz3USjswyOxztOOHYxbH9/nC8QL8oFaItGsB6Hn4lMDSeYCv6e76ycxjfue+ePjTEXRH+oD450CvJ5hHOvkI0kPnuwWUITBNJcYTgLNDjjcf1Tiz6e3Lgw8NLb9hs7Sf+Wy8ABzVycwE1ImeTx9YI+02kwzH/V06Vvlo1ziQx61YBRoxPfz+n2+IKNoP3rOwmuVepN1cvlXlCkOioGLhnq4izDHbMHZfBCHHqRZMm0qtDCY19FcTIczJsyK+sYDFxyAeZapH3iFBu6hoivT56y1J9QSdhF2vaYSvYC4PUlmHHN703CIVpLjNqLD+meeo7QKHYGFAFSjRj+tzF2/NLWYJEtx9H9/va0qqTAzQKsSqdg/8SLQXw+XCFWcKIz+gxHt2yiw2K738JpsNONyZmC1GIZsdhq6S4SGTWlQmRzF8b3nvWq4DC8q5pCKfvqSYVsNhVR47CZju0Xpej1mhAFqLIqd9T1 hNyRF19R BiAZTP9JdIIIhD2ePQvbif3mtlbPicQUrahLc1ZdBKBQv5ZHRHGrCWUDasWneEHjKDtAjIFizp5IgdiCeDAjBu9h6n2xNP5TsNUkUiaA2dW5dZPZw3/s9B2AskddadB861MxinAtQeNkWeeTmO+1uHlNlk0a8pgyE2pGAJGNxBuN5F639NCVHC8GQICIa88yjn0tPQHAu+Sjb4s0BZYenIalLgw++H7MU01f1TH1ebdLSvfJLACQowDbs+kuzr/rUsl+UAvBfsX5wfuO5kL48cNs4ZqJcmqgKpLfxov+1FDtfBZy2Zb5VlHr5vsR6dqRYpQ3h/eMBsDzoCtXx6RG8PUAsKAweAeegj93q1V07aUlfkL1P4VX4lgRiFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/18/24 22:16, David Howells wrote: > Pankaj Raghav (Samsung) wrote: > >> I am no expert in network filesystems but are you sure there are no >> PAGE_SIZE assumption when manipulating folios from the page cache in >> AFS? > > Note that I've removed the knowledge of the pagecache from 9p, afs and cifs to > netfslib and intend to do the same to ceph. The client filesystems just > provide read and write ops to netfslib and netfslib uses those to do ordinary > buffered I/O, unbuffered I/O (selectable by mount option on some filesystems) > and DIO. > > That said, I'm not sure that I haven't made some PAGE_SIZE assumptions. I > don't *think* I have since netfslib is fully multipage folio capable, but I > can't guarantee it. > I guess you did: static int afs_fill_super(struct super_block *sb, struct afs_fs_context *ctx) { struct afs_super_info *as = AFS_FS_S(sb); struct inode *inode = NULL; int ret; _enter(""); /* fill in the superblock */ sb->s_blocksize = PAGE_SIZE; sb->s_blocksize_bits = PAGE_SHIFT; sb->s_maxbytes = MAX_LFS_FILESIZE; sb->s_magic = AFS_FS_MAGIC; sb->s_op = &afs_super_ops; IE you essentially nail AFS to use PAGE_SIZE. Not sure how you would tell AFS to use a different block size; maybe a mount option? And there are several other places which will need to be modified; eg afs_mntpt_set_params() is trying to read from a page which won't fly with large blocks (converted to read_full_folio()?), and, of course, the infamous AFS_DIR_BLOCKS_PER_PAGE which will overflow for large blocks. So some work is required, but everything looks doable. Maybe I can find some time until LPC. > Mostly this was just a note to you that there might be an issue with your code > - but I haven't investigated it yet and it could well be in my code. > Hmm. I'd rather fix the obvious places in afs first; just do a quick grep for 'PAGE_', that'll give you a good impression of places to look at. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich