From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E36FEB64DC for ; Thu, 20 Jul 2023 12:06:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B90F42800F6; Thu, 20 Jul 2023 08:06:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1BBD28004C; Thu, 20 Jul 2023 08:06:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 994472800F6; Thu, 20 Jul 2023 08:06:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8A63428004C for ; Thu, 20 Jul 2023 08:06:51 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4A2B0160366 for ; Thu, 20 Jul 2023 12:06:51 +0000 (UTC) X-FDA: 81031863822.05.2729E23 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 621AB1A0003 for ; Thu, 20 Jul 2023 12:06:49 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="rGN/cnm3"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689854809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VLEBEWDCKa9l4QwCUeUs8eG3yk6QwKNwCq5ozHCY6ds=; b=U6g7fFBnzrq71KwR/gzS6vYLhOLIsB5jR7BdRPT+q6JrAG833gu1hrWo+f0QPnzjGz+/7g rsw2z+fBaA7A66O00hYQc2apBonMGjaFwDcADu4O7DjQOH5qQGrx0igKRYYWPccsyAHNWd GW7LdLSd+OFE1jfOi3HFERjFc88TXD4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="rGN/cnm3"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689854809; a=rsa-sha256; cv=none; b=Ae/EszJbSQt0zaSKj87sD2mqcPdxunsk7FY/hI9vvcH2UxNHLu4PgUHcG076mCBJMIZmaw YJfUoL1Oo6GcNKPx8Lt7CtNxK6ZGWtRljH+YheNZiEb8bxumjB0n0mUd74/n8pu57AAqI5 47s8utZapbNGnHB3anP34tsYNly/OoU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11CF061A5C; Thu, 20 Jul 2023 12:06:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5A00C433C7; Thu, 20 Jul 2023 12:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689854807; bh=jPdP9GZazbPohmSBfvulF4WU7xmAHLyL6Lam/41SMK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rGN/cnm3vfJTU7YKAOi15so7isOJgRbZG+SF58jILbUTzo3YcIOEPPB8e+ZwwyJoI l06P2eV1tsjFlfgIXVdA4KSxgeyF2lN/ZT5F3ZS4Ce5yvgkMFptj6UIGbZPNSKLttd uhpm61nWtJ09mRflHOhvZsxLEbLgyrbrfzTHxS/15fsE9BsyKABdispuWJSSVWMrpF gOwL/1yzEZUhLIGFWPypadEVBxYGTOpb8H4jUFfRBVj76r6YY5FWgyW0H2L/jxieyw V6AfO5cGMBovSMtBWHalk9atTmh5p5EOy8GOfOc3/3OdatSAP+HHLqe9YTpPeRS5T3 LgfTolpHI8sOg== Date: Thu, 20 Jul 2023 13:06:36 +0100 From: Mark Brown To: Will Deacon Cc: Hugh Dickins , Lorenzo Stoakes , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@leemhuis.info, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Message-ID: References: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> <901ae88d-ad0c-4e9d-b199-f1566cc62a00@lucifer.local> <977ddee4-35f0-fcd1-2fd-1c3057e7ea2a@google.com> <591b5253-47f0-440c-84b6-7786ff59667d@sirena.org.uk> <20230720103227.GB11034@willie-the-truck> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bb9JqOrF/z0TC5UB" Content-Disposition: inline In-Reply-To: <20230720103227.GB11034@willie-the-truck> X-Cookie: Ginger snap. X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 621AB1A0003 X-Stat-Signature: bgq5czdjw7fydct6sxwizj6ec8dkhhp6 X-HE-Tag: 1689854809-93369 X-HE-Meta: U2FsdGVkX1/m1Zq/t+AQ0zeew5ZykIveKl3qv/rVLdXGRwmykEZLA2givPY/+4J2FBe9rmtQ6lJDH/HqiK37viSoK4RsKsmMCAa8U/bc2Caw46xeyT49srMSxBMQuo7dDH5cq5aIcU0LVCcm0Hyf246ioEmW0erX372yx61uR5RTJNflftGMhihPrbvGzhCrp2ynRbCJz8r9vi/u06M0I1EBPYh1hY9FYA04UpljyYv3BGR1sFWismrpWX4zdls3WZanPUeJ63fLWMLFlMysAuw+wTz81S3j1UFxY6UrPU5BjSTbxPmWqCU5uqWBAE+tuDlW/I4dJUHoIqyBweBJYuPFa2kcRbbiH2D8cWi9fw0WKZBJ5jDw2fuEnlvJ9TSieKpqDMOtvcDlODqTataMerslQ9tFjYSpqaSI6PRpjMaaUOTqjzcLPoDc9dDIQM3mJw2+POP4AwSDGCRSpEvpHz7y/4jQDyp5xpRAZoHEUUFsqHUMP31BeFPE4Fro6mpAV0hcX4PoPH9bOOHkMmnuuf8WEVsnhYqVXMfXaDhdvy3Q8paN78Vbci406hPPApfmdSaeydwY9F9wmxyZ4nFFdnJBuavfLkF5BgYHXADCjiK26f/VHz/BuETrPdsxElepcP9vXoPAjl4JxfN+s7iJk7T/Utt9kiXhTPKdWEa3oG9rzCfFzEO0Zgl6rIaMHc84EfsdAiyTqzTGzAYmzg+eMXZ0OICq/lqqRt9p5rUo8UyLtfTJuopx2W0WI5eQl6eUzW4QmSQBVEMzVrRKNPrabGjJuT65meSxzEDg3S/p6oVefeRqIWCSnZuwPhZG4ExyXwHiOxH5i3pB+CwC9FlolmTz+Hxw1pWT6cm2ESkuayUBow7aSFyY2/VAOIwPxXLDpHJh9CLQpJazNRCR1cH/W9KNc5t2+lCON5Ieza9yrHRgB50Nk9NhCMVd3rxAZRPI3klvJjMop8CFxhCMZBN h6GPvEZD k5y6KV1wyN7d0BH2CLtXj9G9qgjcH3UxA7vOZgv/2jv/pxO60WBXeVtFPIddGkyK4x52YrKvvpzs5WrILUGKjRHgmwc9rbMlMWhwxvWhKia4aha5WCuh5PRR6XQCsAA9/7Imu6KNPS2jLlZagRQc7FFQbjzNj2Su4Q5+DLhBYsij3EE3EpMBKyFFpSoPzZDqrrhJOW56igQ7yJtj0EbqhouZWTIuIzXHu4dXnXiuIKNYtfAidqd6YkjVvWEgzdged6oc9JME96Uc0Yn+0fv9KH6vuXA4BSZuqzQ/69lCuVhaFZVk/Nqv3XSdWRLUiw5O8S+KrJOVnwm/wg2YbZFaN6tVZxkQQ7KIHxLW760p20uCz2drjxbGoKhac1ZPYLrs2Wsqu/rBzzq2bi6s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Bb9JqOrF/z0TC5UB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 20, 2023 at 11:32:28AM +0100, Will Deacon wrote: > On Tue, Jul 11, 2023 at 06:57:33PM +0100, Mark Brown wrote: > > Still investigating but I'm pretty convinced this is nothing to do with > > your commit/series and is just common or garden memory corruption that > > just happens to get tickled by your changes. Sorry for the noise. > Did you get to the bottom of this? If not, do you have a reliable way to > reproduce the problem? I don't like the sound of memory corruption :( Not to the bottom of it, but getting there - I isolated the issue to something in the unregistration path for thermal zones but didn't manage to figure out exactly what. There was some indication it might be a use after free but I'm not convinced. I have a reliable way to reproduce this if you have a pine64plus, it also shows up a lot on the Libretech Tritium but not quite so reliably as pine64plus since Hugh's changes. Equally pine64plus was rock solid until those so there's some timing/environment thing going on which makes the issue manifest obviously, I expect you should be able to trigger the issue by unregistering a thermal driver but the effects might not be visible. There is a change on the list to make the Allwinner SoCs not trigger the issue during boot (their thermal driver refuses to register if any one zone fails but most of their SoCs have multiple thermal zones with only one fully described) but it needs fixing either way. --Bb9JqOrF/z0TC5UB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS5I0sACgkQJNaLcl1U h9CXgwf8Dw3YMYw4WOhw/YJtPAAANuKw+Zy86uChY4Ts5qPQSbVSwU3C+HSO1kz6 rsyG3dwIfPq1Zj93/9VIw6rWvIaAFRT8ahat1yP5iBmmphKSzCmDMmBiy3JV26v1 GbIX/dm/qVRmC6MzN/iom/XVWSc7nByWSBxjmuEUe535oSeScoVgo3REv/NDQalm JVTJ3R5/C0ZTiUzrlUPs/DNFGNVbJIEzDd2KxMQ82GzSDK4G+wVUEpfd9rWkFEC/ HAttaNYB/xgrYzkdgE94p7wQuXo1Ni7ggL3/2zVwr1IZEPr6IyoKipgGkGeJF5bX 4wMSGLbOh0p/lU1O3vFdo6mnxFeYUA== =jXeg -----END PGP SIGNATURE----- --Bb9JqOrF/z0TC5UB--