From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3C6C02198 for ; Wed, 12 Feb 2025 05:25:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 554616B0085; Wed, 12 Feb 2025 00:25:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DD846B0088; Wed, 12 Feb 2025 00:25:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A6E26B0089; Wed, 12 Feb 2025 00:25:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1BD616B0085 for ; Wed, 12 Feb 2025 00:25:26 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 938D81C8427 for ; Wed, 12 Feb 2025 05:25:25 +0000 (UTC) X-FDA: 83110154610.13.40CF147 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 93E1640002 for ; Wed, 12 Feb 2025 05:25:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739337924; a=rsa-sha256; cv=none; b=wIZgIbpxgYrY8yh8toQzUSqFc3bOwBPuV4rLcEGlUJSbHATBUBnETVQnoSqgGqIplzxqFW pvUuLRNSN8hI8Jg6/uGvnIpqF+2RDYwbGu3AJ4hMkty89zzVgAA7/bQo7vR0uFedRzoeKV Z5Fqn480fE5FtqnNYAAVeONGlTVxxx4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739337924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GX0UnksCxrwdqAGQgY7Kpt9QVglnvocKwN8XV+ErCoE=; b=6W+Fsx6P67pg+sbxqxfmeaUOh0rOgbj7PNGNttBi9Vz1YXosaTb5mUdTG0+Te5eg3n9iCi 3gKWGNSWnLTIZs9LbzBQ3EGGTEUmRbbhj3qL3h3Ltvoaej1u1hvjzgsTq5GNTRkqPue2DD 4lMjMykOota1RBu8Wvx/w23/uSMJJ4I= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D5EEF13D5; Tue, 11 Feb 2025 21:25:43 -0800 (PST) Received: from [10.162.43.26] (K4MQJ0H1H2.blr.arm.com [10.162.43.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 914C03F58B; Tue, 11 Feb 2025 21:25:20 -0800 (PST) Message-ID: Date: Wed, 12 Feb 2025 10:55:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/folio_queue: Delete __folio_order and use folio_order directly To: Liu Ye , brauner@kernel.org, dhowells@redhat.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250212025843.80283-1-liuye@kylinos.cn> <20250212025843.80283-2-liuye@kylinos.cn> Content-Language: en-US From: Dev Jain In-Reply-To: <20250212025843.80283-2-liuye@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 93E1640002 X-Stat-Signature: nptd3stcoqrexz6rhfqyixoii89ruhdb X-Rspam-User: X-HE-Tag: 1739337923-278006 X-HE-Meta: U2FsdGVkX1/zre+suhKBd4pDqpndmffZOz3w2fGm6ogk+nV+ovfF/amPakbyd7TeG0ruh8q+p6s+CtQRR/JVNuxueRR4N21mI9/A4+GAs3JvBowZPLGKPAdxFKRuwk2xpzQW25YTJTHFdSWvj3uRPMtej3ZQ8ShAmrsrCoHQ0W6Vloknrv3YncSROttKv9RRtrijXMR+B1JkrqjpawXnkI9xUS9YJpW/EcD/3fF58vD5U/cU+9TQXt14j21g22E+CzRMnqXIS5xmaB1U4Uizc6tBPDaK1nY2SPBUkOh5nTROilPCyg/omYWx0s2b/Ut/gfElfCdnIie8A3eBWHyEPyhT5K8NdUybLG4oJTnpIkiTdZQ4lgD6GQLSCP6K/SEcoqpWmaeOt5frkPwqwNhm2mUfnJ6AZ1/1gJEwcNOZNzz6tv9fnp3De7gIHrUxnW02WzuwZ8DNbXG0XZNoNzrP2OIPfaq+VYTv4qaRJJF1b1eYGQfOIsKmVIL3xyMs4soLTX1uRn5gqyuYR2JnK4LhyaWLEEXbBjvOvBzfYrXWB3ML+WbUC8PoWk7Xzv6RL87OtQo692Lg6USINJSaWhc9paJ36LS0YQuFbDg2wo5xs9nLnj9E8R+vQCM47w9zWMKM0ZsTk5qMb+uwMKekknlvjYtF8//S5htsYj+LlNh9TQ373uWt5yihzT0pf7GEG4RHgTUolon4zmVXsutrywiPSL6obORR0eSuGF8GOR83sX63Fk0q1xlPDUNrTT1a9LfdDLbsgkVNf3Md3U86mB4igGRFP0IyML9wNsEFfm2zzXxbsWvKhmAeb9VMA0YJMQaCK26uYyKJIvmu3Q7OGr7c4+eiMcOo5PeU1zEFj2M1ITPyqJZnEPYGe2o0oxtSc6igsoswVckGQYN5pXbiyEBewP+3heILMywgG8jKNbLRLE09aNdvnc7ELK2Zr2ef4FJT3xExfo9mofU6a4PwUuc xMeVwzCy 6D/QKJ1Qq2JNSh9sUYVWCEUztfWgKz0B6lSH5HtAA6wGr7Y9kxgSCYU8Ssw7IGhueUBY02ExWs2HUGvR1sRO5QruQepu5kDxGYeOGu/CZjDjjzG9NJOPPmB1les8HZmmQNJEHhrBppvNB1AMsClPS0QGRt36hDiwNP8ncTvdgcAFyxV73wKeid0VXxVg87Hie+2DSyUmuzQDg3/drRp88On6i+dMcYjM8laxnDRa3ktkekYT7g0rwpLFv6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/02/25 8:28 am, Liu Ye wrote: > __folio_order is the same as folio_order, remove __folio_order and then > just include mm.h and use folio_order directly. > > Signed-off-by: Liu Ye > --- > include/linux/folio_queue.h | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/include/linux/folio_queue.h b/include/linux/folio_queue.h > index 4d3f8074c137..45ad2408a80c 100644 > --- a/include/linux/folio_queue.h > +++ b/include/linux/folio_queue.h > @@ -15,6 +15,7 @@ > #define _LINUX_FOLIO_QUEUE_H > > #include > +#include > > /* > * Segment in a queue of running buffers. Each segment can hold a number of > @@ -216,13 +217,6 @@ static inline void folioq_unmark3(struct folio_queue *folioq, unsigned int slot) > clear_bit(slot, &folioq->marks3); > } > > -static inline unsigned int __folio_order(struct folio *folio) > -{ > - if (!folio_test_large(folio)) > - return 0; > - return folio->_flags_1 & 0xff; > -} > - > /** > * folioq_append: Add a folio to a folio queue segment > * @folioq: The segment to add to > @@ -241,7 +235,7 @@ static inline unsigned int folioq_append(struct folio_queue *folioq, struct foli > unsigned int slot = folioq->vec.nr++; > > folioq->vec.folios[slot] = folio; > - folioq->orders[slot] = __folio_order(folio); > + folioq->orders[slot] = folio_order(folio); > return slot; > } > > @@ -263,7 +257,7 @@ static inline unsigned int folioq_append_mark(struct folio_queue *folioq, struct > unsigned int slot = folioq->vec.nr++; > > folioq->vec.folios[slot] = folio; > - folioq->orders[slot] = __folio_order(folio); > + folioq->orders[slot] = folio_order(folio); > folioq_mark(folioq, slot); > return slot; > } This looks like a reasonable change to make, since it avoids code duplication. Please consider: Reviewed-by: Dev Jain