From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF27CE7A9F for ; Thu, 5 Sep 2024 21:40:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 459AD6B0088; Thu, 5 Sep 2024 17:40:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4095C6B0089; Thu, 5 Sep 2024 17:40:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D10C6B008C; Thu, 5 Sep 2024 17:40:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0F1E56B0088 for ; Thu, 5 Sep 2024 17:40:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B166712014F for ; Thu, 5 Sep 2024 21:40:50 +0000 (UTC) X-FDA: 82532004660.26.9F1524C Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf16.hostedemail.com (Postfix) with ESMTP id 90734180019 for ; Thu, 5 Sep 2024 21:40:48 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TpAW40y5; dmarc=none; spf=pass (imf16.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725572376; a=rsa-sha256; cv=none; b=DV9TEdW534plWWUQghMXxEWjtXrkGsxEsuaM/gAygrJv8gVLT4FJBKZwqv0M/rHiWFRFj5 IRP05LhrdntIK9vVvTzA1+nwUX0Bi4jqXmt8aNevvTahBC9a0nBzHBhMAfi8E5dNJzk4Gm eYF52YWKYqEOewgnE7eCRP0Ervb+qjs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TpAW40y5; dmarc=none; spf=pass (imf16.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725572376; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bbtyiYEcSAgf2UeSJrd7kG/9VEfvzqOigpjQ9MBNIFg=; b=1VEBZhQ8hF7d6+eybzHiC2lr/JKiwLL3VLoLgoL0pRJdGSjavLIWjo8nzyqtuxfAW5+q1O yLgK70U3+97oCSkIYjM/INU296bUc5GVgmnWt9jykEsNvAFRamnzf6LziEnrw5Z4jr0SHQ sowvZUI4MdlWY9a4wLH5Pb7xu4QmGcY= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-715abede256so1107717b3a.3 for ; Thu, 05 Sep 2024 14:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725572447; x=1726177247; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=bbtyiYEcSAgf2UeSJrd7kG/9VEfvzqOigpjQ9MBNIFg=; b=TpAW40y57ro1TM3+JCl3q8PHBL4EiWMBfvyFl9elfUckf9wMWw+8hA+UbteLZPxvVN vD7mhDRPh6GjMQgl+6hox0XoGwyTuKSHGmCYIfe5GcB2SdxqN8cBRcBO+iK490F3kTqY cwgV7tICQ8J9Iegz8pFGcj3J32lJGSkc8p+1jJHwKBrS9JJ/BKkZqHLoGJdCcBqtl1FP vKpVBCaJzG127lIs8cNld3x4EzGP8Qe7KDy8MNTpQrKD9cd0Gm9T3LRqfHShikAk6Xis ipYmRcAv0HHVFTFlugtoYnettkVhJNmStPbhpiYHf0WI7BOib9KPpA5btU06OPqtxsZ3 dJGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725572447; x=1726177247; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bbtyiYEcSAgf2UeSJrd7kG/9VEfvzqOigpjQ9MBNIFg=; b=qdTLjPVFJBwdJL+1So5GJxKC9JdnZ1QO0Ewj7APDeRZjVHyPSxkl5RSlqT5QXDhyDZ 6njuRENY3cI+FXC1lanbBv2OAzNrXj8PEkjaCuGGCrFib/n7epVbNP6wLccS2LRXPs0J 7MHKKi3O2TbjZxHE3aOo+VmbRRefYdTcx2xKWlOwRBpmKT1sS4nEZJBkgKetVz31cQ6h rQB26rpGuG0GB7LY5BuTA+Z5ngm6BWiJRtv5emp+sCNBTj+ud680pI0IZIh7ePBmtqUc Ex370OdH9VKHfi9IUoBNcjnVw2mgwemHlgJdNlf/VPx5kjK1radUFjkcwxzoeCRLC+Mm xQBw== X-Forwarded-Encrypted: i=1; AJvYcCVZK00f3jVH6uwOcktyvDiWiSxtyD4PqCAxpkwtJfzJkWYIdY6Xb2Vu8FYR/5mL6diat+YB0JejlQ==@kvack.org X-Gm-Message-State: AOJu0Yz2kXX9kdLm7tI28tybcHLpQfEGn5MYeZcb+A+LstinCOYtDwTY kzbfcrrcgIKfWT/qM1tVDaAGN0dxkSGOvVVOCkDY933JrgZ6W7mi X-Google-Smtp-Source: AGHT+IGPu0hlK1VagwZi4ioeZ2DG9siu64z/3zMRPrUFDlWNp2kAJwHbc/L9AuB07MIczt0C4UqCvA== X-Received: by 2002:a05:6a21:513:b0:1cc:e659:8008 with SMTP id adf61e73a8af0-1cf1d12f6b3mr355029637.26.1725572447055; Thu, 05 Sep 2024 14:40:47 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7178d8e0b01sm1647955b3a.6.2024.09.05.14.40.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 14:40:46 -0700 (PDT) Message-ID: Date: Thu, 5 Sep 2024 14:40:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/damon/core: avoid overflow in damon_feed_loop_next_input() To: SeongJae Park Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240905172405.46995-1-sj@kernel.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20240905172405.46995-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 90734180019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xykqxeyrayj6i4i6ajh45kw1afs433qj X-HE-Tag: 1725572448-749348 X-HE-Meta: U2FsdGVkX191goWZt57QLNwbQtG27k6HQ9xgh96V6TGOOghTjLa99xCh9o1c9/C5lxQoBrrAa/tlBQpvb3mX18NIfdijgZ1cCbMzRgR5pyVviYBHb+sNXSiUplcw8ySaMbGygINQjiFMuCglBnZIUlXMlQH/YvokljnQg/pi+DhwtaZ7PSvMoiJoZalGh9JlU2dgMi3J08Jf5b720QLnLR4JbZyOZl9RXxyEOLhSh0YNWZNsxWNLZQjQnNyGifKq3MGgBWI9wfN5TToB8rQYcdNhUUOpofOvRxv0fL8HeNgjUePlugCE77/yO/wYUQHATxg+BcPmP8swEBntJE2MPTMkaGZQ+RJNuDitt1VecSIwJsWz2LnCum/HhklLHgI2bU+hP+afK9YRjKUdtvJQWG91qHJFSPJb2dppKjntsacThNBxgNWYuhhkOpXC3FBHPL7rkn3mauGzP1VvhEEap7TUsr3uWmRZisDtajdGoQLz+OEAr9xgCZEMkihybzupGpGm1awlZbjtSpcnnGPGMalqiBdho8CzSjm83u5mjXEUtHexszruenZphY2oGY60H1wVljAdmX9WmKSgWtmWSGYCFQuKrfghN1gUusi6iFkUhF6jEZiW6oEd97d1P9fldyix24UFQD7ng3izoiofBpGo9WiDUkDBB5SjZj40MC4eaYXW8yXfwRi5anLZl1zzIPyRyxDzeS+HSPNokO5A5bHm5iTLX1UF4xxCApd7rqKtsM5nnlXxr3nZ5oRChh8maPe4AgE0baRsH46G/Tk4RbflFr0/HiF50Sn4277KXwiok1sAM246DzvBJQHVSjQ5fb7/Y1rMwHw2Jp9e6037XB6RkAhEfNTpbgjqXwEpZ7S8AewYvwInkSZbvnM1eYn1MVu6UQTE52O+yH9+NuG97y8v1KD43sHyKbShh/ZJM5rs3Nq0hhIzflua9E91NvYVw8KiD/2FWngB5OMjDCM M1QDImem YDdU1QTleN35gVHlDnW4/HUZfNXJcifi7ND9t3jANqrrECKP98U5nn/2QkCiwItq3Hc5qnCdNO2PTyASdYxxkA5suuclht54UgEULwCnEADOBm8jk+mJ9TV+ktQsAzX2MY/Yb/CPL35rU/DHPsThCrEbnP6gsQPiEpYDgOz0yvbYl7XUCrrFvP3NSM5TIw0Q0VNPllUNaXzgIT2zKw1wuLWksuFEVuOqR4b0mpGVy0D+06pcwHqbtu5ThjeshDXvcv63GXu3zwKHbF0yeOP74hMC/9JjJRt5xBATeqjusPl3qFKZYpSe4otwPqPJpjQi5aL6YtJCfEqiGx0xyUuZGL9AuVon3keLcsUBJ0uzGlv/vHkG9aAHKTd5lDvC80JunRPqSQ36FRWzZQ6gepNrKAnGaLbkZ2LHGliiYHWmCWmkfN0pJ2BdBX94qU4NLEchepubV4YQuVXtPu5c4bi5U143mIU3EHR/TnqY+ac9wQTM4D4xOaLYfOKqyOoaVuZNJLgeFmoXGuJNVVuV6qCuWN/d/m/ZoE0O+wZnEucgMrLvj2vq7Po4BZmWYPsJIpt2lPerVJ2WZFq3xqEGFL62nsdNLvtIAmxNdLma/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/5/24 10:24, SeongJae Park wrote: > damon_feed_loop_next_input() is fragile to overflows. Rewrite code to > avoid overflows. This is not yet well tested on 32bit archs. > > Reported-by: Guenter Roeck > Closes: https://lore.kernel.org/944f3d5b-9177-48e7-8ec9-7f1331a3fea3@roeck-us.net > Fixes: 9294a037c015 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") > Signed-off-by: SeongJae Park Passes all my testing except for Failed unit tests: arm:mps2-an385:damon_test_ops_registration arm:mps2-an385:damon xtensa:de212:damon_test_ops_registration xtensa:de212:damon which unrelated and not surprising since those are nommu systems. Tested-by: Guenter Roeck Thanks, Guenter > --- > As mentioned on the commit message, this is not yet sufficiently tested > on 32bit machines. That's why this is RFC. > > mm/damon/core.c | 33 +++++++++++++++++++++++++++------ > 1 file changed, 27 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 32677f13f437..1d951c2a1d85 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1494,15 +1494,36 @@ static unsigned long damon_feed_loop_next_input(unsigned long last_input, > unsigned long score) > { > const unsigned long goal = 10000; > - unsigned long score_goal_diff = max(goal, score) - min(goal, score); > - unsigned long score_goal_diff_bp = score_goal_diff * 10000 / goal; > - unsigned long compensation = last_input * score_goal_diff_bp / 10000; > /* Set minimum input as 10000 to avoid compensation be zero */ > const unsigned long min_input = 10000; > + unsigned long score_goal_diff; > + unsigned long compensation; > + > + if (score == goal) > + return last_input; > + > + /* last_input, score <= ULONG_MAX */ > + if (score < goal) { > + score_goal_diff = goal - score; > + } else { > + /* if score_goal_diff > goal, will return min_input anyway */ > + score_goal_diff = min(score - goal, goal); > + } > + > + if (last_input < ULONG_MAX / score_goal_diff) > + compensation = last_input * score_goal_diff / goal; > + else > + compensation = last_input / goal * score_goal_diff; > + > + /* compensation <= last_input <= ULONG_MAX */ > + > + if (goal > score) { > + if (last_input < ULONG_MAX - compensation) > + return last_input + compensation; > + return ULONG_MAX; > + } > > - if (goal > score) > - return last_input + compensation; > - if (last_input > compensation + min_input) > + if (last_input - compensation > min_input) > return last_input - compensation; > return min_input; > }