From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD5FC27C53 for ; Wed, 12 Jun 2024 09:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EAD26B0098; Wed, 12 Jun 2024 05:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19B336B009A; Wed, 12 Jun 2024 05:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0891A6B009B; Wed, 12 Jun 2024 05:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF25C6B0098 for ; Wed, 12 Jun 2024 05:28:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 814EE1A15FF for ; Wed, 12 Jun 2024 09:28:33 +0000 (UTC) X-FDA: 82221711306.25.22DE0CD Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf29.hostedemail.com (Postfix) with ESMTP id 1F5D0120011 for ; Wed, 12 Jun 2024 09:28:29 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NPMKrb+j; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718184511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EHjZSLjaXmqO3nCJmphf3wWKY9Z7DZNq9QkKmioWbMo=; b=t7/o9Vkt5Cwyz/BQ+jXK+XXZ12REPNVJmDs2g8Awwuq/mMVlXGAXhcmtmsFITuNKx/Eo34 7OCNqe1svbpNguq3qqDjSyU9xrOaNVnGb7XRjVTRGjmHjI2z7fcHpI29ufF7Cv7w1vq+Zf 9MDRx0R/h8SFnmeYKfIYi1ysqBT1bhw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NPMKrb+j; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718184511; a=rsa-sha256; cv=none; b=WI5YWet1SutJxGgFJlqgVuYo2xZCstDDFeowatoQKWdHs5RrdfHzsDq9DpSQsr4UDjT5ml KhJM16roqYun/1v0rTaZ4M9SPe3HBqS+MHPj/ODPqVI7rjSbO5BDzhgQeEcr3qSyWz9Qxw GNwEwLW0an+D+kOHU90k/09LadeNab4= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718184506; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=EHjZSLjaXmqO3nCJmphf3wWKY9Z7DZNq9QkKmioWbMo=; b=NPMKrb+j3wGvIGGSw4tgv8cEo23eoTVt4ueWnICgmNWFRX3dCkqOZ4DAwzbT0ScxfsTOuV4xRnk+g+ZU06Y/qutJ25Xx8qvzD4bW8m6sVECyv17Bkwr2Vg2XDetMEWrVAKuNYEqpTpPQnM6KnzzTooJBRVFyTule6XwGSwMfVUg= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033068173054;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0W8KLpTV_1718184502; Received: from 30.97.56.60(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8KLpTV_1718184502) by smtp.aliyun-inc.com; Wed, 12 Jun 2024 17:28:23 +0800 Message-ID: Date: Wed, 12 Jun 2024 17:28:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/6] mm: shmem: add mTHP counters for anonymous shmem To: Lance Yang Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <4fd9e467d49ae4a747e428bcd821c7d13125ae67.1718090413.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1F5D0120011 X-Stat-Signature: 99zy1aaxsrmsrhn8eeui3gku5rdx9rog X-HE-Tag: 1718184509-146648 X-HE-Meta: U2FsdGVkX19ji2CE7ARfJ0nVCv18j0/nf2uUO/4phRT81GgmVl9U/OeTEFSJfC6IoECH/5MSOxodE2dOvctv/PgpXXXfScTOUndYUwyDq+aEuwruEV7693I3M4RKLaNEvQYL0YIfNi/G0aLzb4/pLk6+H9gXG8DgIsnC83VZIWaGsNYTAWdLte05g5M65RgO1HaAT79PaHcs2rlh6CorbOhdk36zEUR+Zc0NJ9SiBrIkl1sWYkENewficT3hvEGn4JVoMnAQfIwong/IHTyJXo2cIA/wmmzOZdHc9zVbdDAwSxB2vgqKyqgi1n/owaAYHRdIBhw9N60Ct3nIVpYHZYuuduZOHOmbJGzF9JZeqiLpjTxuoRqCuqpvRyFNejXqaLXG87HHMbGUAlw7fEGDsqEwSonqkPLeGgU2CTKZ5V24i6gCGH4PniFaPrbVNS3N0xZzpwDbaVROAynGNN4xWzC2P9FTRPOPk5JKWDhsvB8Pn05/QD0ieH5P1sNaNK5awWnsRQFnSmyDnFKCnmGgd5pSb2ndt2u7esLYnWRU2ehiYvq+yfPSgeiPFS7LImp7wMZcWKEOvweqCJlQXt37EwV5ZIYLaZoR8Y9Lb4Xa/56t7KTzsL3PbKijkEVhvJSgKRbl7UYsnSlvEDCLPw1TkEtqbiDMT77mhHDbXcbIAyoQZLjolLkbmqpuiGCEGRcL80TjsPf3Ilm0tt48Iz10oi4+AqKqv9lc2T88dCRXIU1qB50LpdzhY6BDMMmFGVZukW2D2huenflslx85yqfPY94veFyDs/22+5hKn3Ij90Nzxir7bIGbHwmBx7M4v0NhNCtkxk4eDri01WkmQuXoyZ0tKcADVFEkHFuRTvXTJeQAzQFnu/zjvwkVIdNZW9IuYMYo/Fr7Q0MJAXrixV0ar645gXiQ/gyAJ8jn53xKpBRGz4h7HI3dL6MMsvgcQDdqQfsuiGBW2HP0kZ76pMU 0h+wiP2r EgoMrldx7HPUZh+9frmLwNMZp+JvZ7lE0KofY0lsCbx555AUCG5QghKhSNmeZt2MM4b2kDmcinhB+UHLjDHdvhwY2t8UhLEIZ2xIyA9o9gQQgRid270cqMQFR0nh2PuGy/mZo+HZbKKzvAPe0xPz1BR+searCt1EPqN4LuIjGqt+mMpAieJ7BbQeHkP/DroKLfIB9sikN6gXO3ZnpTGwZWXkHIsXNlhxm8QFUfC4Etyj5ydUcHkOp2xxzBuQ/VMYMXten/Jf9CvEpdr3qT20/het8RNhsz15esXQn0J8P9pVGar+WRIvzB9runSCRUIEHJvDVjsvyspS9q8UBwK0IMWauM2WbFhSCH/B6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/12 16:04, Lance Yang wrote: > Hi Baolin, > > On Tue, Jun 11, 2024 at 6:11 PM Baolin Wang > wrote: >> >> Add mTHP counters for anonymous shmem. >> >> Signed-off-by: Baolin Wang >> --- >> include/linux/huge_mm.h | 3 +++ >> mm/huge_memory.c | 6 ++++++ >> mm/shmem.c | 18 +++++++++++++++--- >> 3 files changed, 24 insertions(+), 3 deletions(-) >> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 909cfc67521d..212cca384d7e 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -281,6 +281,9 @@ enum mthp_stat_item { >> MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE, >> MTHP_STAT_SWPOUT, >> MTHP_STAT_SWPOUT_FALLBACK, >> + MTHP_STAT_FILE_ALLOC, >> + MTHP_STAT_FILE_FALLBACK, >> + MTHP_STAT_FILE_FALLBACK_CHARGE, >> __MTHP_STAT_COUNT >> }; >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 1360a1903b66..3fbcd77f5957 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -555,6 +555,9 @@ DEFINE_MTHP_STAT_ATTR(anon_fault_fallback, MTHP_STAT_ANON_FAULT_FALLBACK); >> DEFINE_MTHP_STAT_ATTR(anon_fault_fallback_charge, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); >> DEFINE_MTHP_STAT_ATTR(swpout, MTHP_STAT_SWPOUT); >> DEFINE_MTHP_STAT_ATTR(swpout_fallback, MTHP_STAT_SWPOUT_FALLBACK); >> +DEFINE_MTHP_STAT_ATTR(file_alloc, MTHP_STAT_FILE_ALLOC); >> +DEFINE_MTHP_STAT_ATTR(file_fallback, MTHP_STAT_FILE_FALLBACK); >> +DEFINE_MTHP_STAT_ATTR(file_fallback_charge, MTHP_STAT_FILE_FALLBACK_CHARGE); >> >> static struct attribute *stats_attrs[] = { >> &anon_fault_alloc_attr.attr, >> @@ -562,6 +565,9 @@ static struct attribute *stats_attrs[] = { >> &anon_fault_fallback_charge_attr.attr, >> &swpout_attr.attr, >> &swpout_fallback_attr.attr, >> + &file_alloc_attr.attr, >> + &file_fallback_attr.attr, >> + &file_fallback_charge_attr.attr, >> NULL, >> }; >> >> diff --git a/mm/shmem.c b/mm/shmem.c >> index f5469c357be6..99bd3c34f0fb 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -1773,6 +1773,9 @@ static struct folio *shmem_alloc_and_add_folio(struct vm_fault *vmf, >> >> if (pages == HPAGE_PMD_NR) >> count_vm_event(THP_FILE_FALLBACK); >> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE >> + count_mthp_stat(order, MTHP_STAT_FILE_FALLBACK); >> +#endif > > Using the conditional compilation directives here is a bit weird :) > Would there be any issues if we were to drop them? Will cause building errors if CONFIG_TRANSPARENT_HUGEPAGE is not enabled. > > Since THP_FILE_FALLBACK is working as expected, MTHP_STAT_FILE_FALLBACK > should work as well without the conditional compilation directives, IIUC. No, you should take a look at how count_mthp_stat() is defined :)