From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A89D9C001E0 for ; Thu, 27 Jul 2023 09:17:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 423846B0072; Thu, 27 Jul 2023 05:17:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D1C86B0074; Thu, 27 Jul 2023 05:17:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299CA6B0075; Thu, 27 Jul 2023 05:17:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1C09B6B0072 for ; Thu, 27 Jul 2023 05:17:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DCFB51A0D93 for ; Thu, 27 Jul 2023 09:17:53 +0000 (UTC) X-FDA: 81056839626.07.8513F10 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf13.hostedemail.com (Postfix) with ESMTP id 1BD8420028 for ; Thu, 27 Jul 2023 09:17:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GMz7Ro63; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690449471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zDAeke9dPI5F1DLlt143+V+9EjjOTI/Ym3kFZW9NJks=; b=xNg4JznctTsyXES9I1nzomLIHF0eHUSmIWXwsMe2SC3IvFawbv2FTAwDGoH+yx1FTZsLoW skND4KZ4ew/F/JUyKmPauW9e23V3oaUszU7czvU2BJwQrfq+EW8BklLnPr0hxB0bYKJJu3 zLTlkgQ86lSKjS4eU+rsC3oCKj9Zm2U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GMz7Ro63; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690449471; a=rsa-sha256; cv=none; b=z4qmP2uA7HuQfMSonifHw+z40TEJEWOzD2uq1aixoHdrWIIuV0pwz50R3+RiRvlh3MLUhd LE4Uj5trtFlRiza5A2Gz2ej5bgguExyYdyniL286Tb685PyYr+enwTfd0gHIdok9Yy8Fyn l4oEj3A4rQ1dBFwOidpuowZlS4KzAAM= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1bba9539a23so925015ad.1 for ; Thu, 27 Jul 2023 02:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690449470; x=1691054270; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zDAeke9dPI5F1DLlt143+V+9EjjOTI/Ym3kFZW9NJks=; b=GMz7Ro63z/YezVqKkIH1jrxAzOT75QcUy09pRQPD7AgfWuYvUeuW5VEqNC1XIv9vFN mRwt8c6aGV8kgK9lP5FEKupjXOG/bSxCUR1Wt+sQMg8uYMaVdTfESuVXyke/16/L/yN6 lgXVNg46bwMvdgDL/au4WPig1MVEHeG5wVY0ujpNjiLSHIkveiLIrECL7sZMPk2KN/og cOXK7BC9rcgfo0JQrpwRHwvNtz6wdTJySW4bqDUFHi4zdm4Oj9K7/OLBxIv3WQBH67f1 OvlGd9tRajLpgSW70SF8ktMkDj4Bt1BHUDLO+7r2qg+4O9VtPvpOqNWx1A6uYkZBjzBr UEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690449470; x=1691054270; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zDAeke9dPI5F1DLlt143+V+9EjjOTI/Ym3kFZW9NJks=; b=UBm7cq1pexFhmNsT8GOMfCWA/il2IcblHG+5dCwv8kl0VeoWLLQcdHzqg4qY/82pVA 4ptWuvl5Z70t0WkOuSFU6pBYD1Iqi/NIxU87JPrUgv0XDN2bizGFR6YUpfN8fb/icdFp 9Dbxfbse/FH60quSqMbAIh/47HbdT19p56sdPaGWydcGZPvZvgNhQLzeYQqE3vPDp68Y WPAju/awvM3BBbT+Auo99/scTWTf73uWYSXl9YJTOsFAq1MzcCCtXrq9QdgClJyrV0ry /uy0/ZsikOlKcgryf4p1H0UuXhQgErn+GCe7JkPk04w38Sz8qDgY0+ptklcpFa6RRD1z PQoA== X-Gm-Message-State: ABy/qLbfLVYDaGEm/nBAwYUqoquA26w6j50EJ5nc64wOcKQpxjJ4MfP+ XpwfDT0cVAv+rtqQJCqzAKxjbg== X-Google-Smtp-Source: APBJJlEO2aWJnLprK4RcTuXXptsAhhV2CWniExK2SV0FTWirST2PpjxVowXAUeeRM51pJjQHZWKeBg== X-Received: by 2002:a17:902:dac6:b0:1b8:9fc4:2733 with SMTP id q6-20020a170902dac600b001b89fc42733mr5853252plx.3.1690449469696; Thu, 27 Jul 2023 02:17:49 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id x3-20020a170902ea8300b001b8c3c7b102sm1099792plb.127.2023.07.27.02.17.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 02:17:49 -0700 (PDT) Message-ID: Date: Thu, 27 Jul 2023 17:17:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 34/49] ext4: dynamically allocate the ext4-es shrinker Content-Language: en-US To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-35-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: <20230727080502.77895-35-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: tww48h8bmxmwe44njty1rxo48eowo7no X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1BD8420028 X-HE-Tag: 1690449470-162811 X-HE-Meta: U2FsdGVkX18gWMDEdIssCW+O7K2P6dsjL3YNRPX2ksEDzDtoVJ2xPBmOBraRuH4m33Oi4cbRoX0kqqNaYyBobJvuweLhY7dA97VKa2eBWjM1HDVPzUJz+JeDowqscvIUGsmTRSaNwTPgpWrWVey7HA2hTd11JMY0RT5cfkB4/9gdZOXOfIg4OxAHp8EvkmUgaWmkULhUyUHqkIMiYvkxV51JuwCWV2Cwr+gfySStef8WTj7syYDcRpuV5hmIqE7GyOtzpnpxniB0s0sb9vlysWKZoDaNZ4K0Lm2sy7m0bPodNmRsfskpbRj0rfBWzBrJDcLkWaCEK3kgIsYmdD+5dQ4iNI5xkHmioAcyLtW1JyFVXctnd8EQUmFtqXEKB4r4WvYrWC1voydMcjVuFYVReJ3fvxQKqF9NUvupRFOSjCRo1gPBRfcMWTc3wrGOhtGhGGn4n+kfPnW1i+XFd/LCrFaIEXnRxVx6hmojWB/YqnmtH2LfC5pjiIJ76IOSipllNPnWnlrUOXtjHoEKlmTcXbho/Vvp/M3bngB5TukNUGl1xOanuN6EgpxFd+ubLWyWNenQ//fEFECwAkxmdLu6Ibpu4ctjaWvzVbCSZsBH1IDUrDnr8IJVtmeqN1AFSYrNPYL5NA/EDJpaILzuVD31ehd81m+4d5gGxwEMd55JBiKnyPbo9vjGvo+MgLK4WtK2IDkajHBgTfJ9OVM8kHXv4SEj/T0FQy4BgUA/6rBhVOEzpghNYLd4lvOPKy+fWhDnFcpNKzWwooMnxBnF5JBAWP0WqjP5fmp6mCP7RRGKBqIinq+LKx+vGC7Kf8kcCxjWDPsFSd2eNyVqDq4zkToTE3b9UvSb+XNzjdHEvhiLnik6492du+SJ0+baepQe/q4IvmOtJYJ0AWw/aKKLo4iXsOPMadMI6TB6LUGQf+kBQ7N0/xqOlyy5v1qs2s4En4gzuxTCJpE8PbS3J8TpEAZ TKQSsggJ mm+58h8kgqVhlqjh9DlC4GRrL7vMPBHVccqWV9wV6TAC1NxqCQeNiN38wZwrazr2IkqeWpGebNO6RafW2dwh3cCfdYzYKVUhWdDZWzieCoxt+es4YN912cJbeboZogkLKb4XtuVDTJALZeD4Y8u8HVh5nXtOlCsJVc4sJEDubZbsCOGPJFinfv+HpzYn5keZhLLcaKcyIiG0eIvuNX4aMiuiFaec1NI+cJ5ILPvi6eguXBd+iCu8GajaD8uWGrG0L08T5wp14xV1b8jjIX2ZfUsheMS54EyNeNUvECqTXz3PC1/uwOi4ZlT0iGpwSmaY6w3x8QIVgQVPcJXSIaZ0I5IqsdXDA2kXVlaYgIN0l6qsdVWAjQ6/Z6N+IwQzdqTN+Sf/hr7lZEiB6qOo5H5kDA3wkLw+s05mImFJDEtwbxMu0efI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/27 16:04, Qi Zheng wrote: > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the ext4-es shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section when releasing the struct ext4_sb_info. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > fs/ext4/ext4.h | 2 +- > fs/ext4/extents_status.c | 22 ++++++++++++---------- > 2 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index 1e2259d9967d..82397bf0b33e 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -1657,7 +1657,7 @@ struct ext4_sb_info { > __u32 s_csum_seed; > > /* Reclaim extents from extent status tree */ > - struct shrinker s_es_shrinker; > + struct shrinker *s_es_shrinker; > struct list_head s_es_list; /* List of inodes with reclaimable extents */ > long s_es_nr_inode; > struct ext4_es_stats s_es_stats; > diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c > index 9b5b8951afb4..74bb64fadbc4 100644 > --- a/fs/ext4/extents_status.c > +++ b/fs/ext4/extents_status.c > @@ -1596,7 +1596,7 @@ static unsigned long ext4_es_count(struct shrinker *shrink, > unsigned long nr; > struct ext4_sb_info *sbi; > > - sbi = container_of(shrink, struct ext4_sb_info, s_es_shrinker); > + sbi = shrink->private_data; > nr = percpu_counter_read_positive(&sbi->s_es_stats.es_stats_shk_cnt); > trace_ext4_es_shrink_count(sbi->s_sb, sc->nr_to_scan, nr); > return nr; > @@ -1605,8 +1605,7 @@ static unsigned long ext4_es_count(struct shrinker *shrink, > static unsigned long ext4_es_scan(struct shrinker *shrink, > struct shrink_control *sc) > { > - struct ext4_sb_info *sbi = container_of(shrink, > - struct ext4_sb_info, s_es_shrinker); > + struct ext4_sb_info *sbi = shrink->private_data; > int nr_to_scan = sc->nr_to_scan; > int ret, nr_shrunk; > > @@ -1690,14 +1689,17 @@ int ext4_es_register_shrinker(struct ext4_sb_info *sbi) > if (err) > goto err3; > > - sbi->s_es_shrinker.scan_objects = ext4_es_scan; > - sbi->s_es_shrinker.count_objects = ext4_es_count; > - sbi->s_es_shrinker.seeks = DEFAULT_SEEKS; > - err = register_shrinker(&sbi->s_es_shrinker, "ext4-es:%s", > - sbi->s_sb->s_id); > - if (err) > + sbi->s_es_shrinker = shrinker_alloc(0, "ext4-es:%s", sbi->s_sb->s_id); > + if (!sbi->s_es_shrinker) Here should set err to -ENOMEM, will fix. > goto err4; > > + sbi->s_es_shrinker->scan_objects = ext4_es_scan; > + sbi->s_es_shrinker->count_objects = ext4_es_count; > + sbi->s_es_shrinker->seeks = DEFAULT_SEEKS; > + sbi->s_es_shrinker->private_data = sbi; > + > + shrinker_register(sbi->s_es_shrinker); > + > return 0; > err4: > percpu_counter_destroy(&sbi->s_es_stats.es_stats_shk_cnt); > @@ -1716,7 +1718,7 @@ void ext4_es_unregister_shrinker(struct ext4_sb_info *sbi) > percpu_counter_destroy(&sbi->s_es_stats.es_stats_cache_misses); > percpu_counter_destroy(&sbi->s_es_stats.es_stats_all_cnt); > percpu_counter_destroy(&sbi->s_es_stats.es_stats_shk_cnt); > - unregister_shrinker(&sbi->s_es_shrinker); > + shrinker_free(sbi->s_es_shrinker); > } > > /*