From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91ADEB64D9 for ; Fri, 7 Jul 2023 11:52:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03D758D0002; Fri, 7 Jul 2023 07:52:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2FC48D0001; Fri, 7 Jul 2023 07:52:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8218D0002; Fri, 7 Jul 2023 07:52:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CD5118D0001 for ; Fri, 7 Jul 2023 07:52:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A2259120638 for ; Fri, 7 Jul 2023 11:52:39 +0000 (UTC) X-FDA: 80984653638.17.B3C0DB9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 5F44B180012 for ; Fri, 7 Jul 2023 11:52:37 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PXlUg3ik; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688730757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5XJ4FXUgFkUhRIC9jXsJYhzmFiMyY6T5YwAK6lqpz2o=; b=wnPN8YG1aJ0Q6h4Enl9RzuAHa3ibfAZjmouhLGsgIKWXKxW0G8dz5CKjPahjcJRsFtAhqK RQxtlfyNLfj+plV7hSrM+Uc6EcmW0m2+t0gFVErTiwjeHtQaZso0qbx9MIYgL4qOs1VhZh CV3YbrIHzMHbArK5YNtjtqfGL4m6d2I= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PXlUg3ik; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688730757; a=rsa-sha256; cv=none; b=YDVvJAHUb4VgHAHNqsszyaHeSclPNiJnPMv4Mb7ZSxR1Xoh7KqWPanD//Pxt8ZIX4vXhoI wE7gljj8klIdUQ4QhENpOd2e7GNlBy4qmD/CplG1fejRhegTHuZvsz6vgeP7WFqnwCafKi hJfkbeFLeWItEKsD2GwvAPnc32BZggE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688730756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5XJ4FXUgFkUhRIC9jXsJYhzmFiMyY6T5YwAK6lqpz2o=; b=PXlUg3ikuby/5e4wM77newpFEhXi+wKcVj0gUNpDSyhCGVFh9SOSVYZXmoBdVPACjT1s1Z Rlivjy8lxBMd18K2LsNlxGe9sbgA0e3b8j+9aM2cWDIjbVeStCgbunsh/iLFdWQjdoj2iP WlzMBt/WEhb4KsMU8qgllomqnsoPB/8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-VAQKGp4yO3a9lM_yAfOeAw-1; Fri, 07 Jul 2023 07:52:35 -0400 X-MC-Unique: VAQKGp4yO3a9lM_yAfOeAw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fb416d7731so9901545e9.2 for ; Fri, 07 Jul 2023 04:52:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688730754; x=1691322754; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5XJ4FXUgFkUhRIC9jXsJYhzmFiMyY6T5YwAK6lqpz2o=; b=lIbK82vv3OTwww7Fwc8Hy954yzVk+TEs6mg6m55MZzk+h8ClkRSZnSVMr0YgxAIccD /1tLfwlVmC+aHe6qw/6WyijH92R5TzPrhjcB49fAG5R7ZdTjj77GFq70i1c4+dlLR/iw uRoiCmdhtxJp5qEOmlsWBoNLkXnzLo1lLyuHXtIwirfcS+51kp0GR7zzbTqbn6gKzhTA v0hE988ADujJnJebXHvSi6FRgOsDEU23oaoV4CM+1Lmuo/ihGYvQNUYMCdFLwbFfwm9B n4+wmGDN+1FXRlGKsMbN6bBUJe+a1ewqJBZXtnFkZ3VmtMDzzp3r3y1GWi0Ob0eRZFIM Nsig== X-Gm-Message-State: ABy/qLZVwx1xIVx4N4vQwtJvpUAkuAfYf/asXQOpt2U0OYy6RYSqKrR1 Fdcwm+kHiiz86t+Jp8QTm3hDzyFUJX+eyIhkGuUwHHJy0J65M/QdHTqaUsG2Uita2SN5xHmkG3/ 0jeMyhwUpK8L0bnJa5nI= X-Received: by 2002:a7b:c44c:0:b0:3fc:4:a5b5 with SMTP id l12-20020a7bc44c000000b003fc0004a5b5mr1144911wmi.29.1688730754145; Fri, 07 Jul 2023 04:52:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlFxvuezs98ptqWaXtveLHym86k+FjKP4gOwuZFxoAKspzxWyVgDzNTtI55hUm9XRK9UFuavNQ== X-Received: by 2002:a7b:c44c:0:b0:3fc:4:a5b5 with SMTP id l12-20020a7bc44c000000b003fc0004a5b5mr1144893wmi.29.1688730753785; Fri, 07 Jul 2023 04:52:33 -0700 (PDT) Received: from ?IPV6:2003:d8:2f04:3c00:248f:bf5b:b03e:aac7? (p200300d82f043c00248fbf5bb03eaac7.dip0.t-ipconnect.de. [2003:d8:2f04:3c00:248f:bf5b:b03e:aac7]) by smtp.gmail.com with ESMTPSA id a16-20020a5d5710000000b00314329f7d8asm4289542wrv.29.2023.07.07.04.52.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 04:52:33 -0700 (PDT) Message-ID: Date: Fri, 7 Jul 2023 13:52:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] mm: compaction: use the correct type of list for free pages To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, vbabka@suse.cz, ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5F44B180012 X-Stat-Signature: 1yieg6pgbhupysx6rh5tk9ksci4gezr6 X-HE-Tag: 1688730757-916999 X-HE-Meta: U2FsdGVkX1+k9mzk+lX5W6OyqNChMcHnAM5ZxgOfSIJK5qYl49Q0GewHaFeBPSQKZZKVvaLu4LFLTgc7nPoV0ZSvadJMl/JIUIju9lgJz4I5+pCcBtxVSkI++Hi5APwRHY76NchAyAziNBJPCBEJkz1T+1G2nrVxXFhDZUZg56CP+yLoSrNdeyuC2tFuAmL1C5NJBkUaQjYgKdP1wzUEMokniqnMjV7SsASfw/2cvsKVJOsJzXVi9es2sTP1q763UaBa7YnB8jJQeHYua4EfjKHlI5ZG09S6WxjERsFqFDyv3q+PjArWsLsyaPNhoNi2YWaWlgou3DjRLbpGG9rYtVB+cUTRRGK/IUp0Lem5xj4a8D/ck1wQO8eHdYtYcBLU67LOuqI/ii31xDnO3HkpGNDZqy92wps1mXqHOz15Oyl3HOH2aX2TWeMEhfAkl/Mh8UT+r6EGdfb6O2gvs8iNNOcuoi8qJ97nBt8jZnqLKED0tiRSSCDZ+fl6BP3GNx77yUBIvrrbMPlKsTbJGpJt7kBtQZ8bU4WwyD5eazZXbsglfM5P8Q7gcIVEF4yIyBGrGyOh15aXWE4sfb0sMFTviulXrvi4I3Yt/jEdCj04nGkhvS+oLFghQv1BL7gZhmwKZ3hPmCsj1xTFsvpn7zPVtiDPjotTHjlVSNIrg34PYzJQkz7+t9jCrBdMLjckf75EQqcA8ZgJ9HJRCbbLsVF281atq8QyVFZnOy9hhD8Cvx/OaYM0g1VEDrNqm4oFPiUF2TVYl+Py0xakW36oOIe4x+1IqYwVBLmQ+iIWXc3N0nFbQGLyRsRrlUBlEgMynVGR08BA27+zhnn8jqrHhXChRdzdvqEbgz/4r++CYrEGSBlLcAFN5AQDyxBL8Cz/8GIm2/VHU/17AJXNUV9Nkr2dL1qP02fdmfyKQQEQ8aE2a246QqDshgXg50NqKP1G4hnW5a0ZQJ4z0TXMHmD+fsz m/i70fex NRz48JSq+T8wuXt/BlDyBK3aNJ+xLL9qHJBFtTeXS3Szl6MoUELKRawfs7ohHcFcPk/v/0TYscuW2RXHjN6Q1e0NKmG0L1N17h3KU+sDCoaoBCcso6VxmnBPovHOYrRt8u/h54Nn+VImcJjZ6Kva3MsPG4Btc4wpbxsmVR47mZmEbHL0AwfPEHPUNELgMB6DTDaEYuR0aOdv7jRZ4lbhrMnibuBoTdSkH/WnD0x5iyKKUrTTnuVFj4VOxYXZbq6Dy8oyk/FCSa+TKbFB4zJi7pMyuN8dIxa79LVLw3H9b+4wUj4XUVn6i2dREXGztsgdiTQ7TBgrSi1LXzN1gPSm/8jWvKdCGrw0V+seIeU5rkew/XSDljGNxA+5bMgbrLZwWC4iiqvO3I2kTOgU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.07.23 10:51, Baolin Wang wrote: > Use the page->buddy_list instead of page->lru to clarify the correct type > of list for free pages. > > Signed-off-by: Baolin Wang > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index dbc9f86b1934..43358efdbdc2 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1500,7 +1500,7 @@ static void fast_isolate_freepages(struct compact_control *cc) > > spin_lock_irqsave(&cc->zone->lock, flags); > freelist = &area->free_list[MIGRATE_MOVABLE]; > - list_for_each_entry_reverse(freepage, freelist, lru) { > + list_for_each_entry_reverse(freepage, freelist, buddy_list) { > unsigned long pfn; > > order_scanned++; > @@ -1883,7 +1883,7 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc) > > spin_lock_irqsave(&cc->zone->lock, flags); > freelist = &area->free_list[MIGRATE_MOVABLE]; > - list_for_each_entry(freepage, freelist, lru) { > + list_for_each_entry(freepage, freelist, buddy_list) { > unsigned long free_pfn; > > if (nr_scanned++ >= limit) { Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb