Re: [PATCH 1/2] hugetlb.h: flatten logic in arch_hugetlb_migration_supported

[David Hildenbrand <david@redhat.com>]

On 08.10.25 23:26, Gregory Price wrote:
> Simplify if-true-return-true-else-false logic.
> 
> Signed-off-by: Gregory Price <gourry@gourry.net>
> ---
>   include/linux/hugetlb.h | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 526d27e88b3b..b030850975ef 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -876,12 +876,9 @@ static inline void folio_clear_hugetlb_hwpoison(struct folio *folio)
>   #ifndef arch_hugetlb_migration_supported
>   static inline bool arch_hugetlb_migration_supported(struct hstate *h)
>   {
> -	if ((huge_page_shift(h) == PMD_SHIFT) ||
> +	return ((huge_page_shift(h) == PMD_SHIFT) ||
>   		(huge_page_shift(h) == PUD_SHIFT) ||
> -			(huge_page_shift(h) == PGDIR_SHIFT))
> -		return true;
> -	else
> -		return false;
> +		(huge_page_shift(h) == PGDIR_SHIFT));

switch (huge_page_shift(h)) {
case PMD_SHIFT:
case PUD_SHIFT:
case PGDIR_SHIFT:
	return true;
default:
	return false;
}

-- 
Cheers

David / dhildenb