From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB08C433F5 for ; Wed, 20 Oct 2021 15:20:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E226461371 for ; Wed, 20 Oct 2021 15:20:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E226461371 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i-love.sakura.ne.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3B2CA900002; Wed, 20 Oct 2021 11:20:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3637A6B0072; Wed, 20 Oct 2021 11:20:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22B5B900002; Wed, 20 Oct 2021 11:20:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 134346B0071 for ; Wed, 20 Oct 2021 11:20:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BBF802DD69 for ; Wed, 20 Oct 2021 15:20:28 +0000 (UTC) X-FDA: 78717177336.20.8431112 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf11.hostedemail.com (Postfix) with ESMTP id BA284F0000AF for ; Wed, 20 Oct 2021 15:20:27 +0000 (UTC) Received: from fsav311.sakura.ne.jp (fsav311.sakura.ne.jp [153.120.85.142]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 19KFK2FR077596; Thu, 21 Oct 2021 00:20:03 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav311.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav311.sakura.ne.jp); Thu, 21 Oct 2021 00:20:02 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav311.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 19KFK2c3077592 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Thu, 21 Oct 2021 00:20:02 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH memcg 2/3] memcg: remove charge forcinig for dying tasks To: Michal Hocko , Vasily Averin Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Shakeel Butt , Mel Gorman , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@openvz.org References: <56180e53-b705-b1be-9b60-75e141c8560c@virtuozzo.com> From: Tetsuo Handa Message-ID: Date: Thu, 21 Oct 2021 00:20:02 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of penguin-kernel@i-love.sakura.ne.jp has no SPF policy when checking 202.181.97.72) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BA284F0000AF X-Stat-Signature: i5yxy1zybh5ccf84utsgny96z3o7fzji X-HE-Tag: 1634743227-537434 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/10/20 23:57, Michal Hocko wrote: > One argument for removing it from here is the maintainability. Now you > have a memcg specific check which is not in sync with the oom. E.g. > out_of_memory does task_will_free_mem as the very first thing. You are > also automatically excluding oom killer for cases where that might make > a sense. What makes it possible to remove this check? This check was added because task_will_free_mem() in out_of_memory() does NOT work. See commit 7775face207922ea ("memcg: killed threads should not invoke memcg OOM killer").