From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D300C369D1 for ; Tue, 22 Apr 2025 19:58:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03CC96B0006; Tue, 22 Apr 2025 15:58:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D5E6B0007; Tue, 22 Apr 2025 15:58:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF59B6B0008; Tue, 22 Apr 2025 15:58:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C4C946B0006 for ; Tue, 22 Apr 2025 15:58:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C007E818E6 for ; Tue, 22 Apr 2025 19:58:04 +0000 (UTC) X-FDA: 83362740888.25.9C37247 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 8E16B80005 for ; Tue, 22 Apr 2025 19:58:02 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=flt1wpCr; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745351882; a=rsa-sha256; cv=none; b=t/85Ac3akXkp0rkSObMNocpwUYNgdYH/+4QE2+f2DnnGKiCcH5FzIOPGFA/TT7U4QVDjnG f5tFjj+WaUUwohDMBGfV5WIdYgr0VS8Mn3muVg+JHdNYn0CoT4IU0cCVYKwm0mLymzXlLP A8cKqgLgAPV3TNSyM9Es4uWePAyogjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745351882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZUY+s/OQUXFXP8L09NRnyD2RvAyHXBwWpTAF7YObAcU=; b=T+PgylLxvHxWKA0ec2Qsna4FZi3s0NCCELieoLzXcG+OpmZM2vwYl8UNTRn0OlCMmh5Ws2 JK/kti3p+ys4vcU2FLieys+iBBF5zVu/ur3NjVawZDzN4TUs9wMC8OxNeWBeJakhvZo40R 8wM0DJIBDKEr9WZuPXdNhkY8vlEAfFg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=flt1wpCr; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745351881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZUY+s/OQUXFXP8L09NRnyD2RvAyHXBwWpTAF7YObAcU=; b=flt1wpCreU/nfuCTeT8r6yQXfMXRBGqyMY7V852o6OW+j6QpivClvZ+9+tIK2PmDW+VCEH IdoMyxf2W1woeyDaNdx+VRoRRvIyZtTxyvOiIOjME8XwsBzH3iVdDuAXkuLmAobB8RQC5g R7HkKpuKz8GSPaK4bjefRT5i2pX1CrQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-EEnpbrHnP1eCrlAiwxFfmQ-1; Tue, 22 Apr 2025 15:58:01 -0400 X-MC-Unique: EEnpbrHnP1eCrlAiwxFfmQ-1 X-Mimecast-MFC-AGG-ID: EEnpbrHnP1eCrlAiwxFfmQ_1745351880 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-47689968650so64627701cf.2 for ; Tue, 22 Apr 2025 12:58:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745351880; x=1745956680; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZUY+s/OQUXFXP8L09NRnyD2RvAyHXBwWpTAF7YObAcU=; b=HApgkZvhx5DB7OOCINBN6+oJyZjL6sciKq5h1/6SiSPUdDYnWNQJcHGhcv686EJdFe 5DnuRlzEHmnDF8FsIBlnlwhxrYp7YAmhJnL/tjjdyTeh7dMv2Ou4eOWuFQOzcgUu7L/+ 9PShotJPoxifqeYLpz+YlISt7jjK6WRe1bv6wYOM6Y5WWnIMGr1OLWQMdxaR1Mz5rQoR hr6b3JjfCeGJi4myQUEMdpdbS5+VzNFgqZ/TGN4DdBa19NPOyPUomR/nbNkO/EaxO3tH BXdd7+tqaimjlkV1KGErIWERLu1gQjeWBmnlSeTykNKI2NmE+/oUT8G1fMge7vv/Yw3y +fMQ== X-Forwarded-Encrypted: i=1; AJvYcCXGzQc+lQ88y2SQW8XEk6ysjbAvshGKlzf6NTID5OVyij8Ml8bQMHO0Qx5UliffZNkX/wa9wezvhA==@kvack.org X-Gm-Message-State: AOJu0YxgGD0OJNlvSqbs77YgB5FxEGNxZwi2Ml1DDrCiYCAjOBI+Ddyk pcNqgrSC9Jx9NCqi4kGTDlaL9Hy6GdaI6PF6gkfAB8p315PSeXmFjs2JQJRfMlKbKPOnmY6vu8i TKrVcebmVzf8gf7WVaS7ge6iDqx5r+sfu9CocplMpM3mWP9JmBnOJdHB3 X-Gm-Gg: ASbGncs3tfFvQeufK8yRtUEiZhu4tm77zh7HoGyTTq2+Zzeou/CmKzzw5aY4LdKBzq+ qLBroCK7Ph7hQ2/vlOz7MPQgr7+kNUisjTx5yhBL/94nkeONEQIaL4CU7kTaYeuyOXaS/THMLJe Xw6kCqFoxyFhHbf8e+KpbQhvn6ARom6MAbDOqA3oDlCrJWJISeqctwSFGhClGGUJTKZxYtuZz6d b1i/2kftxYuJhB9Z/V+xJjHmTSoZg+itrsbh9/cmcVn2rXv6sO7MkA5B2zLnYqjX4GwTXjX5+uM ZuzXtuMSW0RAQKE5DMz0AvGKGeA9B/Yt28yMtcwyf9v66U8o3SgXsKNsaA== X-Received: by 2002:a05:622a:3c7:b0:476:8ee8:d8a0 with SMTP id d75a77b69052e-47aec39232bmr307223341cf.2.1745351879758; Tue, 22 Apr 2025 12:57:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHd7hAQKx+/wNns5UwdTf6osByvR4cMbQCvwsh66hbH0j+pw3ra8yVAyn4cmmasa59/fdUmHQ== X-Received: by 2002:a05:622a:3c7:b0:476:8ee8:d8a0 with SMTP id d75a77b69052e-47aec39232bmr307223011cf.2.1745351879485; Tue, 22 Apr 2025 12:57:59 -0700 (PDT) Received: from ?IPV6:2601:408:c101:1d00:6621:a07c:fed4:cbba? ([2601:408:c101:1d00:6621:a07c:fed4:cbba]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47ae9ce265esm59111901cf.61.2025.04.22.12.57.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 12:57:59 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Tue, 22 Apr 2025 15:57:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpuset: relax locking on cpuset_node_allowed To: Gregory Price , linux-mm@kvack.org Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, akpm@linux-foundation.org References: <20250422012616.1883287-3-gourry@gourry.net> <20250422043055.1932434-1-gourry@gourry.net> In-Reply-To: <20250422043055.1932434-1-gourry@gourry.net> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SYQlrv-QFYd1CzZNcAFEq8LuaoB2MpKoxpyZagrX5Uc_1745351880 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8E16B80005 X-Stat-Signature: qqc3xga8ysooaw4zm19n4s4ed9gzb17t X-Rspam-User: X-HE-Tag: 1745351882-702029 X-HE-Meta: U2FsdGVkX1++VQ0sEN+gqG8exj7c2eQn70Dt9VcyXTzKnisHOyE/7B+ArrnQQix36SiUMPV+8uebwfpTo9ryzo3ajAhtJsqSzzrcL6NWTl8x1kvCSDN33K+LnI/gjzoebEeozw8J/ETHEZZaEgrkFg3+I89EUVEC56OHtlhSkPgnVn0n0UFOk8tojwKxEPeUGpvSgqPqBsP/MHj/WfU4hqqlkKU5/cCeGigTavPu3f569aovJ8eZwIC5ACOtVo6aRAeH+E67FW0UczGCKmMHUt4SPCIXEqqHeLkJ0qctE+Tkr3b0NzAppDzhLrzbHjrooTA3627bfVl/ij9XdFBIFlHshkCPaGzdlDfut8Q75ov/6fBuEplzjP8uUdG4Nk4N7JpFxzRM+xLZpYneJ8YyjUsXhqmzMHfvpY4irz07aSPAOeQdMGxyuDke0ZEX3eqeyAaM1RJT9tj8O/gHqhM3fZFAr7MFhreCLXXfc9qLYPdsjhTRG3SbAmactYL0DOgxIbAuyC4C+O/YvEgw7ZN7zy0y3SSxBH89gaWXZJnHJl8KM71lTIdeVoBCcJhWaG+ZUr7UBOd7bWa6L01ntFQK81GpWfFPShKoO+uyWt9XzHA9Yt1IgKWPlgC1hKUDcNDhbnXRE+b0d/wgvlqgo1ORWt9j+oVpMenhJUNNCi1Xz/zYM5E04R16tA039z482qRppqAu5EAJHbLf/0JtT/FBNZGyTJQJ7BtUUqZYtxo8A3kay73yv55hPEyoxlGyJnrBinIAoWUBR38BCoXXP6e9woUxh6q3Wercq0FJVJwZGRSiVqPpxpkGczFRDC4jvatIpKTarCoUCUEA0HZWRMiwmx78V/YRM2vfkptxoGakVThYb5tK2sn709aUC+o9yDrdVz3S23LR6S8cB1rGaogzq/zTK+h9l6khwHnKimhW9p38HcLo37g3rEUCS+VJSyiCIXyggg4lHa6hV8hnYmT nCYZsHJw LuC/8s6bD1D7xWNJs9o27jbKhzEGfV46TsNL90OYQNkuDiIrXU6YrjFi9a1wZyf2IkFZJ9M3L55ZK7SO/7a/gMZTdbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/22/25 12:30 AM, Gregory Price wrote: > The cgroup_get_e_css reference protects the css->effective_mems, and > calls of this interface would be subject to the same race conditions > associated with a non-atomic access to cs->effective_mems. > > So while this interface cannot make strong guarantees of correctness, > it can therefore avoid taking a global or rcu_read_lock for performance. > > Drop the rcu_read_lock from cpuset_node_allowed. > > Suggested-by: Shakeel Butt > Suggested-by: Waiman Long > Signed-off-by: Gregory Price > --- > kernel/cgroup/cpuset.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index c52348bfd5db..1dc41758c62c 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -4181,10 +4181,20 @@ bool cpuset_node_allowed(struct cgroup *cgroup, int nid) > if (!css) > return true; > > + /* > + * Normally, accessing effective_mems would require the cpuset_mutex > + * or RCU read lock - but node_isset is atomic and the reference > + * taken via cgroup_get_e_css is sufficient to protect css. > + * > + * Since this interface is intended for use by migration paths, we > + * relax locking here to avoid taking global locks - while accepting > + * there may be rare scenarios where the result may be innaccurate. > + * > + * Reclaim and migration are subject to these same race conditions, and > + * cannot make strong isolation guarantees, so this is acceptable. > + */ > cs = container_of(css, struct cpuset, css); > - rcu_read_lock(); > allowed = node_isset(nid, cs->effective_mems); > - rcu_read_unlock(); > css_put(css); > return allowed; > } Except for mislabeling RCU read lock instead of callback_lock as pointed out by Johannes, the change looks good to me. Reviewed-by: Waiman Long