From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9813DCE79AE for ; Wed, 20 Sep 2023 09:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35EDC6B0139; Wed, 20 Sep 2023 05:25:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2686B013A; Wed, 20 Sep 2023 05:25:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AF686B013B; Wed, 20 Sep 2023 05:25:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 086FA6B0139 for ; Wed, 20 Sep 2023 05:25:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C8F7780EE9 for ; Wed, 20 Sep 2023 09:25:49 +0000 (UTC) X-FDA: 81256443618.28.861C990 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id C8A22160005 for ; Wed, 20 Sep 2023 09:25:47 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jSu2tOJN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5l44mGML; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695201948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kxkQ4+wBOTwkXTk8BbRT0PH/v1p4CUyHigmCVxQwZR0=; b=zNQ2rKZ8e9pFK8AVqSu1xoJbWwECLxrd/LgMOtwgj8mYN64Fb4EZl7MtRuJe0UPGRWJEox 4j7BFc8MA/UfLQ6fAVrsezAOcINGKYQJlOnO1V0DW4xqbj8A/5rvloGeAXjAJv8u4S+Zgp aDoSAh1GRW8PqkPV4w5FAckvk8PgvpM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jSu2tOJN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5l44mGML; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695201948; a=rsa-sha256; cv=none; b=OQj+XAWusSO7MJjXn7P4Uf4vyn0oZXv+d88tAe6bkYazXse5qykmX6oIHLhRiLW5XKPdAF g11XRQJcsGit/3Kl9mIUxsam8+y9eL9ksPWmLeDnnPk8Ys5ymk/74KJm+INjBbHzUTazOY 040/gwoXCyPLSYABDDpGlr5+taxsrHI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2673F1FE69; Wed, 20 Sep 2023 09:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1695201946; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kxkQ4+wBOTwkXTk8BbRT0PH/v1p4CUyHigmCVxQwZR0=; b=jSu2tOJNw4XVBaM+Wbuv4u8eTxnqs0bFgJIBBkPkpAkFxrrcey8Vy6MDoHEnySk1jimpEw PJSrsmdaVdrP/w8FfgFcD0TcRLBv2h0EJg82+kXMe/opBAnPtSQmTVFu3xI31+ccOMH8UA hMzgCIqc0HSDAJuJbWEehuub8eZlLlM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1695201946; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kxkQ4+wBOTwkXTk8BbRT0PH/v1p4CUyHigmCVxQwZR0=; b=5l44mGML64eFxRVyCE0NOQnoMb9XfEGpgVZ2MsA6e9i50UmBlvsAWkPG2qVFFyFO363Ujw gyqFyPdjPk9QPVBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 002521333E; Wed, 20 Sep 2023 09:25:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rAv/Opm6CmXKdAAAMHmgww (envelope-from ); Wed, 20 Sep 2023 09:25:45 +0000 Message-ID: Date: Wed, 20 Sep 2023 11:25:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm/slub: add sanity check for slub_min/max_order cmdline setup Content-Language: en-US To: Feng Tang , Christoph Lameter , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230920074413.1361547-1-feng.tang@intel.com> From: Vlastimil Babka In-Reply-To: <20230920074413.1361547-1-feng.tang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C8A22160005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3dgn7jqy1qbyszdwdindfp7xcifs7mgw X-HE-Tag: 1695201947-610147 X-HE-Meta: U2FsdGVkX1/9qQrix5ePOJ4gCVBlZZbmei8+3+JTgI3MzevSp7r66ZMkGxVfifTMJycNpdaNp9g+Ct3PyFrauKKskSOMIAR+dicOucMR9kt+T4un2TT1UNNcX69ljYy2VP2DlsXryEGTcio5gzd1HrFGCoiFJuW2h9N6wNdwDtNnbWRZUIxQjE3PTAoaK6/uDcePpSaZAJDo4A26qp1nkr5x6PU8aqRW3Lr0XfSTG6PQO8SWjq++tgOvvUefBbIo/cxXZffMnLW8i0VGVSbf4wAQ8l58lKnBOdmDN1ayOueEiP/UUmow8qw/l4TjBaP4w/FrVjGHZEN4q2QEtRmoQSkQTjNr4VKaIdB2bizAE+eGt3XhzNuVS8sib0IUO+1g/ImDu+5zzyWHJlQWujXwn3zghddg0Gryxpnka0T2TLw++gMNV122HR5nDOZc8TOuzRSJGliHie0rDIi1qAdBlBRsfoMWcNDQkskQo55LtLOyGnzjuYwgO/x21UlvgaWoKi3wBQJP0Fxri0ImbXLjZ3sYwVxuoiLApoGfF/6f4Z/kxqQuLqJttMRW1sTint+46nXoVeiqlS4Q0KAt/+hzhoaSb0bcSJew3RihNcxUdseEZ63Xmd/1MsSOFvSKdEYVXgzk1k/E92N3HFz1ZW37r9rgfwF2PDEh4Y21sEOR25z1d0WW64T4XIirqygXNEnd3rdePd3Buy7tN+3q4TRc7jfJrhrD4sjlQrV+vYwVjrV5tG+pyKe08eEdVUzNtlJZjPuvuFjnku+HzhxFY3FvX2JlBZ86GnjcZlLHQAkJf4fk9uTOpoHJ4eHP9tSUZMSQUUkZBNujF6avbQXG0cQUL75iWM9thJjVz8Gq3EOs479FjX0w4jC2p0E+4c64EumLYl2ip8XfODBSP4HiIeCT3ORapTSjlF7YickcyU/8EHEIUqcR5n4QFwDdD8L0Pb0dIMKbSUB1mT6CBMp6gnr VFqyhClg Jtqfwtb4fG/Jb8RHgtmID0SGz/4gBOO1XPYKr1m33gHfxSjcl469RwSvmC8zhegZ6E4lVKijy2qqUL70EGJsYXv3z01zwNEXdNjf2WGYYsgTitfD6ui74VkGEPv4+/2sbe5NH3Oe0bziZm+WyoL7m5QleeIeN0T0T9uwHwAPc2GYTnH3vr8RMh62bYmvLBqgqxnmevdAUtmufC5/KhTVeANTMTF1nVfQCHpiEMI6KYN3vafOVpsAYOdsohtozLY2zXwe5X0TYGRjl24XMmWlVr36+DgbugpJ/xhmJdCtO/jEQttvBDjptL7teRWsPAAB28Vu2ad43KyAEBK8ez26K2dQwjB19eo+0GgrYim8Efxnhw6x1x36k0CUTDyApSQVoQLnMVPmepYJMt4ZzwDyHr8r2Xm8PAurxnYSCpSAeDJcWzqGGrtoZyFHXSeDI8IDbUpD0nLpLl0dzOQ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/20/23 09:44, Feng Tang wrote: > Currently there are 2 parameters could be setup from kernel cmdline: > slub_min_order and slub_max_order. It's possible that the user > configured slub_min_order is bigger than the default slub_max_order > [1], which can still take effect, as calculate_oder() will use MAX_ORDER > as a fallback to check against, but has some downsides: > > * the kernel message about SLUB will be strange in showing min/max > orders: > > SLUB: HWalign=64, Order=9-3, MinObjects=0, CPUs=16, Nodes=1 > > * in calculate_order() called by each slab, the 2 loops of > calc_slab_order() will all be meaningless due to slub_min_order > is bigger than slub_max_order > > * prevent future code cleanup like in [2]. > > Fix it by adding some sanity check to enforce the min/max semantics. > > [1]. https://lore.kernel.org/lkml/21a0ba8b-bf05-0799-7c78-2a35f8c8d52a@os.amperecomputing.com/ > [2]. https://lore.kernel.org/lkml/20230908145302.30320-7-vbabka@suse.cz/ > Signed-off-by: Feng Tang Thanks, applied! > --- > mm/slub.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index f7940048138c..b36e5eb0ccb7 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4711,6 +4711,9 @@ static int __init setup_slub_min_order(char *str) > { > get_option(&str, (int *)&slub_min_order); > > + if (slub_min_order > slub_max_order) > + slub_max_order = slub_min_order; > + > return 1; > } > > @@ -4721,6 +4724,9 @@ static int __init setup_slub_max_order(char *str) > get_option(&str, (int *)&slub_max_order); > slub_max_order = min_t(unsigned int, slub_max_order, MAX_ORDER); > > + if (slub_min_order > slub_max_order) > + slub_min_order = slub_max_order; > + > return 1; > } >