From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3791CC77B7C for ; Wed, 25 Jun 2025 08:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D07826B00A2; Wed, 25 Jun 2025 04:37:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB8306B00A3; Wed, 25 Jun 2025 04:37:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B589D6B00A8; Wed, 25 Jun 2025 04:37:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9E39F6B00A2 for ; Wed, 25 Jun 2025 04:37:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1FF94123A31 for ; Wed, 25 Jun 2025 08:37:59 +0000 (UTC) X-FDA: 83593270278.24.8FFBF99 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf17.hostedemail.com (Postfix) with ESMTP id A73F940002 for ; Wed, 25 Jun 2025 08:37:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=UYAWYeMt; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GQ3FJB5W; spf=pass (imf17.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750840675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZD5mD7noJveBOSJa70Cgmnc3ZXzWUiAmRjr7qiHi9eg=; b=adm8Vh5TFX0l6TPYHpQ8GC7Hmc7sJMqbnR8r3CXTKznvXbCQKsDLTL6dknmM93tlQK3VcK qn099QtahCD+09UmmknGsGZBIUEdOScv68fKs3kwzupTjLA9zRFbZvJ8wa9CVOZfvjePO9 VSKNsUXfxE1HWAx2hZStO4iR/Un/TZ4= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=UYAWYeMt; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GQ3FJB5W; spf=pass (imf17.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750840675; a=rsa-sha256; cv=pass; b=7TG4zUCMZXUW6gIu6UbvtAJIov9jF+7zEXlDkau5jGDvintD7sH0yeZLrXprLAN4/P31KT nbGwy4cACHoixRBNuf2ppHFygg1ehqKcw75Kr0agYDw/v8ejBQHf61TgVz2uA+hIlxRE94 aJBeKMxWkbXo2ONj5bYognrI8AzitYo= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55P7fe9g032649; Wed, 25 Jun 2025 08:37:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=ZD5mD7noJveBOSJa70 Cgmnc3ZXzWUiAmRjr7qiHi9eg=; b=UYAWYeMtHQFfPuwTdpMImCrPCsa3pTi6gf ELXGYKMZc3X8DOQOywkQ4FjrRBUiGLXPOUkOj5QiAU8YLlhMh3PNymfJr0F0PYjf lxHgzVogwvy1l7BGiy3XakUOrIo4TAo3iCvAk4eDfTtt3g3xKs7h4yNbAsER7rBf F+BFUMY0gAiDdc9jeeD3czD3cjGXtI5K6zQFQyu4YM9+1OYqljvBgEs5XyF3wPtm pjMZWx+PM23O0XzGBajGvhLhGmxpdVycktoGNqHesiO6MFMPEDTYkEmgH1WZUYrI DuNzF6W4TJlnqxHHxQxX2avowE7T1PWuvsTj7PUujJPEpSCJ9xeg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47ds7uxym0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 08:37:47 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55P7CBej028823; Wed, 25 Jun 2025 08:37:46 GMT Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11010043.outbound.protection.outlook.com [52.101.193.43]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 47ehpr9e52-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 08:37:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fdlTKPdoYySuNcX+wlXC9RubEjYP5JJ7hE3sXvnA1FN/jbH+/agOpgTlSovy2WPrdJF5I/TTCDicR1//1lwLlk2M4sfHnHVw2uotz5VbCzbpVLIeBPyIpnyBfDIJXHcnKJHLK5Mr6RtexwWNsAcFc920oAgb4zVNvWUc6kTDqmJGRGJIEzWfQIspliS6AaFfvgIAOIP/zD56iO0dgUfctrrmI4H5U8LwZ8urtMx7duRRqd0f4FJu8gFpb4wO91FaCAFi9U4JltwoMqBmJ+hxGcrRqCtwtxMgc3J9IEq+Q3TKaTjbgYdbmD+rATZmHEX5dbuLWI+iJwq4QXo6t4Gzhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZD5mD7noJveBOSJa70Cgmnc3ZXzWUiAmRjr7qiHi9eg=; b=cthigUKpeRzZjehEdGefGcgjRQ1tqhjA7Iteef6hMvY3FYmbJxe5VUG8MMszKn5BHp1UtTAn4+ZX8/X95RG58iXyQv/GBnlOnBTnFP8SxG3gq5NrJi36hoBDFbwwf6l4oePaEToMEJK9jkbUeaavqWrCpFZinHGShIjs3Yd1j/wTxlM7g/bqYhwfi6RT83xfyitSST7Pvw6hyICOn5uQHMU0sWRWHutCXaG5KmwaHowB+i4letwblcSY7HZy6g8pn3iTf7zOHusjOwZgsGPF9/s6M9x5xp493XzM4v8hRiSigQVqUyD6686wZkGZ0C/+mc7PAjDLq8ev9RTwXh1tag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZD5mD7noJveBOSJa70Cgmnc3ZXzWUiAmRjr7qiHi9eg=; b=GQ3FJB5WHDUtxWMn7m1jK7gmcgLS9oTlr39DUXmoApzldFYKXV1nyWoNrzOafmZgqubTV0En0Z9/O27KqlHhGWfBDFMdcE/LDFqev2toGTR0+ORStQ7MqzdzDxEPh4uaSTlhXd2VvR/Qt6RL7097cw9XIbJPbgwW8HqLr4MAdZs= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SJ0PR10MB4638.namprd10.prod.outlook.com (2603:10b6:a03:2d8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Wed, 25 Jun 2025 08:37:44 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8857.026; Wed, 25 Jun 2025 08:37:43 +0000 Date: Wed, 25 Jun 2025 09:37:41 +0100 From: Lorenzo Stoakes To: David Hildenbrand Cc: Hugh Dickins , Baolin Wang , akpm@linux-foundation.org, ziy@nvidia.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, zokeefe@google.com, shy828301@gmail.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] fix MADV_COLLAPSE issue if THP settings are disabled Message-ID: References: <75c02dbf-4189-958d-515e-fa80bb2187fc@google.com> <008ec97f-3b33-4b47-a112-9cef8c1d7f58@redhat.com> <01d679f2-fd64-472c-b9dc-ebe87268ce82@lucifer.local> <23b8ad10-cd1f-45df-a25c-78d01c8af44f@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23b8ad10-cd1f-45df-a25c-78d01c8af44f@redhat.com> X-ClientProxiedBy: LO6P123CA0058.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::19) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SJ0PR10MB4638:EE_ X-MS-Office365-Filtering-Correlation-Id: 89360f2d-c45a-4302-98d7-08ddb3c38df3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pTWVz6cByLXEFf7L1CnabTpKyAg4hUCRCp9PByXU1acMDNkufAmbOgaSpNNR?= =?us-ascii?Q?RDw3m5EIOzdMal4mJG8+e0t6eZ6Pkfw5WMAShHKtPAIUNudFIO2R7Bz3FjtF?= =?us-ascii?Q?czGWl6KAc7r5LxXkZe1QKEaewe3aaCWPtSZk1vqm018qYfkpOqbPd7uoH9iB?= =?us-ascii?Q?WwpwMXk9RmJR2xeSU30nbNdNV6VeMcoetAy0aIkCk0skLuS57rEhVEkh6p5i?= =?us-ascii?Q?7culpkCRCAovrjczTa1MBJhUoKouUVZI6XQrQjSi8YmESX9ISww3IDI7ZSSi?= =?us-ascii?Q?Ff31reiABKCP84S6FSH2bdye47v5tOz4inldOPgnijbK6oKSs1cG9XCEBQli?= =?us-ascii?Q?6ndw7v0wCmMvY3wAi15wzv3m6CAxjezawvcrPMugtLHMCDqmC5JE1dLKj5/e?= =?us-ascii?Q?K0lVGDDXlRxgM+7AFlIdMYEnubrYIDKzA8jT3hGTw9IU4l7TAO7ruijcuIvP?= =?us-ascii?Q?yzQv7Rz7FZQlb0Q7v2wPQdEuV2YGkOBQaI7YNc1OjSXZbUv5X1WT44JiVbR9?= =?us-ascii?Q?E2Q7NZNBqLm621SZ7NWbcyNljm+vVSguZgjWBqOgM1D0yMHU0VEm1GQMjoAF?= =?us-ascii?Q?Qul3HAzTm2e1GM6Uw4AekNFmrC3vfOp3GocrhI+Sd+2SYnOjXdFs+ocx6tzm?= =?us-ascii?Q?PyNyA5W4C1zAFXIpHcDlOv5+u7bAyk9N9LdbNwbyNaxKBgUJtXQFgP7PpzZ0?= =?us-ascii?Q?yKIKcU/lgK8lR+3UCHs86OmObgHu+gMafaJL5+i72tzqo1R2/ZGqiToflJN5?= =?us-ascii?Q?6SlQ5EouaaqDKpbQe/6FfBYNa89va5ERQi9/UeTXft+fDkiYGrR3NRrPwXdr?= =?us-ascii?Q?DIbYr2InF2jJY4MCOfzc/CSPml5M3OScijsp2xIhlmZvY90JiIcM2ikHfIEL?= =?us-ascii?Q?S5liz+iO/Psh+4rB9+ItQTwjSpoHpdKE3c5RUTK6hhlJrCSbXSpXB8OymIpC?= =?us-ascii?Q?xJHKAfcHKKSw/tWNRRdGlnTLNisH9SE4c61N0330AZxmJ0+Z4z+WNMaRx+fW?= =?us-ascii?Q?QHftBljImDSfZ2JP4pNhZKYJpWMOR7uOGhkkakytkXIuJxN6C/pOCxp+/7M9?= =?us-ascii?Q?3M8MXGpbRnc18DMQ9NlYUu82q5Q5cNNb1EczfU2asMeHSktFLG14enouq1YG?= =?us-ascii?Q?xUvOU5S4u9m9kcvu/5pT6kkEEvv9hUGs4iIgAPzUOLPi7CWGy5v88bIAhKGP?= =?us-ascii?Q?INqWZ9syYnEQNNVCxldQQYI2uYmxH6hFP1HECfVxoewC59NGxlEAKmbKVrqJ?= =?us-ascii?Q?3NhjBay6Yb5Qy48Olca8XP8j3DMih1wFaVTXy6IivWrChxl/P2imUdXxnCkw?= =?us-ascii?Q?i7KlLFq1alAQDQz3HrsJQiZRNCfdiQ5IC7C6oAmZXSaaM/FwMpEX2F/r489W?= =?us-ascii?Q?/RJjoFqnbYOv6txlDMjLGfYrUvYaKkMHUjCB0aeJ1KXc7yWGUC5dY66Bfu5z?= =?us-ascii?Q?lqfras9Cs5I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BQDEzK7UZBEJ+9D8iUiR2Q4TcSrCvzpP+JpEMizKBu2O+/aUT9cxhb2DYRyK?= =?us-ascii?Q?v8fQtTLPtlm6k2+vZ7Lq2qmM5kQQ7uJoVubLLNPD0deL6Npj9fujYzev5ihI?= =?us-ascii?Q?GwYNmidAIPOMUSH6GEG8LuEI4ZDpjBc5Ed5E8Y1FqHuKCOBeTqD9q+ftgeqq?= =?us-ascii?Q?sAJ4lGakJfSYcWWSq+qQqFXknbH4ulgkNxy0Rjqm/jBjdxnbhSMHiXg4QDGa?= =?us-ascii?Q?bkoDSZjRJPEO9vfIl39XeeEE7E1jxiLHfMPhNqXw0rmQcwx7oED6LvDO8xlP?= =?us-ascii?Q?kxAHjcUo88aT+wphrnp4+8PdzTrlbm5DO7OixFUwcdRmFuv5NGbg6Br8XZkf?= =?us-ascii?Q?GuZA1UPAHv87C35NR9uVoEOcvU/Xl3f+9mGfWfF6zp88BDXsM2HXfNnIs3MB?= =?us-ascii?Q?c9YQZWWSVuSRvMxsiX49V3tecyTRAm1vNJLBrbNoyQ1qvdO5hy6a8xR8fWrB?= =?us-ascii?Q?UUr78NRQrCAOV3bo5b4p8omHUYpfZuV7IihgrLVr2Y3stF4NvoTLvYhJatJ3?= =?us-ascii?Q?4XFhoySWX1YXu6uV8TGkJilu6ZBhpRt+nEqtOaBcAzJGAM2/NjI9ztNBlpz5?= =?us-ascii?Q?CztbZrbX39qe/bcaUyLRjsDkyI/E4mLFe++/lH80VKHPQMs6PPcCBksB/9PE?= =?us-ascii?Q?60+aCuxVqVYX81Ga04rCtdtBhJcZUbEyGN8edMCyUmerhzCZoRjS/HM9CUwV?= =?us-ascii?Q?YFpEgcBxxLJE8Q66Fk8uBpvQPWxpdAT1j/W7QhkNmzZ+cJekwn4WbobzMpYr?= =?us-ascii?Q?h0YNskQdAbxiy8McvHUxeHlWXiqNLXyksxKo7l18s4So3EJw1si1n4mQ0kpr?= =?us-ascii?Q?ju8POc6y3U7xzCIHNadpUOCOispxah/iv6IifnkqU+Ahd0Dvn/RzeKs8543w?= =?us-ascii?Q?Q/VMl7JqJ+3G1+2TwzTvBuaEhcNVshnlpkpwTR6FMiHuYUCozDn5guB99rAu?= =?us-ascii?Q?IpsKHZK0Nirqt1b286HUJQ9qBcz1GhK/AaIMIe0jJeJudOIV3t7C52BZwjsQ?= =?us-ascii?Q?Kra+QWu2Yk0DaLIFLHM9F6N9rONMy9Hkpg6oduVOB0YGOCISQUp1iM9z5sgW?= =?us-ascii?Q?fQC1oKNAXpVsghxXWgzhA/n42qk3OtohRwWwMruXtuGzfRbq2eiA/IKDepn2?= =?us-ascii?Q?z0X7vJrVbzHBablKUtr2VZyRad+kKdh6atioxuYn1ylMQ0dHiQrhBPZ8VP5k?= =?us-ascii?Q?viCbb+SJts0Yl/me4DZzVXkP++s0ZgqGAD07v4Pl49teVbaY73t9iR4vcgaj?= =?us-ascii?Q?t5u1f3OAxoYvVQnm1vJKwRHVYgKmAM0uN/73dQOv/avtf7WG42TkU0MS4dCQ?= =?us-ascii?Q?jvX6t+cmIC2TOhCp2OI8ovGy53BEAe1pMsmP2KPxVLx3xGGBRjH3KoWAIPa8?= =?us-ascii?Q?4vb7SOQ33XyS4r+ld8WeZ5SbtYVbTcs0Wji+ydzFjmhHqP8fZcJmFrtn8SVg?= =?us-ascii?Q?L0HGA0qxOStnvgrKRQ6cBcrvg869NvzYXOrOSaaIoTYJD05ChTmFy//JSnOi?= =?us-ascii?Q?n1Y04ZZjqkNDL7GaLGTQit9BB47ky7Gbd7Qggk16IFhX76Cnthq3w+GYjh4o?= =?us-ascii?Q?98nWxRSEIFSJdroMfFufWPadUihAbPM+IlNwkWARGBPcH9yu4Ja1izl1UQ9F?= =?us-ascii?Q?xA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: P93kamFhFxGbzvINf0gmMLak0hXuUMZQPKQGYddLBxxdIWZigAdkZLLGgXeY4X6WLU3exOqKD+9CTU3Ox0eBE7uIRWcYltm5bleKMMwFbBIWfkKGbD4iY1QmOF/AA11tS7T3qmn4F2RgsqPAPA4iqDXjnBxIRnC9vXIjCLYrMWy+pFnnJubnFcuOHKzqw22wwDvZDnEdtJA6ru/BTZZCwmJQ17tQiEzQo8A/WgX58zc69XfhSoMclBHxc1Yw/VlJuZ94z3T6a0hrA2rtKepHpkWwD523zgw5Oyd9s4mfGg/BHrvoixYApZYezz/iqpl6E2giMBR0mGNLutaGV49RweEipBZq2ZWvofnulqM427ZyhRdiksaP9VXg9ryLkyrV4eFU9hwd06pNnRR3AWa+Ddtj82lJWqs2RpgLXuChEsaL5JkQg797SlJxVvX7vlAs7uZQhIrouua6XP0583GnDwx4PYGw7cvK9f31VWPUq10PplnC3yXbNtFDn/dP6dhWlCCVR4xrzTfidYpQ4/ZAkaLm9sOsDa6fsCPxPr4iEapBrbCNXetRzQQ67H24j1RFx1D1/f/usR3A/CwMduP9o15GeTgL/Tiv7iX/Sn/gbQY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89360f2d-c45a-4302-98d7-08ddb3c38df3 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2025 08:37:43.8740 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NZDkygeUM9i61NdfsMSB9r6zykv5JugCdQJ2WtWbzd+TqaC3xAeFdpOq6yxOumtcIGV8ORAOTnd3ZNX3t0P43YoA4Gi9TG0pPgJ6MFhhHNc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4638 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_01,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250063 X-Proofpoint-GUID: u0HuPLJOwk8shONMIiABm2Sve7mk7KHV X-Authority-Analysis: v=2.4 cv=CeII5Krl c=1 sm=1 tr=0 ts=685bb55b cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=SRyWv8gS9IM5ZP0jeyoA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: u0HuPLJOwk8shONMIiABm2Sve7mk7KHV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDA2MyBTYWx0ZWRfX92qmdQJAznT3 4wvY94mLuEPfIwDAdtvCuODUDKWAlDt30ITZ5bKch0aRmKAoeq6ok1vuwvLnrAoAU3LWfJ08Qy2 wn/pvO5nZ6KO7VS05Q3udH8NnzDK2w5uvnmbOSEqO27klSsWvH0b2BBcEYsSbGJOT/5u3pixjVF wU1ZS9c+VAKmFaA9yp3KxI2QrknBCYI6QxvRrWkBE6luP+Rx8Xsf+nGWToAKTmtaTOTunM6bb34 QOor1aGECtNTNqANLksQFP4jGz6IAfTNU61O1MlPVSW8NwrHD+h/n4we1husS87/R7VwV1zBPBa ha6eSJlRSeOdh4mmvJ8xhgp7aKejf48HrleG/h5kNAj/cspzfaq7l3zMZpKBGnyu6aU2bcwxr4B YFTn3Ic7wIr1PN8M9VrtSfT11Z8le61yj6zQb8slSgUqIJ3nMkDi0YwGQCTjhOyOFnEAUzcD X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A73F940002 X-Stat-Signature: ti4dcjg6idm6fhxfoo9qytet67uazow1 X-HE-Tag: 1750840675-506667 X-HE-Meta: U2FsdGVkX19h6lekD495aQIZmsEzcCCO8L1olADiwlyvl5aTDnDM1vgLNhO8o021Y3QrJxG32A1yIfwA8AFzbZ5t3FpwJF+2PpnYG5bKccSkA21DmCadL0zZn6zcIcrn4Xa+u+CczT/vMTNK1Ep6Fv+XgOmJN3IlPFpXXFpO5f0ZEUqLlVeD3qjEHu0BiJFh9YFNp+cIdDMo5LyKX+dGuevhil0lkd/LnQ8WrbRnYT1IGrzHU6OMRYLXqN33U+cvJ66Dulr+cjLuIIpcYuP1/uPR0gLjWyWlIiT9pz6GywSepRJxkBMn2X4mScdhaeQSStU6VqoIdQ5YopA6mWIKa3/8Tyk6zHfIh032pbGqvEDk7T9kBmT719IRiLGkDrWC/ekzdzFHcUSiu+cEeguXZTAWS0fkcZg2CpuON916wcz65kZrTeu8g8nEwPhDeqKNVLejyl8LlLqP8SH059BZgrOVeyEoCJRW5YMJaTt722B7noi26N54B0jZF8Ly8PpXhrjEr+pzzabyj5L1iva09zVagtYObETiIseluu+IQQ0WT9FxZYURVFSrXGdUUVoLKbM/avTWgs1Tpeb6Z6PgEubjT9mN2PwAoflIcjQAe6o/S9xg3SrdWznofvFkchE16QLqMi5Yl/WCr0ZA7OPcjYEB+6aZMtmSh64KVpXe6qZt0KX9yhPIlaHQYu2XjDOpNrplIvc4syIVfwgT7mUQtDBvJJ96pwojw1wESVRQ/pTnpKw7fv42Hjxli0nefaSzPwa781MOmR2UkpwS1sEMv/ZPZON0T56mjOgxUm2DKQ5AtNU01Vl8fyLy/emi+wCL4/ig/Q3kM1pLPynxPeJXOvcUpFc6pjea8hRW2SY/G7nSUw+Kr8No1gUaejuULi3+BD2cwCz6WLZtiabsm1SnsgVwnzsY35zg3QUik0nuIavLjJ/t0xV7ke0jp6IFwFi+hJhVH5ygO8fyFfIGspR by0ssO/a aoCqOUSklCe4s3Vo3wMZ8vFkwyUAmt6YZLUZXew6XWHXkFlx+eRM4gsAUEVUUTXTBBPAa+lNfDNmStbaoJQkYRM3GIPDBrpUWVdo+YxqIFPNHJ5gSPSGzoKDUeMknzCFSwQOOobo+xqpeD0PsNj47GpvpJDwKXSZava64vBo0b/OINnmcWijAhe8qVW8vvx+cvU1SBmQmgwSMCsxR3Ek7lp26OukRdvcrJ7pdtbXl2QNv1I+liMgZyhlK+OCi3dRh4IN0k6+EI3YopoZM4dhN1KvWRilGAilkmEFzJpEU7yq/842++zFXLYlUD40MjUGwJs5EqIpxPw6aGkeKt8eQks+oYwSWwFtvHJjK11FT2sn6pgGLR8QSdG6MQAVCN8W6rD0GzU1kvQvuAjqDX8KvCRrLlT2sj1fmbioZyxe88HnxdSJYYwn0MCtYCi1cl2NfUvNuV1TPZCQNDB3u82RMc7oxabJLdZAH7jgePtDW+AnVUoVdgsD52qG0M4z46cCF+ire32CEJj3iNyphyYSnwKlNoFfnQ36R7Abj3yjLx1x4v9ozOx3VWfnq/p0VyRa6AblbllE/tTIYdXMc+cuqd0Us5BLeREqI9YQeqt3mDcQZsSJqFTzCZkilrUIfJHa1pc9C0Lhtv6PtdQ8ZXdSwrY/NBzac/bg6/3fGjJ2wD+MKq/fCU5GYIv1dRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 10:24:53AM +0200, David Hildenbrand wrote: > On 25.06.25 10:12, Lorenzo Stoakes wrote: > > On Wed, Jun 25, 2025 at 08:55:28AM +0100, Lorenzo Stoakes wrote: > > > I suppose the least awful way of addressing Baolin's concerns re: mTHP > > > while simultaneosly keeping existing semantics is: > > > > > > 1. Introduce deny to mean what never should have meant. > > > > To fix Baolin's issue btw we'd have to add 'deny' to both 'global' settings > > _and_ each page size setting. > > > > Because otherwise we'd end up in a weird case where say: > > > > global 'deny' > > > > 2 MiB 'never' > > 64 KiB 'inherit' > > > > And err... get 2 MiB THP pages from MADV_COLLAPSE :) > > > > Or: > > > > global 'deny' > > > > 2 MiB 'never' > > 64 KiB 'always' > > > > Or: > > > > global 'never' > > > > 2 MiB 'never' > > 64 KiB 'always' > > > > Or: > > > > global 'never' > > > > 2 MiB 'madvise' > > 64 KiB 'always' > > > > All doing the same. Not very clear is it? > > > > We have sowed the seeds of something terrible here, truly. > > Fully agreed. "Deny" is nasty. Maybe if we really need a way to disable > "madv_collapse", it should be done differently, not using this toggle here. Yeah maybe the best way is to just have another tunable for this? /sys/kernel/mm/transparent_hugepage/disable_collapse perhaps? What do you think Hugh, Baolin? > > Regarding MADV_COLLAPSE, I strongly assume that we should not change it to > collapse smaller mTHPs as part of the khugepaged mTHP work. For now, it will > simply always collapse to PMD THPs. Yeah thinking about it maybe this is the best way. And we can then update the man page to make this ABUNDANTLY clear (am happy to do this). This keeps things simple. (One side note on PMD-sized MADV_COLLAPSE - this is basically completely useless for 64 KB page size arm64 systems where PMD's are 512 MB :) Thoughts Baolin? > > Once we want to support other sizes, likely MADV_COLLAPSE users want to have > better control over which size to use, at which point it all gets nasty. madvise2() this time with extra parameters? ;) I sort of wish we had added a flags parameter there. But lacking a time machine... :) > > -- > Cheers, > > David / dhildenb > To summarise: Drop series: * Might degrade performance for very specific users using never/MADV_COLLAPSE (quite possibly via process_madvise() + a remote process). * Matches 'de jure' interpretation of documentation. Keep series: * Provides no means whatsoever to have a 'manual only' collapse mode, though does provide for manual khugepaged THP. * MADV_COLLAPSE automatically gets mTHP support based on obeying 'never'. * Matches likely 'de facto' understanding system admins have about THP usage. Action items: * Either way, I (Lorenzo) will improve documentation. * If we drop the series, provide another means to disable MADV_COLLAPSE. But not using existing sysfs toggles, something new. We will document MADV_COLLAPSE as PMD only. * If we drop the series, also consider how we might provide mTHP-compatible MADV_COLLAPSE. * Totally and completely refactor the hell out of the THP implementation from top-to-bottom (over time this is becoming more and more of a me thing... as I'm getting ever more frustrated with the implementation ;)