From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184FDC5B552 for ; Mon, 9 Jun 2025 10:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A592F6B009B; Mon, 9 Jun 2025 06:36:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0A0A6B009C; Mon, 9 Jun 2025 06:36:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91FE66B009D; Mon, 9 Jun 2025 06:36:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 74DDE6B009B for ; Mon, 9 Jun 2025 06:36:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 306271D7D4A for ; Mon, 9 Jun 2025 10:36:34 +0000 (UTC) X-FDA: 83535508308.19.757D36B Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf19.hostedemail.com (Postfix) with ESMTP id 34C571A0012 for ; Mon, 9 Jun 2025 10:36:31 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=He6973Nh; spf=pass (imf19.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.45 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749465392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vpaFRUPan5/TpiEHmRBhmrQ93XppgJeF5Z1cXdjt+MA=; b=T9k7c9YTHTykzGhAV9p623DxvAEl/1prNskzdzRPMvjtTkNKlPrcNjBMs1f3N9nEvmqTmw pAbhwrqgW1GDkgshMvU3zXcD5tTY8Q3evZWB5b5itqe7FAIQ9Y1EGn4LPTkZTZcYYCm9LV cxnS/eP0IqnUo+QOAn63oI+OTXc9n0k= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=He6973Nh; spf=pass (imf19.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.45 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749465392; a=rsa-sha256; cv=none; b=ensC8imgdpAUl+ks5Bqqkc8kfSSSLSa7CiRyhBUJu4cMgZFtZsFHmu8YKYu1u55ei291fe EXuYkGXybMahMOCnJxYf6hqUYuesoU2Fgx2bsfAYUx23BNfwB+2HOMVWeveEPbZxQ77PIl H6DLUaG1NqQWp/QTdjpkSdSKiM8InMI= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-606fdbd20afso8214229a12.1 for ; Mon, 09 Jun 2025 03:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1749465391; x=1750070191; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vpaFRUPan5/TpiEHmRBhmrQ93XppgJeF5Z1cXdjt+MA=; b=He6973Nh0JUV0hnvlHIzZtudUlcAhsB6+ItdbxzLO3R6BbdoWAU5nZKSAU9Ta9CdAn dwVnauKkmjx9wdkngpYnLHGiO3vvEl17DE9NcliznD3fmAnDPm2R3cRzntLZiQRYchee J1eoQFHrrLgLIDfcbymA1qbJkugQ4o+DRCgpU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749465391; x=1750070191; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vpaFRUPan5/TpiEHmRBhmrQ93XppgJeF5Z1cXdjt+MA=; b=WSTbnjDpuE6W7fD7o8RsX8EU/sq/h9PaPdlpNLoNLnm036jwE0HClnitix4ktF/vF+ 60cOtfnhbv512TWlVbXnldnsdmG495kh3bFGhirCkTz7oEMVdECKUcVRTRjnG78EHJkb 30sP3w83AoZqYO8kjsrVSWbFxIeW1FaoclqBb+5orVNROBMJlDUv1cuGxV9w/GUuURtM cgb1VSM+M/cPvPpHDQ7pIe2y5ERMRUjwrAsiSjzGa9lVCL7KGPejafQgtdegMdV+3vUi Rzh598tuLaLE89Ys9uku8r+lKvEZRpgeR2fCsYpd83deRCrceBZQtBaSrRgr6J+XpagG zmgQ== X-Forwarded-Encrypted: i=1; AJvYcCWXZRlvmR06I/5eIymYp1zVp5rovqq2V/UBGrtKFnsNwhJpG/BnH8hqmEWK245a7Z8hjl/WB+/A2A==@kvack.org X-Gm-Message-State: AOJu0YwuAQGL7OQjReS0/ylA1znfV6qO/cO6l9RBPLG+beFN1JFQoRsN DvgHfNhQIy6BS+CFTOljilEOmj7XAUCu055CfGLqjxi6dchpH06cGeB+oFELvzkMv+c= X-Gm-Gg: ASbGncviFgLvAh0760m7J5/tImzUApjhAQmB2s3StFSKs7S+kBhkBpvL4l+Uk/kEyVq 9u48dhqh3PRbH/1qhZ0eMhiG/iZt6ej1wkyHyIwp7PfScggmZUlHJfzL+WPZ76oK6cm3QaQGgV6 OT7WMwOl0xkI+m0y6DrYh9hglSelUEQO58eNG2eP7o9g3ysiCLFTTgq34KmJXTHTe+kbkT0k4sL xYy6oWEHsaz6VzzPp/Bqu9EtgshEWGhBj1maNjNlezI0+lEY+kCRCqqT7XfqmoUDztCnGyL3o96 yybz5jzVgkcz/Y+RSNTkITtMZNuaWDYVbRqTVHYlFTP9undLUhsC8q7eXks+g7JjL40azZZR+0E S X-Google-Smtp-Source: AGHT+IFXxtx2CSlXJ3Top/v168+U7HayyPAa5xv6S3DVOLuAfynTta6qZG5cPMeCleB7WFl6HYOs4g== X-Received: by 2002:a17:906:f58c:b0:ad4:d00f:b4ca with SMTP id a640c23a62f3a-ade1ab3259dmr1092384366b.50.1749465390746; Mon, 09 Jun 2025 03:36:30 -0700 (PDT) Received: from [192.168.86.142] ([84.65.228.220]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade465b243csm321502666b.88.2025.06.09.03.36.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jun 2025 03:36:30 -0700 (PDT) Message-ID: Date: Mon, 9 Jun 2025 11:36:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm: Handle alloc failure in phys_*_init() To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: <9f4c0972-a123-4cc3-89f2-ed3490371e65@neon.tech> Content-Language: en-US From: Em Sharnoff In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: pzarr3bztkbgsasidw8m4f5pap7o8kii X-Rspamd-Queue-Id: 34C571A0012 X-Rspamd-Server: rspam11 X-HE-Tag: 1749465391-254266 X-HE-Meta: U2FsdGVkX1+yMJBGPJAZ6NfcmpitZx2I0jfqs38jYwHpElevAdHbWEY0gHBkZ614XIx5b2fVaOUD+h9as01iPJZ0gSjh6aXiu5mz+WBKa8XDQf31OzTGShIpE59vIyqkvOlJmVdtQoJnf/hWXUQY66VGZCTGJEiJYr/3aXQR+vwBJz0rFkSwu4BKzY7WBQakXus5QKZr3Ni86GVGq2CR4OVVyf1aZGhWLvfltmQ9Xa9ZbiZGyfyPAeHKcrAhIF2OKexwqhgl3I7mabe0/JvWCmQcW7E2zKpFjLBGxPilHRAJf+lRo3R+IqE7WgRkZ3Kumab++ZN8z62Km5J/CdanlQvbhDw/ZSnAVrHimCACM1x/u7pcwQ4qdZv+CZBYXnDfMJ/NyxXpD70yX2G1NQhMFF7F+tdWVeUFdnGo+hgCEhMqL4t4foqLCOlLy34EUb3FpcLEL68kErhV26k+B76I3zoIngFmp47ETCIV8ZJU2NtuosbVb7i6fLnrC+62U8wnTBpO2ELa6Z6AReLbRupQaJUQcwDqPOiojvx8wiXENpgxd/dam6dhh3HHyyuJhDzVbtU7MvxF+SClQeMZ0aPfgdXhXqPz4uciYUyKv8n7qj2cRRe2grcz2Pt9Sn1y8Aj3/yB4YQ0082UPGyuYYSApmb3a1mlOqOlregxRrQ4fuRu1GxVyNZ4Nv/0MaCXeXQebi25yYzIU6K1XgZS9EJlsFuofLdzVTHSSzFCMjxKxTIBbhao1G4UPkhEMLKASZef60YzWpaiCAjqRExtSFLu8SUuSoWk/SLbZDcDfcU3fR9hLnUkydgLhelh5neDX0i0evi50noEx3Q6J4swbEsfIbF9bSBIzvnKedkOkS4XzBNlltl4AdkfNSQD6+vMKRQaHBKaUif3daXYuRp9ooZerxfdsRhlFJoFE/Doq4yRSX94M+ZgCwCDJ3xQ2hM1vnhDTHSsH3G36cl/z/EJlqdF n6KFmWNL Xdyd/5lJGDU7MeEHEONmHIRmrwlpFwikEeAl1Ys3uMXbBopI+HCSnFCR0K3rrSSWs2h4uaamclr6rD9ja8bVys9AKEzXueyKxS4Pf5oweFsjT11x29fLb2fSUJxMSpWxsAeSMjj5tuekV/YRu0wddArmlspgmXlAh8iLN0tbczrohlFbDIKeL21aYQ2gW/LI0HiyVuq2q73XmxqQFVV0OCU9yhIhLKihmNqrAwxB5369iDcHu1b+iG1ZDZ7bNTyTjDuDQYwUJg741ISY5V0AWgoWdc7TzPmOwvs8SXgp647IOIhGY3rZ0Rg5Cwcsbyd8LonX5Fxf5nv5GShjCaO69MlabrmNGM/ZDXf2IF/5YNgcI5jXN8sfKtYRwnb7UOPRaxBqQFsLxrJPWN9r81TFVSW6SoLD5ZZ7N9dbfyLR1Z5TkfWjlssGuIMdf58ryVzrinD0GLt43lzX4cfya4K9ZzJSwBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-06-05 07:36, Ingo Molnar wrote: > I agree that it makes total sense to fix all this (especially since you > are actively triggering it), but have you tried also changing it away > from GFP_ATOMIC? There's no real reason why it should be GFP_ATOMIC > AFAICS, other than some historic inertia that nobody bothered to fix. Fair enough, yeah. We hadn't tried that, no > Finally, could you make this a 2-patch fix series: first one to fix the > error return path to not crash, and the second one to change it away > from GFP_ATOMIC? Sounds good -- thanks for the feedback! Sent a new patch set with those changes. For posterity, v2 is here: https://lore.kernel.org/all/0ce5e150-19e0-457f-bec3-ee031c0be7e7@neon.tech/ Thanks, Em