From: Em Sharnoff <sharnoff@neon.tech>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
Oleg Vasilev <oleg@neon.tech>,
Arthur Petukhovsky <arthur@neon.tech>,
Stefan Radig <stefan@neon.tech>, Misha Sakhnov <misha@neon.tech>
Subject: Re: [PATCH] x86/mm: Handle alloc failure in phys_*_init()
Date: Mon, 9 Jun 2025 11:36:29 +0100 [thread overview]
Message-ID: <decb3327-f47e-4ef2-8fd1-027acc6038d0@neon.tech> (raw)
In-Reply-To: <aEE6_S2a-1tk1dtI@gmail.com>
On 2025-06-05 07:36, Ingo Molnar wrote:
> I agree that it makes total sense to fix all this (especially since you
> are actively triggering it), but have you tried also changing it away
> from GFP_ATOMIC? There's no real reason why it should be GFP_ATOMIC
> AFAICS, other than some historic inertia that nobody bothered to fix.
Fair enough, yeah. We hadn't tried that, no
> Finally, could you make this a 2-patch fix series: first one to fix the
> error return path to not crash, and the second one to change it away
> from GFP_ATOMIC?
Sounds good -- thanks for the feedback!
Sent a new patch set with those changes. For posterity, v2 is here:
https://lore.kernel.org/all/0ce5e150-19e0-457f-bec3-ee031c0be7e7@neon.tech/
Thanks,
Em
prev parent reply other threads:[~2025-06-09 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 18:59 Em Sharnoff
2025-06-05 6:36 ` Ingo Molnar
2025-06-05 6:41 ` H. Peter Anvin
2025-06-05 6:47 ` Ingo Molnar
2025-06-09 10:36 ` Em Sharnoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=decb3327-f47e-4ef2-8fd1-027acc6038d0@neon.tech \
--to=sharnoff@neon.tech \
--cc=arthur@neon.tech \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=misha@neon.tech \
--cc=oleg@neon.tech \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=stefan@neon.tech \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox