From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36FD8C433EF for ; Thu, 13 Jan 2022 08:31:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C5EC6B0098; Thu, 13 Jan 2022 03:31:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 975286B0099; Thu, 13 Jan 2022 03:31:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83DA36B009A; Thu, 13 Jan 2022 03:31:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id 708646B0098 for ; Thu, 13 Jan 2022 03:31:03 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 255C4180C11E5 for ; Thu, 13 Jan 2022 08:31:03 +0000 (UTC) X-FDA: 79024593606.24.12D502D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id D273440006 for ; Thu, 13 Jan 2022 08:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642062662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BXCFcj3n+7ZELibrybMDe0RwtJDN8j7oGmTCl7zcp9I=; b=dXmPSWbBg4p2C557Tj5gwZx4vFri2divs2zXw02PvJhpukJjJaVm8o2NKJfrzE5rtME8M8 LqOmTrTuK8PiQGiF7vL03oqQjNO+jh37XyQS5u4eqzuBiogMmRe0sRH2ulP1ie/wM/48Sk xV3wAYkoyU8A/C3WTIyZ++3KC1PIJec= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-CVl3OKDjPD-S7IGU7BMatw-1; Thu, 13 Jan 2022 03:31:01 -0500 X-MC-Unique: CVl3OKDjPD-S7IGU7BMatw-1 Received: by mail-ed1-f72.google.com with SMTP id ec25-20020a0564020d5900b003fc074c5d21so4615954edb.19 for ; Thu, 13 Jan 2022 00:31:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BXCFcj3n+7ZELibrybMDe0RwtJDN8j7oGmTCl7zcp9I=; b=VFP3y2d0g/W71jdQAhPGmBVTPtKqU0SQiNL1PkWd/gKZlZzK6TOa434tvH9kgyPNjE BTTJMsWYnmzGxCyiLj6IAk//ZAbr2K60ezTuLQyUikYG7PhNBwxDckm6UeGLoNT1N7un 8b1l4PN+0CbNinXDLSnQnCpRooIfL7Ud+ALOsB37TQJeNkcDjJxje4yuY0YElKjnn6yA wnRyaKqIrbW+zQUACpzBxFtkh1TUS8ch9Zklv8/EuBG0xT8mO5ybJzwdKQTfNsuM7buS MFA2tRDRgCok4cfb1l2KTZ/ESg/SJzcias7Pc0oRQIlmY26Hmkrl2DAj64r+b1GzTI44 kOeQ== X-Gm-Message-State: AOAM530OZPkB5F8a+WOZLXNLhT6SXC6SOBcJIJhdp2cUXCiY2gjQJbDM QHZPteLKH7vcwpWf4ERBR1eXT4V70G4doaashDsXXj9twQ59tpj957KKY0LbdknEngbQyIVCFUM P0YbNk8ijp1U= X-Received: by 2002:aa7:d15a:: with SMTP id r26mr3248175edo.115.1642062659112; Thu, 13 Jan 2022 00:30:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzknkb0xmTbboqwce/Zfcc3Db5EA9gSCZZ5tOrVgsVBtO9pQMBahULvIX+JAUEWAGOmoFHug== X-Received: by 2002:aa7:d15a:: with SMTP id r26mr3248157edo.115.1642062658895; Thu, 13 Jan 2022 00:30:58 -0800 (PST) Received: from ?IPV6:2003:cb:c703:e200:8511:ed0f:ac2c:42f7? (p200300cbc703e2008511ed0fac2c42f7.dip0.t-ipconnect.de. [2003:cb:c703:e200:8511:ed0f:ac2c:42f7]) by smtp.gmail.com with ESMTPSA id bg20sm34970ejb.59.2022.01.13.00.30.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 00:30:58 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 09:30:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 1/2] mm/cma: provide option to opt out from exposing pages on activation failure To: Hari Bathini , akpm@linux-foundation.org, linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org Cc: osalvador@suse.de, mike.kravetz@oracle.com, mahesh@linux.ibm.com, sourabhjain@linux.ibm.com References: <20220112193340.149020-1-hbathini@linux.ibm.com> <20220112193340.149020-2-hbathini@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220112193340.149020-2-hbathini@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D273440006 X-Stat-Signature: fadbcemg6cfb95kzc8qy7iybajb4453f Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dXmPSWbB; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-HE-Tag: 1642062662-737483 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +{ > + if (!cma) > + return; Do we really need that check for NULL? > + > + cma->reserve_pages_on_error = true; > +} > + > /** > * cma_init_reserved_mem() - create custom contiguous area from reserved memory > * @base: Base address of the reserved area > @@ -204,6 +214,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > cma->base_pfn = PFN_DOWN(base); > cma->count = size >> PAGE_SHIFT; > cma->order_per_bit = order_per_bit; > + cma->reserve_pages_on_error = false; I think you can drop that; should already be initialized to 0. Apart from that Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb