From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4326FCD128A for ; Wed, 10 Apr 2024 11:56:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C889A6B0088; Wed, 10 Apr 2024 07:56:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C39366B0089; Wed, 10 Apr 2024 07:56:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00CE6B008A; Wed, 10 Apr 2024 07:56:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 877BA6B0088 for ; Wed, 10 Apr 2024 07:56:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1835040815 for ; Wed, 10 Apr 2024 11:56:18 +0000 (UTC) X-FDA: 81993469236.05.40CBBB6 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf23.hostedemail.com (Postfix) with ESMTP id D6FF9140004 for ; Wed, 10 Apr 2024 11:56:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712750175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LGNmt/S7/IL0OUuADDIRgHe2o+NBR2k/5sGmnPmJ1Xc=; b=D2049fnoo7EsZimbhJ/EMig4R9za9/Jm66xG3TextR4vDXTc/QFGJxUQMWKpqRfnXKtjEw Iw6WMPdV1HMRExsBV7M5qMZKc6wv2lgmN6p8Xt4jExJC1hnrHxWuC9Zyz+21Z0WPakpr9f dvaHr1A/bIYDiZUQ8zPgab4GPHh1k+M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712750175; a=rsa-sha256; cv=none; b=glqxNXATUCarYLWN8Iscv3ISiqJhDeQJFmH4FOJg8GtAh9f2xEbySINob3gYUMOd2wl8RO MXtgXkJgfJYe+59xxLfqb/tUDMMR9IAv7TRQ6fkxz5v64cr+bI7Cna0HpdMX0czJ91J/XP n8hreP9Zg7nN0Oxk7eEjwhpLt+2lwx0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4VF1Rz0bmjz1RC7s; Wed, 10 Apr 2024 19:53:19 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id 5C4CA14037E; Wed, 10 Apr 2024 19:56:11 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 19:56:11 +0800 Subject: Re: [PATCH net-next v1 12/12] mm: page_frag: update documentation and maintainer for page_frag To: Alexander Duyck , Jakub Kicinski CC: , , , , Jonathan Corbet , Andrew Morton , , References: <20240407130850.19625-1-linyunsheng@huawei.com> <20240407130850.19625-13-linyunsheng@huawei.com> <09d7d59b-9da3-52f7-b039-acd0344c88c8@huawei.com> <20240409062504.26cfcdde@kernel.org> From: Yunsheng Lin Message-ID: Date: Wed, 10 Apr 2024 19:56:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500005.china.huawei.com (7.185.36.74) X-Rspamd-Queue-Id: D6FF9140004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ff9wuxqihrimg1rfmtdi7nwsxcqu6bpo X-HE-Tag: 1712750174-337134 X-HE-Meta: U2FsdGVkX1/B3wYx8H541SEs+UmwOINsTT+ApiJ2aSGRv1pQUwtcICmVNu0QxtDk8MYibHKtrN1xWOKyz3Kd2OtJ6fRuMq4vZ2OHX8/SYE7wbEqsiCJgq8vNWusWFt0mPjmFdwZazpw9NFFSOZfX6PdnpyTslJnp2AxY05rsFF8dpKzmqdqtTonOYDQhoE1S1WoEdNpdyvxETzspYwjWCm4DCqFNWeDGHPNxUaQj16ZvA7ZVvkYrrGKWgPjVPu1gAZyWGS7VF8wNxfkBPiamB88/tlh8ueQ9ieRG0vNMUHH2sR4WBOkgjc1NQEOnDZmMbFEUTnCd9+RCTDjDmqorpTbeiVbzRS33JW2+v1whld5FxcaF/JFNy9uWfzbNRlZYa2LDyZPZKlxjUckVtqK3bGfB5wGNV624w/zI88K/aGIZdzUGcyABB0EVkJ0r7BXdOyWqiTHjkES/kteAkwsoc1qp/XXVaFm7xIffgfSDn0mSepL9Vaq/A7Ip9/uTB8KQlUxyk9lwRCqykPhzZBl8V5bA47mwBrRGjAAI8uIXKYdrWc/GA1ppz0+v0Y+R7/tOBv328OR4Kvd/LjpSY8iYVQW+2lnimoPQWhThoy5Yd7a59lji7MIj1kUZjCuKmbPay/U3Qa6d2+SNFnPsMJJo5REet8GxP5rq5zzYxqh0Cp9PZ2rsy0v333TrRoRtOSvndM3awHLzORYODQ0wqKLoDIxBghFZygX365Xw00Gwn6atsWBW4S3OPjxO7AbZ0sz4WbZctCo3wYYi6aujV8WCfOjj5Jv4W+al49rqOLT2YC8dSVZu333yxbQhTRNQQhSCv0WP0G6+tWTL3tZ4P3pAUdB5mfgpVe1r5SJdCXRUxVrj1STLHowLWkfI/mhz5K9SxwPeq/1+gEnPrHwXnEXu68NFzcT9+d3vB4Lccrtj3JyxfWxAuTDubmQXYCut8owxie15AZW42c2s+jCKKUv TPah6/SD Wp6Wb9uqEsG5SD5R0lIJqGcKWtdrCmg9pn3uQ9VwFkpXdhliznqWF1uHioz1p4oz8QEG8sUHtmfHxQlL6jS3KJo/Wu77T+SkOeeAoASv4Bdf7YWnzSiLOUjxpIJrfFy3n3nCJsbEDlqzAlp+bqrv7vJ1p4DG0G6BiJadjwYyxyz4hq5AlBgEMEGOMWIh65ebEvL0NOVDSFfBah8orb+3HlO9DLx+Z5Vu+fORLTXx7BeRDxG2DFhUS7fDrAoVkZY2Ex2uhiLYvzIyR2tT4HWhNr8gVn6bstGMrHvSRt6DYKRbCMKX4B08OWM+bziI5FGfEUBIIkm0E/6BdLXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/9 23:11, Alexander Duyck wrote: > On Tue, Apr 9, 2024 at 6:25 AM Jakub Kicinski wrote: >> >> On Tue, 9 Apr 2024 15:59:58 +0800 Yunsheng Lin wrote: >>>> Just to be clear this isn't an Ack, but if you are going to list >>>> maintainers for this my name should be on the list so this is the >>>> preferred format. There are still some things to be cleaned up in this >>>> patch. >>> >>> Sure, I was talking about "Alexander seems to be the orginal author for >>> page_frag, we can add him to the MAINTAINERS later if we have an ack from >>> him." in the commit log. >> >> Do we have to have a MAINTAINERS entry for every 1000 lines of code? Do we have something like rule or guidance against that? Looking at the entry in MAINTAINERS, it seems quite normal to me, I thouht it is generally encourage someone with willing and ability to be a maintainer/reviewer. Considering you have refused adding me as the reviewer of page_pool despite the support from two maintainers of page_pool, for the season of something like below: 'page pool is increasingly central to the whole networking stack. The bar for "ownership" is getting higher and higher..' I think I might need a second opinion here. >> It really feels forced :/ I am not a native english speaker here, I would rather not comment on the 'forced' part here and focus more on the technical disscusion. > > I don't disagree. However, if nothing else I think it gets used as a > part of get_maintainers.pl that tells you who to email about changes > doesn't it? It might make sense in my case since I am still > maintaining it using my gmail account, but I think the commits for > that were mostly from my Intel account weren't they? So if nothing > else it might be a way to provide a trail of breadcrumbs on how to > find a maintainer who changed employers.. +1. I generally pay more attention to the patch that is to'ed or cc'ed to my email when I am overloaded with other work. > . >