From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E512AC8303C for ; Mon, 7 Jul 2025 08:19:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 886478D000E; Mon, 7 Jul 2025 04:19:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80FF08D0002; Mon, 7 Jul 2025 04:19:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 727028D000E; Mon, 7 Jul 2025 04:19:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 52BFE8D0002 for ; Mon, 7 Jul 2025 04:19:53 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 098BC58EEB for ; Mon, 7 Jul 2025 08:19:53 +0000 (UTC) X-FDA: 83636770266.25.6AB7C49 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf14.hostedemail.com (Postfix) with ESMTP id 1DF5210000A for ; Mon, 7 Jul 2025 08:19:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=T0Hdtt+i; spf=pass (imf14.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751876391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=tAtyFqA6jH8O751SLLQ5KLceBfngZ7mZGIjMnUDI5EQ=; b=6mfZt7PEVAzpUpwDx5tW3H0EL2XnJBG6kyrN4+y70m0OMU68r8MK6+0OKHszAb44qSpZFA kKNACnNpUEQ2eVJ4rzqjduJSC7udP7ibVGjlK2bxhUA2JVQZ/5Kq2YybULUD2+1xPiZ5/Z ttmzKN8TCKdQzhdwmZ6jELcaKtLgfx0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=T0Hdtt+i; spf=pass (imf14.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751876391; a=rsa-sha256; cv=none; b=C4BqIy0katlIjE+wH+Zd4iI2ghQ5fWlnQzxJyq0O4lpC/GxlhW2HOZlRb8aA+RTWXoZsbS UzFTf6UlwTv6aZUrfzVx9fXzlqWI47uEYAOIhrbeA1LaBemyH6zqwSdPuyDXN8Rp6WyR/K 5eAf9gbJDpjvtNDhyWwv1Q6MZTLgYW4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=tAtyFqA6jH8O751SLLQ5KLceBfngZ7mZGIjMnUDI5EQ=; b=T0Hdtt+iL3OvItiwvDXSKNwtgZdDrW+VIXabwXuIT/N0XvWu0hDgJ+xJ RCLPD3hh+PPjAPmJfVJNzo00R3FJXKfKaQLmatIjiRqhBtGQMqH/admd0 C3UkTbirZ7QMiMp3PydoE2b9lDudgsndT1WgBrawnkWka++9QFyWRfH0k A=; X-IronPort-AV: E=Sophos;i="6.16,293,1744063200"; d="scan'208";a="120813824" Received: from unknown (HELO hadrien) ([89.207.175.48]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2025 10:19:48 +0200 Date: Mon, 7 Jul 2025 10:19:47 +0200 (CEST) From: Julia Lawall To: Ryan Roberts cc: Andrew Morton , Linux Memory Management List , Jan Kara , oe-kbuild-all@lists.linux.dev Subject: [akpm-mm:mm-unstable 77/240] mm/filemap.c:3283:37-43: WARNING: Consider using vma_pages helper on vma (fwd) Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: 9gp9wjuy3qf619tnmfggbc9ddgbphx5m X-Rspamd-Queue-Id: 1DF5210000A X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751876390-773497 X-HE-Meta: U2FsdGVkX195JMaK4S9eSGhwjLsdRZm7EUNnJVtmrWCpIpwMCbHnNpgF3ZmjfneOWQG16AzHJ1OK7XvmE17+zFXjMX9IQvne/a0LMppBlzkOMHfNnNYVnF+qFGM8I2CPCYZvAvjmt51e6cCXb5KlOlAc9MLrEmvc8DulMmcldwwI4lMErENdNUMzlZnqTkp5diquOPlnmvN2e2YJjpv8GdYG24c0JfHNFm60Tqgq2ZtunrtPG/7UA0HBlfsK/JtkgSaA1hFaYTy+msTEoES9xIucdXBw68JAF3Crzn9QIGm/R7zYl0d0P22/3zSFGjwqAQYZ5FPYJIfh2Z4uFeWdpsX7x9V2rmBsSsI4z1vVrsgzRFOyutNUgvX4nJiQVxZcD4U/uTZzBcwTK5sfZMYJPg8UsQeY6vjUz32J9HykAXEACi1dxZfZfuts9CQZXNMq1Y+YpTedbHn9HNnLTDMRBVsGYfp03jUfKuKVHzCiyo33Cxi7Hu2eQrx0RQwGwzqWyjpzU/udHpXLXJruDMELKFsKDiiA2OV/NdU7wnSeDEt8U1unKjMZ4vr8BX4e9FRiW+gmdVrngT7HqRG+f6Cq0SzukEBu8qh2Y0+fiiXc1ITEIDFLEK0/m38Uz2QUBtkHNJGx9jv5ojSuVrhpa8sxY47EoF/QXGOmkR0ozniR2283M8gMa8hZ5aYqCqtjXEPHR59VmOt+XP6DmYI1S/A/wc6BYfK6zDw7AVZ8vX0Qen+Ofy+8aby40hPmBXDkpXbDqkHUDhvaf3BWybTryUEjyyrxUFKgGnbzCYDaQL638KvEaML23R7+c+KgilZG0gJLoovsv9eh2bbbxZkDqHUd8qVcR7pepMdI4ZKMaNUES16HgLkq5HZNG13/46BUenawqkvEjN4Z9jfgnE7BlTCUH+MXNF78VU+yiFQz9W9cSkwSZjFLs0xM8mA1HIfdDmrVmH/5Udpa4PrA4Syl5mB Mq+AABxa nM2UFV6klEGqELHclztT98HOaPYFGFQNs3DpZti7jOmCmqDXit4Ehy5/YzKlmnKanvrt1ULnt/65H6coLi/SHAbVmbX2BY/+KKCCZ0UlpmxYlBR07e94/+CSxVGJsvm+dlanuNwMSNsPIMdcblXshC8NeesyHreidKn9Y+uD81eQ0D+QdS4wREpEE/aqBQXHteuy0YE9NsmsRcbtRiXgxnSowwcTzkp31rTwaVj5RnTscs46oNFYTiYC4pi7G7lksVfFZG4u63b8ciGUTBb2SvLX8XOpubOQQGsRsJ3UA8TadzD74g6UrbhhjoAexAg6U6QGzkzZOws8qr1rSd5fUJqoY3EfHOdmRibAkCyZOeMyrtu6CxtufdBijUoxHfBJ+pJsDmVtrhrMqiclz/wdyY77sXzsL3TTpsIGRpsLkerZgl8HR10oH0ZwjHs1wUQyq1DXJpK4K/DPMC7zJCCAVqg1C1fJgdVk9fb3hSwa5asyXIkMMA7R7/uW3FnJ2XGIUvH0wD0W8/b1ikTBlil5VJ2x9m3hmwnp6N4ranlLwL/0JGXwq+BYBZkH/LMY9+Eq6U+x58MKjIrpTLpU78o7RHoEn1e6c5sKTe8DlPMLhKHTiA9p2Wz4Dw+bwWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ---------- Forwarded message ---------- Date: Mon, 7 Jul 2025 14:53:04 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall Subject: [akpm-mm:mm-unstable 77/240] mm/filemap.c:3283:37-43: WARNING: Consider using vma_pages helper on vma BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev TO: Ryan Roberts CC: Andrew Morton CC: Linux Memory Management List CC: Jan Kara tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable head: 5aa46327724d1abe18a36e9dec4f26dba8989710 commit: b58187b2ba0af49c48448c3fe1b400cf8fa14232 [77/240] mm/filemap: allow arch to request folio size for exec memory :::::: branch date: 33 hours ago :::::: commit date: 33 hours ago config: i386-randconfig-052-20250707 (https://download.01.org/0day-ci/archive/20250707/202507071459.lLPSj5Bd-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Julia Lawall | Closes: https://lore.kernel.org/r/202507071459.lLPSj5Bd-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> mm/filemap.c:3283:37-43: WARNING: Consider using vma_pages helper on vma vim +3283 mm/filemap.c 4687fdbb805a92 Matthew Wilcox (Oracle 2021-07-24 3240) b58187b2ba0af4 Ryan Roberts 2025-06-09 3241 /* b58187b2ba0af4 Ryan Roberts 2025-06-09 3242 * If we don't want any read-ahead, don't bother. VM_EXEC case below is b58187b2ba0af4 Ryan Roberts 2025-06-09 3243 * already intended for random access. b58187b2ba0af4 Ryan Roberts 2025-06-09 3244 */ b58187b2ba0af4 Ryan Roberts 2025-06-09 3245 if ((vm_flags & (VM_RAND_READ | VM_EXEC)) == VM_RAND_READ) 6b4c9f4469819a Josef Bacik 2019-03-13 3246 return fpin; 275b12bf5486f6 Wu Fengguang 2011-05-24 3247 if (!ra->ra_pages) 6b4c9f4469819a Josef Bacik 2019-03-13 3248 return fpin; ef00e08e26dd5d Linus Torvalds 2009-06-16 3249 dcfa24ba68991a Matthew Wilcox (Oracle 2022-05-25 3250) if (vm_flags & VM_SEQ_READ) { 6b4c9f4469819a Josef Bacik 2019-03-13 3251 fpin = maybe_unlock_mmap_for_io(vmf, fpin); fcd9ae4f7f3b5f Matthew Wilcox (Oracle 2021-04-07 3252) page_cache_sync_ra(&ractl, ra->ra_pages); 6b4c9f4469819a Josef Bacik 2019-03-13 3253 return fpin; ef00e08e26dd5d Linus Torvalds 2009-06-16 3254 } ef00e08e26dd5d Linus Torvalds 2009-06-16 3255 207d04baa3591a Andi Kleen 2011-05-24 3256 /* Avoid banging the cache line if not needed */ e630bfac79456d Kirill A. Shutemov 2020-08-14 3257 mmap_miss = READ_ONCE(ra->mmap_miss); e630bfac79456d Kirill A. Shutemov 2020-08-14 3258 if (mmap_miss < MMAP_LOTSAMISS * 10) e630bfac79456d Kirill A. Shutemov 2020-08-14 3259 WRITE_ONCE(ra->mmap_miss, ++mmap_miss); ef00e08e26dd5d Linus Torvalds 2009-06-16 3260 ef00e08e26dd5d Linus Torvalds 2009-06-16 3261 /* ef00e08e26dd5d Linus Torvalds 2009-06-16 3262 * Do we miss much more than hit in this file? If so, ef00e08e26dd5d Linus Torvalds 2009-06-16 3263 * stop bothering with read-ahead. It will only hurt. ef00e08e26dd5d Linus Torvalds 2009-06-16 3264 */ e630bfac79456d Kirill A. Shutemov 2020-08-14 3265 if (mmap_miss > MMAP_LOTSAMISS) 6b4c9f4469819a Josef Bacik 2019-03-13 3266 return fpin; ef00e08e26dd5d Linus Torvalds 2009-06-16 3267 b58187b2ba0af4 Ryan Roberts 2025-06-09 3268 fpin = maybe_unlock_mmap_for_io(vmf, fpin); b58187b2ba0af4 Ryan Roberts 2025-06-09 3269 if (vm_flags & VM_EXEC) { b58187b2ba0af4 Ryan Roberts 2025-06-09 3270 /* b58187b2ba0af4 Ryan Roberts 2025-06-09 3271 * Allow arch to request a preferred minimum folio order for b58187b2ba0af4 Ryan Roberts 2025-06-09 3272 * executable memory. This can often be beneficial to b58187b2ba0af4 Ryan Roberts 2025-06-09 3273 * performance if (e.g.) arm64 can contpte-map the folio. b58187b2ba0af4 Ryan Roberts 2025-06-09 3274 * Executable memory rarely benefits from readahead, due to its b58187b2ba0af4 Ryan Roberts 2025-06-09 3275 * random access nature, so set async_size to 0. b58187b2ba0af4 Ryan Roberts 2025-06-09 3276 * b58187b2ba0af4 Ryan Roberts 2025-06-09 3277 * Limit to the boundaries of the VMA to avoid reading in any b58187b2ba0af4 Ryan Roberts 2025-06-09 3278 * pad that might exist between sections, which would be a waste b58187b2ba0af4 Ryan Roberts 2025-06-09 3279 * of memory. b58187b2ba0af4 Ryan Roberts 2025-06-09 3280 */ b58187b2ba0af4 Ryan Roberts 2025-06-09 3281 struct vm_area_struct *vma = vmf->vma; b58187b2ba0af4 Ryan Roberts 2025-06-09 3282 unsigned long start = vma->vm_pgoff; b58187b2ba0af4 Ryan Roberts 2025-06-09 @3283 unsigned long end = start + ((vma->vm_end - vma->vm_start) >> PAGE_SHIFT); b58187b2ba0af4 Ryan Roberts 2025-06-09 3284 unsigned long ra_end; b58187b2ba0af4 Ryan Roberts 2025-06-09 3285 b58187b2ba0af4 Ryan Roberts 2025-06-09 3286 ra->order = exec_folio_order(); b58187b2ba0af4 Ryan Roberts 2025-06-09 3287 ra->start = round_down(vmf->pgoff, 1UL << ra->order); b58187b2ba0af4 Ryan Roberts 2025-06-09 3288 ra->start = max(ra->start, start); b58187b2ba0af4 Ryan Roberts 2025-06-09 3289 ra_end = round_up(ra->start + ra->ra_pages, 1UL << ra->order); b58187b2ba0af4 Ryan Roberts 2025-06-09 3290 ra_end = min(ra_end, end); b58187b2ba0af4 Ryan Roberts 2025-06-09 3291 ra->size = ra_end - ra->start; b58187b2ba0af4 Ryan Roberts 2025-06-09 3292 ra->async_size = 0; b58187b2ba0af4 Ryan Roberts 2025-06-09 3293 } else { d30a11004e3411 Wu Fengguang 2009-06-16 3294 /* d30a11004e3411 Wu Fengguang 2009-06-16 3295 * mmap read-around d30a11004e3411 Wu Fengguang 2009-06-16 3296 */ db660d462525c4 David Howells 2020-10-15 3297 ra->start = max_t(long, 0, vmf->pgoff - ra->ra_pages / 2); 600e19afc5f8a6 Roman Gushchin 2015-11-05 3298 ra->size = ra->ra_pages; 600e19afc5f8a6 Roman Gushchin 2015-11-05 3299 ra->async_size = ra->ra_pages / 4; 28b31a2b2dbfc0 Ryan Roberts 2025-06-09 3300 ra->order = 0; b58187b2ba0af4 Ryan Roberts 2025-06-09 3301 } db660d462525c4 David Howells 2020-10-15 3302 ractl._index = ra->start; 28b31a2b2dbfc0 Ryan Roberts 2025-06-09 3303 page_cache_ra_order(&ractl, ra); 6b4c9f4469819a Josef Bacik 2019-03-13 3304 return fpin; ef00e08e26dd5d Linus Torvalds 2009-06-16 3305 } ef00e08e26dd5d Linus Torvalds 2009-06-16 3306 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki