From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA41DC77B6E for ; Wed, 12 Apr 2023 10:05:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7908F900003; Wed, 12 Apr 2023 06:05:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71926900002; Wed, 12 Apr 2023 06:05:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 592D7900003; Wed, 12 Apr 2023 06:05:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 471CB900002 for ; Wed, 12 Apr 2023 06:05:48 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 030A11CB462 for ; Wed, 12 Apr 2023 09:48:23 +0000 (UTC) X-FDA: 80672263728.21.2C8345E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 3E82040024 for ; Wed, 12 Apr 2023 09:48:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Wwk/t3bi"; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681292901; a=rsa-sha256; cv=none; b=EUEAxI3rJpZQLLOstW7L1czDX5Deq01UofCVN549DijFsXnc+8E2Tptj8+A8m/6AMIIVb7 Da38HOM7h6QqPh5diKJmBSi7Zk7gR3yz+dUIuGRex/AMwKvFbEqEj+qOu23MbnskhnO61Q KXGRy/aS28u/lhZ8YMU7ID/GWj/X/EE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Wwk/t3bi"; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681292901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q5VF2Wz5b80hlOD5M0oVoyLk3sVN8nriejQU685ncfA=; b=mLmleshjH5ue9BCxnA0uizINKJyBI8oBAbvGxi/OAT+9flauCAiE2DcF056fajRoDOvygI DIQpSxCqRpVdnpBz34ULFfi5DwIaw+MyioqXZQSpvNgteS3srFyJ0WnEBfcNfbdve6KTq1 jaTOtqK8aOikyDFQTjM5dVKoXODOWAY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681292900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q5VF2Wz5b80hlOD5M0oVoyLk3sVN8nriejQU685ncfA=; b=Wwk/t3biRONWGmGN4cOGgRAiNAaLzm4gFGophDDXMgXFMNAb/bbojCl/RYxblJ8i/L6hEO KfP5wBS6OePNlf5ADOvGDzSl6uK7dInZbelZ0aO14E7CMhbPxFd+44oYhX02VfePb4d8Ep y91D2++ex46QMixKcC23/qVrXmBVar8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-su8sMOu0MRSgpzjf8rPq2g-1; Wed, 12 Apr 2023 05:48:19 -0400 X-MC-Unique: su8sMOu0MRSgpzjf8rPq2g-1 Received: by mail-wm1-f72.google.com with SMTP id n3-20020a05600c3b8300b003f048e0e09eso1032055wms.1 for ; Wed, 12 Apr 2023 02:48:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681292897; x=1683884897; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q5VF2Wz5b80hlOD5M0oVoyLk3sVN8nriejQU685ncfA=; b=MVgLOitUxGdAjcsej4DOc9YZSaoDE7D16oZaUGBQI63kV9TqKqQq3bThRXhbprL16X 9aOPqQ0F5rE+cKPxyzMEV+CtvBostrwB8636RHFvKMD5aqtM04Bz2oR4fqGbtnb1I1F5 1hJzfLNZmQrEM9wL6wp9F7ofHUc9IIt9ixNQFkYyBQpt2GOBlgm8fHM+Ov+ga/Nfmda/ 0aiNc2XK9DiWO0Xj0t+YP833sdqiKFMR2FDb0/ad02iuaI+YBzdS4FWQ8A8f3Ag+Detf fh2SWqwakXuuRx6O90a5hD4dsa2XmAcFv8VahqBpQijp/WImXGgzWRM6v8SaZXL2qlxA GEFA== X-Gm-Message-State: AAQBX9fbgg3gBfpSSeTVdOtGidktfMQALQySo2K3tk8XYt1zl8S8JHs/ AZtVipzXjUJpzfMQLkhPc7HYz/j72sjLcqoFQFSMlgBUsxoMi828rRyBqTSoGQD1TdcRbdqmRbO IvfUS7RXZGr0= X-Received: by 2002:a5d:5682:0:b0:2ef:bbc3:8936 with SMTP id f2-20020a5d5682000000b002efbbc38936mr1593892wrv.40.1681292897710; Wed, 12 Apr 2023 02:48:17 -0700 (PDT) X-Google-Smtp-Source: AKy350aZsiU/uaiPPlC1QybmMrBuigRUyz3mJFz3Bo+72gG1fF1Ill/BaB4OTOK2QwUD+JU828v8KA== X-Received: by 2002:a5d:5682:0:b0:2ef:bbc3:8936 with SMTP id f2-20020a5d5682000000b002efbbc38936mr1593867wrv.40.1681292897342; Wed, 12 Apr 2023 02:48:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4b00:c6fa:b613:dbdc:ab? (p200300cbc7024b00c6fab613dbdc00ab.dip0.t-ipconnect.de. [2003:cb:c702:4b00:c6fa:b613:dbdc:ab]) by smtp.gmail.com with ESMTPSA id j12-20020a5d604c000000b002efb5f0cf44sm12355603wrt.3.2023.04.12.02.48.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 02:48:16 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 11:48:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v1 RESEND 3/6] sparc/mm: don't unconditionally set HW writable bit when setting PTE dirty on 64bit To: Sam Ravnborg Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Andrew Morton , "David S. Miller" , Peter Xu , Hugh Dickins , Shuah Khan , Yu Zhao , Anshuman Khandual References: <20230411142512.438404-1-david@redhat.com> <20230411142512.438404-4-david@redhat.com> <20230411193548.GA2094947@ravnborg.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230411193548.GA2094947@ravnborg.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3E82040024 X-Rspamd-Server: rspam01 X-Stat-Signature: jdut6wmt6uoo9nzqrsu37p1sut833tap X-HE-Tag: 1681292901-565187 X-HE-Meta: U2FsdGVkX1+Yo82X2amsvqEBrFihnTPTzwT4zRekzIsaww8HDoui9aQiiEeC0klt6LZFI8HkGKM6EKBpX7rKnEQ7SUsjYjveRq8KI3GfKQ89NRUy8SXcJqO11cA777OQE1tgLPY9152JI/wfaDto6Fe74DuN70APRHyXatj9VArXrwzparDlfaQdy34cJMA5+4+zgysRY4my++4f6ViwERJW+JmpQM0sIc+ayZ+TtdP744LMNLHkw3i7AimlPg95p3c27KQw2Hltb0gbXbLRLyNpOUTI5OZdkctG3fe1fgP6KgWShOSCnV4TZzPoJ0yV45ZzWJhg2tOGWgPOglTnseEae2W32wsFMJqbp50aiZy3C/yLtScIzOjFy2Xy+gPFeSoOcJTZ5qGTEL5gnNy0ke66rckM6lnIWSxoO07rMHwQBq6VuM8yaKgTx3uDJA16gERB20HAizjxeuqOSwrASHoBeRrtf9/pvYOjGAJmw02El9eSMUM2BykyWb3qIp5JBczIwTz4SRY3m284kVMTL9vozhFMvRoUmRT9UuthzIBAdSNH59RNZPZRVTxRfBb6zG907RYcGUoFNGWySt7BxQEr14b8gQXRZ+YLPyYnaTq/se7JN54VNhe5C4ym8sIbhmeYrQUpiBev7TNlmam2xpyBSoVrx9XKEkzpLIlhlmniVONaGlwFPEpNh16tP6OxYxyG+6jRr2x2ahreVW49n57s3u8+JpDOxV/1QIonBeVGLju8Vgnl/mPwdkXNhHxjCtGCLSTClGXme0j9+cs5jk3sWa/CVKX+J3Uq4Lk7MhQNYeSPqjYIVXupRclIcqC/TwxYsipxWtW8C0/e4nGZ3g5POjj4eTdGi+fCDNvkMzOiOtx2IDMZswBfssrPCt2uux+TTckR2dbqSsUW+v0cOYaSEN2jXSJA4oBQVYZhHnl/NptQNPIYb2tJpJFZX4OBz90Q1ttbciKLhFuawsl uEIf0AXm aSTJB2uMaXb4LJsYGZMTlzQE6Chg5iftN1uKqo00D2NyAuT4aLbth1qlkE58JuPG39gLMdUGRRUx1pEkE7UGCREkaVB4tcgfMj0wuNwaNlaOSwy4B69nFaAzb8xdb6kbCF5rNJavFFiHW3/tSblyhniQcVNk3vW2W2Qkr5CtWbt//6J2HO51jWKODaH/ss21eY/u9UUXb+xoU3iBdSQznDjMavGFng+mbzDe5E1c8RjF5AwpY3VQzTJFxLncucmV22LD/noYXk+nZElLOJ0sivhB5ACVjRbkuhINzv62mGP/S3LSeoCdBiOUKwPRcIykbT65AUtmfY1mfcYIt6XJzhIxPk+K+4mk9+lymBhEkoWt2YTqtkgrR1aVUaiNBaVMPUXuFLiEGHL7tdevOPQOEerk6BUbZfu3mUEwIjHpM/QsMzfTDUa64Dn7eTpzxxavJcE6PoS+ol/3XWiuMVDJUVrfnw0hlspc57s/ITvAO/vXjuoIQ6Q4LyGOWu3x6jtleacifhm6azFZ7dmwFwD8to+d0VSxWkrBTqRYUvcu8+4zJ0j7xm1GXX/6yTkrH9wVfbhO+WjJBPKUfkVS5z0CW7LBmLaSnBaTRjGJx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [...] >> Let's fix the remaining issues and prepare for reverting the workarounds >> by setting the HW writable bit only if both, the SW dirty bit and the SW >> writable bit are set. >> >> We have to move pte_dirty() and pte_dirty() up. The code patching > One of the pte_dirty() should be replaced with pte_write(). > Indeed, thanks. I assume Andrew can change the latter to pte_write(). [unless I have to resend, of course] > It would have been nice to separate moving and changes in two patches, > but keeping it together works too. I prefer to not have "move code within the same file around" in separate patches as long as it doesn't add too much noise. Here, I think it's acceptable. > > >> mechanism and handling constants > 22bit is a bit special on sparc64. >> >> The ASM logic in pte_mkdirty() and pte_mkwrite() match the logic in >> pte_mkold() to create the mask depending on the machine type. The ASM >> logic in __pte_mkhwwrite() matches the logic in pte_present(), just >> using an "or" instead of an "and" instruction. >> >> With this commit (sun4u in QEMU): >> root@debian:~/linux/tools/testing/selftests/mm# ./mkdirty >> # [INFO] detected THP size: 8192 KiB >> TAP version 13 >> 1..6 >> # [INFO] PTRACE write access >> ok 1 SIGSEGV generated, page not modified >> # [INFO] PTRACE write access to THP >> ok 2 SIGSEGV generated, page not modified >> # [INFO] Page migration >> ok 3 SIGSEGV generated, page not modified >> # [INFO] Page migration of THP >> ok 4 SIGSEGV generated, page not modified >> # [INFO] PTE-mapping a THP >> ok 5 SIGSEGV generated, page not modified >> # [INFO] UFFDIO_COPY >> ok 6 SIGSEGV generated, page not modified >> # Totals: pass:6 fail:0 xfail:0 xpass:0 skip:0 error:0 > Nice! > >> >> This handling seems to have been in place forever. >> >> [1] https://lkml.kernel.org/r/533a7c3d-3a48-b16b-b421-6e8386e0b142@redhat.com >> >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") >> Signed-off-by: David Hildenbrand > > I tried to follow your changes, but my knowledge of gcc assembler failed > me. But based on the nice and detailed change log and the code I managed > to understand: > Acked-by: Sam Ravnborg Thanks Sam! -- Thanks, David / dhildenb