From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC62EB64D9 for ; Mon, 19 Jun 2023 07:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E76188D0002; Mon, 19 Jun 2023 03:58:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFD128D0001; Mon, 19 Jun 2023 03:58:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C77348D0002; Mon, 19 Jun 2023 03:58:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B3AA78D0001 for ; Mon, 19 Jun 2023 03:58:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 90E59C04E0 for ; Mon, 19 Jun 2023 07:58:16 +0000 (UTC) X-FDA: 80918744592.30.B5D3BE0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 5C7CB80005 for ; Mon, 19 Jun 2023 07:58:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a9+dgLsH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687161494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vMDHGa3ONVCwUr9Lf2nN/Z0nOMW6v2xOikq6HmR+2G8=; b=rHGeyDPeUzzlSc88hzxrfb6IGKVAqLQjbDlx5B/6yoEEl9T+KYQRKB9qpGBPSJOfceAMZ4 GG/kTty/nn2ujIRhv/EhBsbhVbbsvK1mojSwOyjAUSfuVjEjcnn2EgqqS9zKBmjFhWHB4l VQJlOTM0IycWMID60BGiQf7nveEZdgk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a9+dgLsH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687161494; a=rsa-sha256; cv=none; b=HfNiVN0fnl58A8aGmcLycB0Z67cItYcu88cRXkyy7q3buFCceeBF8A7o5ikozxXUUfxZ1W okkR7tjA8KY9RE1OWh9qdEV+q+xcPSHF/s/rRcboV4vgeRQwCqAKi2fNd+IK87tHEowKua pP5OqtuXeCPqzURrYxtlEm+4bFj/toQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687161493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vMDHGa3ONVCwUr9Lf2nN/Z0nOMW6v2xOikq6HmR+2G8=; b=a9+dgLsHT78fOgHGe8X6/XS+cEDrymiNAiiHLmFeR7ODtBITFNeBvu41eqUDxvrX/hDjf+ ZZ5C28kN/T8pM4cSmB3qC+qVSULxQWVPLH7iy1wuxhFbahdjPb+056pB4MEem2rRBMT5AZ fUjaQmYdalF9t1Z4O7nK/iJ5AjG4gXU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-5SEfToH6MCWv4_ntZ0unbw-1; Mon, 19 Jun 2023 03:58:10 -0400 X-MC-Unique: 5SEfToH6MCWv4_ntZ0unbw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b4577e34fbso17723441fa.3 for ; Mon, 19 Jun 2023 00:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687161489; x=1689753489; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vMDHGa3ONVCwUr9Lf2nN/Z0nOMW6v2xOikq6HmR+2G8=; b=YPcIhtPUIWNmsNxD/SB/5BukELs9s+vW3gDLtsmlklRi98sjNQoWjRfSxyMIEr4LRk n9WfoCSmkF5aozbKEDfQbILLFdNKOlouws6G3xEMOcdysPUSQU3TpDxpLGJfim+UKsG1 hmbR8mqOeZvQH2wW8bRTJr13zKdTYjGy3R/OGWhV/LkuuabJas3/I/n+sAqMQlX0LBH4 lXkEYLzFqkKSw+QHmaTuL8TJeVwLHFDm0J81jejNEz5w2DHJwFEyamcuoMbUPk70ftTi i/jipnkYARuqB7nvNM+Gz0C4AznPXx03/QO7zlPJIqzfFkLBMdWCoroL7s0sgBjTNBZe QXMg== X-Gm-Message-State: AC+VfDz/SvqvGr5Cro0+ednT8eTaCf29dGVNrx5bfuMWtqWvHnvjXiJi W0LO+OK+TyJ4otZyl4L2VHgTSYkOGdCLaLqnNde72QPCeWuRl0QMN7E9PnoA6ICm5XMdMc9tKTM hMwrO3lSVCsk= X-Received: by 2002:a2e:958b:0:b0:2b1:a4c2:70b4 with SMTP id w11-20020a2e958b000000b002b1a4c270b4mr6023708ljh.30.1687161488881; Mon, 19 Jun 2023 00:58:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5FnOizUXoEl38fR41JSoXqWJWGlYgDvNGKxNCmNCxpUGoBO1B+8UDvbrq9lR0hl2t3joYAEQ== X-Received: by 2002:a2e:958b:0:b0:2b1:a4c2:70b4 with SMTP id w11-20020a2e958b000000b002b1a4c270b4mr6023692ljh.30.1687161488502; Mon, 19 Jun 2023 00:58:08 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:7100:cede:6433:a77b:41e9? (p200300cbc72f7100cede6433a77b41e9.dip0.t-ipconnect.de. [2003:cb:c72f:7100:cede:6433:a77b:41e9]) by smtp.gmail.com with ESMTPSA id 1-20020a05600c028100b003f90a604885sm4743922wmk.34.2023.06.19.00.58.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 00:58:08 -0700 (PDT) Message-ID: Date: Mon, 19 Jun 2023 09:58:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH 5/5] Revert "mm/migrate: __unmap_and_move() push good newpage to LRU" From: David Hildenbrand To: Yosry Ahmed , "Huang, Ying" Cc: Andrew Morton , Yu Zhao , "Jan Alexander Steffens (heftig)" , Steven Barrett , Brian Geffon , "T.J. Alumbaugh" , Gaosheng Cui , Suren Baghdasaryan , "Matthew Wilcox (Oracle)" , "Liam R. Howlett" , Jason Gunthorpe , Mathieu Desnoyers , David Howells , Hugh Dickins , Greg Thelen , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230618065824.1365750-1-yosryahmed@google.com> <87ilbk8b89.fsf@yhuang6-desk2.ccr.corp.intel.com> <9f53b80e-7083-705a-88d3-7f3f33dd9c4b@redhat.com> Organization: Red Hat In-Reply-To: <9f53b80e-7083-705a-88d3-7f3f33dd9c4b@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5C7CB80005 X-Stat-Signature: 4tbof9k8zqn3wsj9jsracicywdd5do9s X-Rspam-User: X-HE-Tag: 1687161494-96302 X-HE-Meta: U2FsdGVkX1/3hy0C13cVUzjNebFdHym9pmzIYgW8TfInIH/ANinAH2PUcpIG+bGxpj969xQhiyqEdcUaV0n4t8egWTGJdpQD/v4gWwEHzViDKmEmH062NCUIrF87PEcACs07BGPJTmyvSRaNZYTJEtza2X7kHTtxx83HbCMRacAjbct9M1DkUyvhu0pxIyhhgucpVjE0Xh83PcdpXBrm7CFG1R9Ls7y+YB2CmrN2PIiA7tXbz7CMvddCpyx+ly8fXBUlY42TI8f0OmeH7JPriW7MFbWs1yWPq4Zv5y1l8Hv+CEV7fJ/+kqGDdjiU1zsZcmh2AMdfTSG8BakMi4eP5lmTrE5kPiAqgl/ASNHXqHJxLdIu36jMrVQxs+WOOqnoXXK0JLW3tpzbpfN+Z4G941iWurIcoiwE3GJwIUdAeKblaUM8ZyYx3SCwpiuyt2ZWn/xpzcVoqRvp/qyFI2VRV7oiZUsze1cW8TmX4Rs68HiPvEzPEt9mCpMMiJc7J5Fx3pKWvjRHZgg9CCdkJlrT1oidCoHnz/4wlsWRxDJYLk0VXpXUvXYEu3A28cwlAwY0WEp10uaEjxy4qU6iciExiRJp6W0KTgabaSMOWdCjt6/IvU6L3nUHtmK53oxffR9cXZornpazn4x3qP+88cjuOdaf7yoS988YdTDi/o2beFlMpDQIJPWMAE99rGc4VWug36zd7ZVG+A+i+zSTotFV+7Bi+ybCVWUptCQ4RcaC0nxMksZGAdHrFQWg584up0KyH5TvGGgJu1uYWdOgmqVPIys4sjoNzH0VUC9id9BSpXAkx5u5/63m+pnsEfndEv1eaO5RzLRdxO4FKYPr8oE/THKM553weoD6iyzaj0xIh47Ffwjupn/shTwKsG/mg+tE/sf0e6bsQnXPPJcwk1ZuA9hJ3K0vhyO4Z/2gsG7pWWx7LSbv7hilpZ3qoaGQaM/uKQSUuDm2jiWhg/Xjzaf eC/+spsr EE5eEqlJMoT/ObMMgo046kWA49kXwfKPSxHA18wVorDOl9D4pED9GjsltNU6+P8EaFfgBAQaXczw5L7gfhwMr5+0BARkAN8fFW38lT7MEor4/hayZRbU4Zguhzr0obBIcjx1G4e3KCF5OKWNXXpIHiUiVwaUe20hI0OdeV37FgCr5EYxp8xgoQ6ePk3zsz9Zp/TZeO0sCHKviUAsnqBhz2LTOHBTQnvFloTd0Axdj37n8YJY4wrJBUNd6TRSOJteJGcSdHsZvpbSqxILuOY0318gXWFwORPSX7/M2spENmnqfqR2amOox4ul+EaD+hUyru+5X2fBFjjs4aOEd5epP/u28F4p6AXQu6zpmzt6YKt1kTlRSrVa642vsOdLQ66eITe4B3ZYrW1D+2PWZUydCiRMya3HRkSNCk9p37pj6ALL8nC38/UfIrFExWG4/pN3XDst9PwJzXTbEBn9Lve0RBKj+3piDzcGixpDi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.06.23 09:56, David Hildenbrand wrote: > On 19.06.23 05:59, Yosry Ahmed wrote: >> On Sun, Jun 18, 2023 at 7:00 PM Huang, Ying wrote: >>> >>> Hi, Yosry, >>> >>> Yosry Ahmed writes: >>> >>>> This reverts commit c3096e6782b733158bf34f6bbb4567808d4e0740. >>>> >>>> That commit made sure we immediately add the new page to the LRU before >>>> remove_migration_ptes() is called in migrate_move_folio() (used to be >>>> __unmap_and_move() back then), such that the rmap walk will rebuild the >>>> correct mlock_count for the page again. This was needed because the >>>> mlock_count was lost when the page is isolated. This is no longer the >>>> case since mlock_count no longer overlays page->lru. >>>> >>>> Revert the commit (the code was foliated afterward the commit, so the >>>> revert is updated as such). >>>> >>>> Signed-off-by: Yosry Ahmed >>>> --- >>>> mm/migrate.c | 24 +++++++++--------------- >>>> 1 file changed, 9 insertions(+), 15 deletions(-) >>>> >>>> diff --git a/mm/migrate.c b/mm/migrate.c >>>> index 01cac26a3127..68f693731865 100644 >>>> --- a/mm/migrate.c >>>> +++ b/mm/migrate.c >>>> @@ -1279,19 +1279,6 @@ static int migrate_folio_move(free_page_t put_new_page, unsigned long private, >>>> if (unlikely(!is_lru)) >>>> goto out_unlock_both; >>> >>> The patch itself looks good to me! Thanks! >>> >>> Reviewed-by: "Huang, Ying" >> >> Thanks for taking a look! >> >>> >>> And, it seems that we can remove the above 2 lines and "out_unlock_both" >>> label now. That can make the code simpler a little. Right? >> >> I am not familiar with this code. If we remove the above condition >> then pages that have is_lru == 0 (i.e __PageMovable(src) is true) and >> page_was_mapped == 1 will call remove_migration_ptes(). This wouldn't >> happen without removing the above 2 lines. If this combination is >> impossible (is_lru == 0 && page_was_mapped == 1), then yeah we can >> remove the above condition. >> >> It looks like __SetPageMovable() is only called by zsmalloc, z3fold, >> and balloon_page_insert(). The former 2 will never have those pages >> mapped into userspace. I am not familiar with balloon_page_insert(), >> but my gut feeling is that those are pages used by the driver and are >> also not mapped into userspace. > > On XEN, there is xen_alloc_ballooned_pages(), which ends up mapping > balloon-inflated pages into user space (for something like MMIO IIRC). > But the XEN balloon does not use the balloon compaction framework, so > __SetPageMovable() does not apply. > > The other balloon_page_insert() users (VMware balloon, CMM, > virtio-balloon) shouldn't be doing something like that. Ah, and I remember they even can't, because in balloon_page_insert() we also do a __SetPageOffline(). And such typed pages cannot be mapped into user space (because the type overlays the mapcount). -- Cheers, David / dhildenb