From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21299CF9C68 for ; Sun, 22 Sep 2024 07:53:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C9DC6B0085; Sun, 22 Sep 2024 03:53:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77A656B0088; Sun, 22 Sep 2024 03:53:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F3FA6B0089; Sun, 22 Sep 2024 03:53:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 446816B0085 for ; Sun, 22 Sep 2024 03:53:28 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 09EE71605F4 for ; Sun, 22 Sep 2024 07:53:28 +0000 (UTC) X-FDA: 82591609296.02.C03371E Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) by imf05.hostedemail.com (Postfix) with ESMTP id 01186100002 for ; Sun, 22 Sep 2024 07:53:25 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=WTg4SCK7; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="c k9fR1v"; spf=pass (imf05.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.146 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726991547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QtaWawvvQ39ZGWhwZAM+wk43O+xWu43ctkOGufDANlo=; b=i+Jg3kaG/4hvc8oMOvmCmoMxeY+7xAg3ex7G5Bzpx7A+xscUMOpO/soKXH1/svouMM5d5u samQtY7WeRjZYBCtBJidguiRSKockqY6wF3q6JUzUXxlz/ZIjlhiTo+L2dnmAVIMoZ0A0D pZYVWaxtwA7ku6bT+rCNkrRFIahXcAE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=WTg4SCK7; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="c k9fR1v"; spf=pass (imf05.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.146 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726991547; a=rsa-sha256; cv=none; b=dY22Z6/GgllOkxiM6Zo1ocK1pWjQatMoOAz5oUJ5f3jN8D3ZzoGI+4UyDSQSoWJWat4YzF QYtsTI+qBG67XHT6eriFAY8vA0h42+VGlPaTSM9h/cwhygCyaAzTWiQAwd106asuaVEgV1 0CvzHFrvVJ//G11SB48KjwSiycN5a6o= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 23371138025D; Sun, 22 Sep 2024 03:53:25 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Sun, 22 Sep 2024 03:53:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726991605; x=1727078005; bh=QtaWawvvQ39ZGWhwZAM+wk43O+xWu43ctkOGufDANlo=; b= WTg4SCK7ZKahfqfM7lYYiEhNtnIT0IibS25Lmi3UMz0l+2y2dAGGeMnlK2t8QiVy EybR2vMJHg3SLiTlUlx5zTE2wE+pEwvVsOFZFVFiy5wZXRmZ9en7886qHfvcRYyE NccWP3g7D/QTiGby+/yywFDH77VWh3CgdGH2qF/G9I0LseT9xxPGDWqRRZPcLaKM z9kw4rOWEH+knInCrC/Tw65c4VNVgY/knK/v7RR4CDZ8dkqv6DwuA/MsEyDAwXfv ub+ysd6CjEJPvpwgiSAYEXoQy4yfwd14kdAeSJcfWw8Cg69AuddDnVU0qH5N6aGy TtiPUOyQ5LzlBKcePhlyyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1726991605; x= 1727078005; bh=QtaWawvvQ39ZGWhwZAM+wk43O+xWu43ctkOGufDANlo=; b=c k9fR1vAujL8EsBM/M/jMAiGA9sgre59FmPS2yUud9KMxJV23y55+sL/YArc+CPIL nCZqYm++XJU+1WkpjRRCAYBiGDxI0DZh7dZl4MpGrakzyjP3RZ8G+uDvtlcumbZx nUyIc202eBe7enpc5rwLr8ZojRcEcnSl36yN0hkWpye+rxCdhG0yLtJMmdRmDDvx /F7WxqY5UlxgxFezlCIKYqSaGQPNmR5Cri/O67MMID88jgouh76zjhT+D96adPBK +zgg9yYiRk4jiAES0Mh4nYAbVYBzCjYHDVP447gh9Gqm/bj5TQx9U94u+XoDryDs yVIy4weu5Sm0D/3/fpgQA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeliedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpeefhfehteffuddvgfeigefhjeetvdekteekjeef keekleffjeetvedvgefhhfeihfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegr rhhnuggsrdguvgdpnhgspghrtghpthhtohepvdekpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopegrrhhvvgesrghnughrohhiugdrtghomhdprhgtphhtthhopehmrggtohes rghnughrohhiugdrtghomhdprhgtphhtthhopehtkhhjohhssegrnhgurhhoihgurdgtoh hmpdhrtghpthhtohepkhgvvghstghoohhksegthhhrohhmihhumhdrohhrghdprhgtphht thhopehgrghrhiesghgrrhihghhuohdrnhgvthdprhgtphhtthhopegrlhgvgidrghgrhi hnohhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepsghoqhhunhdrfhgvnhhgsehgmhgr ihhlrdgtohhmpdhrtghpthhtohepfigvughsohhnrghfsehgmhgrihhlrdgtohhmpdhrtg hpthhtoheprghlihgtvghrhihhlhesghhoohhglhgvrdgtohhm X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 867632220071; Sun, 22 Sep 2024 03:53:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Sun, 22 Sep 2024 07:52:34 +0000 From: "Arnd Bergmann" To: "Sasha Levin" , "Alice Ryhl" , "Tariq Toukan" , linux-rdma@vger.kernel.org Cc: "Miguel Ojeda" , "Matthew Wilcox" , "Alexander Viro" , "Andrew Morton" , "Kees Cook" , "Alex Gaynor" , "Wedson Almeida Filho" , "Boqun Feng" , "Gary Guo" , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Greg Kroah-Hartman" , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , "Todd Kjos" , "Martijn Coenen" , "Joel Fernandes" , "Carlos Llamas" , "Suren Baghdasaryan" , "Trevor Gross" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, "Christian Brauner" Message-Id: In-Reply-To: References: <20240528-alice-mm-v7-0-78222c31b8f4@google.com> <20240528-alice-mm-v7-2-78222c31b8f4@google.com> Subject: Re: [PATCH v7 2/4] uaccess: always export _copy_[from|to]_user with CONFIG_RUST Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 01186100002 X-Stat-Signature: epwm15u3w915f3jc4bb3pfmxrtsjqmy4 X-HE-Tag: 1726991605-505985 X-HE-Meta: U2FsdGVkX1+rO6dZaa4p5M2GpBw0fLpbq1/qlbC8l6RnpmVRtRu4UX2F06xJ3RzQO2Ywo1vFewnexrAWW6UlEG+PxIO8qHG1JHAbGiN24GIEEAdHXZQwpYSGc2pBFroRaMOs+POv1noW/2mYsXK2myF/8tuVKBs6t1hh+kIFynxt1zXrWzLAoWPP9NTBCPnwhGtTlACNYj956gJmLH7bNDgPBf2iH+C89e5o4OoZhErO4hjkImUBJ/VxdVuCgOwANsv2e+gUrNwAkFlZtBHOjUN6BR31DCbnr+u6CiDR5EVYHY8xEdle+wri9I7MyOBqRdVYkR+CnkWVmzuqd3WNuaQ3K8XucpppCZUh5q6hdivJ4FdvHptaT3uZdikhd16giDOKSDFGXD2O6+6XHsPZMNCG2ojQ/h5f3QyY5jB9vPQkLhTZjiXStZizpLfHA4XFT/bZeEJiCqdY8Jz+h8xFuhrgHcO/IA08ZWUvxWJ81kcrtPwU4gvGDkAaZr5RDeWRqUv0UmcW1wVw/6JMAGuK0qlGaniMxSZ1YF6oNkS53yXfBe+bKSQt+4X82LiWu3CshdbzeXSYOkPMq7Kcox5fNM5GY5n0d9kB+KUOE8LQr7Y0FvFv6zb7M5s7rOS3WZHZwcTWGpyR/1MncW/pjT6KKBaIZHGj+XcQ7CNjkQDpFsn4Su44ZAwXkoDXYef2NkCj1mBKnEFfRDlmlaZveORvPw4iKGfczcdvVTw+AqI2ObqmBMTYoflihiCkcUJbQlc9GUX02e5PA6E7raL7wm/cR0Rmhi9/2Eh9DttnU3ME2GeGWEIOYXNtuthLH2E1MhfdeUwUPLkWRJYm2cMmy/MhyjLnjQIkgBWHLSQ7ATK7adsfjy29MVuv1K19KCFTE9/R4gYgznra4onDFoqML29RCJyIhBflS2cH6LUvXhKznbiqZhlkIlyikh8AUEt8ImTvdcJzO9ec5N74wsWmlyX h1KoF0a0 7wLNmveI1DR7j+z7BSR+ZJNm1IvoAPNM5RL311Sl1q3UWMDlhnn1ttBcwzBv28qlbuF4bj2nm+bNhh5i83yTHDpYF6LvmT164fN/wxBYiMjq0fvd+g6p2Ofr++fADNpBk310R1Uvm04KQdedtIkw2zpY2VLBzlBz97ZBwbz4uqya4btJXcIWRBJqUDAAvhMT/YL0gfY4ygsCPa95JNWRNyYVrZ7OtIT/6RN85KgXZNwSkVwTUxlaar8asSMNZZP+qdOMELmhb+z5JRCTSoaOvupH0T8yc2DhB0NqpfUkKTuud05eKUuiUcis0N8Y+YhqDKqiIBr5j4B18iDo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 22, 2024, at 07:08, Sasha Levin wrote: > On Tue, May 28, 2024 at 02:58:03PM +0000, Alice Ryhl wrote: >>From: Arnd Bergmann >> >>Rust code needs to be able to access _copy_from_user and _copy_to_user >>so that it can skip the check_copy_size check in cases where the length >>is known at compile-time, mirroring the logic for when C code will skip >>check_copy_size. To do this, we ensure that exported versions of these >>methods are available when CONFIG_RUST is enabled. >> >>Alice has verified that this patch passes the CONFIG_TEST_USER_COPY test >>on x86 using the Android cuttlefish emulator. > > Hi folks, > > I've noticed a build failure using GCC 9.5.0 on arm64 allmodconfig > builds: > > In file included from ./arch/arm64/include/asm/preempt.h:6, > from ./include/linux/preempt.h:79, > from ./include/linux/alloc_tag.h:11, > from ./include/linux/percpu.h:5, > from ./include/linux/context_tracking_state.h:5, > from ./include/linux/hardirq.h:5, > from drivers/net/ethernet/mellanox/mlx4/cq.c:37: > In function 'check_copy_size', > inlined from 'mlx4_init_user_cqes' at > ./include/linux/uaccess.h:203:7: > ./include/linux/thread_info.h:244:4: error: call to '__bad_copy_from' > declared with attribute error: copy source size is too small > 244 | __bad_copy_from(); > | ^~~~~~~~~~~~~~~~~ > make[7]: *** [scripts/Makefile.build:244: > drivers/net/ethernet/mellanox/mlx4/cq.o] Error 1 > > I do not have CONFIG_RUST enabled in those builds. > > I've bisected the issue (twice!) and bisection points to this patch > which landed upstream as 1f9a8286bc0c ("uaccess: always export > _copy_[from|to]_user with CONFIG_RUST"). > > Reverting said commit on top of Linus's tree fixes the build breakage. Right, it seems we still need the fix I posted in https://lore.kernel.org/lkml/20230418114730.3674657-1-arnd@kernel.org/ Tariq, should I resend this with your Reviewed-by, or can you apply it from the old version and make sure it finds its way into mainline and 6.11? Arnd