From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD254CF9C72 for ; Mon, 23 Sep 2024 15:58:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CBC86B0088; Mon, 23 Sep 2024 11:58:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47C6A6B0089; Mon, 23 Sep 2024 11:58:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F6066B008A; Mon, 23 Sep 2024 11:58:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0AB246B0088 for ; Mon, 23 Sep 2024 11:58:09 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B06D0A120E for ; Mon, 23 Sep 2024 15:58:08 +0000 (UTC) X-FDA: 82596459456.25.2B8A590 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 6527F160019 for ; Mon, 23 Sep 2024 15:58:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KsBeQPTI; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727107051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IQW6jYo1TmEyBClA+qYPmkjul1GxgALcX+WvqrvOp4I=; b=DJe//IgC8/EHzhnkAR+4OcHnftdxxgqwgkArPpi60jF35lLfUo4KgRjF1Zf+7nJrAcDlWv mSsi83xzkwVSnmpR5/hrqSTuaweF9k6PztI+uz0O5PA7Pri5LOXq0pa1Qd86kjLr4Zr2Y+ eBW8LjyHxrxuUz89wX/W1MT2dxnqglc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KsBeQPTI; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727107051; a=rsa-sha256; cv=none; b=wOT3HPwAvZ6HZUbXygUiHwPlq5PrJ4zOLzgoQBXiCVNIhdan+EIP6yXQaZXbD1J1XiWTHu ivaNtKSl47WofTj1G54PtcbKJ4BPu418zvnPg1P5GdLVTqBWt6Kavz5Zq1tF2WigkEi4ZX n29k0vSFD0uaTjnllo/CtkpTDl/iEww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727107085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IQW6jYo1TmEyBClA+qYPmkjul1GxgALcX+WvqrvOp4I=; b=KsBeQPTIxyXYLVlFGTrfkV5XXUwRmdP8ubTPozP3jyS9AOB61bpXhQSexNYKsQMmpJ56/o oIMjYQXvmMZWfcyrNADtViZqbIbxTfMyf9AndKgRf4wh7PJYmUw5Aeetc0zeC6/Ul5II67 RJZZZYxC19xe1hVmFPkFrhbmdEibdOQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-MRub7UeVNkqaipNHxubKgQ-1; Mon, 23 Sep 2024 11:58:04 -0400 X-MC-Unique: MRub7UeVNkqaipNHxubKgQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a8a8e19833cso395330766b.1 for ; Mon, 23 Sep 2024 08:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727107083; x=1727711883; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IQW6jYo1TmEyBClA+qYPmkjul1GxgALcX+WvqrvOp4I=; b=bb7S014iU16y5HWZG9t78p84sUC+TaaR2z6fLqUUKZb7C17vC79umv8UvyYgOjlaW5 YLt30rBoL/kBdx18kwJyn3CeFdGVQhWaQg6ozKUVRYdFX/h0B45aAg+1dsOVAxwVLTk0 ijQ31yxilfbOLNH01sihbJvkwQFPSujwsHUdBBNp4+YmqJOa02wQfqXC3Dl/yJzP86fv y/z8CsyQSljzByJ/lUyVfkFLlBT+5VztmxAj74GPrbNPFi5T8JAF4ND8h9s0ZBGdrLiP m9u+cl3dmQhAHBNLdWkPIb8H4arEhZ3WWJKyedHFdLkCYg+ZXgv7h2Wulc+da81S1y8u uVBw== X-Forwarded-Encrypted: i=1; AJvYcCXys83SW2nppqhIg09T15L0AIlId9crMWhqamBdAFVK6A468QnsOmkcSyHzL9QwftpkoNMAVlR/IQ==@kvack.org X-Gm-Message-State: AOJu0Yyb4dAc94/PXPIR2UCWKtmMU2aEsh1l5+AtcCIMKbwAIokyHMkC kZ+w7QieNBbxOg34rIWj3Rl2nopBJd9H213elIeLVSmEhTbMUpSk1U2ZTkJJwwCvqhwdKUQTgOe n/cKUsRRdVlEEayz1qxTkGKIVST1lndOvgymkIkwrwFQ65862V0c+kBuvhjs= X-Received: by 2002:a17:907:ea0:b0:a8d:2ab2:c99e with SMTP id a640c23a62f3a-a90d517ba30mr1166123966b.55.1727107083322; Mon, 23 Sep 2024 08:58:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBYM6QH5uM4//ce/JZhDdTXvgUZQmlWuoAMw7bbi4DwT1sJpJIrPB+Bh1jNV9WmFmzCdIUaA== X-Received: by 2002:a17:907:ea0:b0:a8d:2ab2:c99e with SMTP id a640c23a62f3a-a90d517ba30mr1166120866b.55.1727107082892; Mon, 23 Sep 2024 08:58:02 -0700 (PDT) Received: from [10.5.48.152] (90-181-218-29.rco.o2.cz. [90.181.218.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90c39cbceesm632353066b.132.2024.09.23.08.58.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 08:58:02 -0700 (PDT) Message-ID: Date: Mon, 23 Sep 2024 17:58:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: shmem: fix khugepaged activation policy for shmem To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, 21cnbao@gmail.com, ryan.roberts@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <9b9c6cbc4499bf44c6455367fd9e0f6036525680.1726978977.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9b9c6cbc4499bf44c6455367fd9e0f6036525680.1726978977.git.baolin.wang@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: r7z4xypkr98srzjznjcrftxdy6tqu6u5 X-Rspamd-Queue-Id: 6527F160019 X-Rspamd-Server: rspam11 X-HE-Tag: 1727107086-563210 X-HE-Meta: U2FsdGVkX1+LAPqKv0BRW//sLKZt2i933E1XxBM2/DYtul4R7C1pC5FkZQfmMscPVSqIjxUcl1ugYMNmVpUZKvRRDFsuZP6ESnd3UekNJEzKWu0rHW9ZiOoBOmYRTA4rCO5y20PRWHHUZh11BXjpO+tnhLDSHtnnpn4NVObf3+9Povo7fS349NtTfau5SfCeG0UTtQWng2p1Ul2mgcO/HRC+0EnCxD+RUlMZ6lPk4YUoqQ9Ifef2rXyMlsSxU6DHHm7GJdIJng94zlSD93dzJAjjocSxYkuP0cJ8EamHE83DX4wFK+mcwBEB6PfckOJd9GD3PioHU034bOXX1QuGnzfC7nI+wVSYlmXDlfA6mKuBbi3iKFo9CcVfqbMCnIsaJ5YlI1QXzLuAYFeswIbU1jOwYzcijsjtcwdQ8+5BAw8uwTGdnoviaOdRNI9GkyVzrPsFJ0ApCr83p6HRoCXSiQ+xm1wZ+MnPWEBow0EEDz7OA42ywLx+BH4Hj3jxYkP+iezs1dWvDwOqGpuOTPQKFRvXDXR45GHnpKtVgOyGi41vW7Ku5ys1UTpEiRVl1nqw56a8mcal4XkltI8ONOsFjdsX9omHi/f4cqhB96cfJl7/+9JGSogyRiIx21xROE2lGzcO2SMPY+0dNyEobJi/9eY24IP50+8wwf7EP5/jrw0hVxHCSAOpZusK6nO9SCNHgMqGCHX9g4XRBnYhJRhOChnFNkqs5Hz8buM/nkWTHEriIAmCk/jhqQja+6O9cfG72cOLgQgomTKLZHtsFDTWtpWnXT2lm80j3nBC0ruxsyRhXFctPffzMQUYlpg5Yx5x2UUGPEISKTJEg/YK8145P4F3AlHFl2MjFO/0CkYzsrMH9MpGMU+U4D0z9OYQp4k1UmjBoFMPX6G820Tw3J3XPGogQ2jKvzNDExgZOs5p0oZyp3oJhwVMJait0nhm1Jt6QVXHWRqOscN45+MqMPF 0e7D2mlb JxkfeV/8RgSjgaK2sBC9DT4dMW4L+NkxxroRn8KK94N6jwAcoGsQ6WeffXIVsCnRZOccETKJZEaUQ+M8UlM7TGXSGERoLZfebq0841r0d0dKTsgrGJ7JaC+bffhcx/9+UQhR+xLG8vaj3BHJ/iPI+MRaDSbbBfUKiqIvqlqRAABXhoB5/c7AMq+RXtZD9TqV9tIzs7O7UWVhsHCAcCSPl7iz+k36Fb3aFZeUXIG2mWclVqc+AF3caH04csFSxsyzYCV8eV8vQBlPrFL6+5PIL7wgozV0ihUAag4ZXIvfloJz66tN7hjhK7cUkLmYiwj79Et8FTP3fSTccyHT7SWsT2iCVPpPuRGLJTgeu6D2x49MSH5tfi/NWE/xltn4n0lj8gpwCp1uDgQNUUI+wVg5Sw1JV0VfL9jh748ThM6rG0hpa0fjPJ7LCzQpYXiQrE0k32NFuC3Xvb6zaAckRwc7yUsryAdh3NBtsGmrdi/q83tHzyImqJL/VPqKJb3grFENTmb1NjH4yCQkjNuI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.09.24 06:32, Baolin Wang wrote: > Shmem has a separate interface (different from anonymous pages) to control > huge page allocation, that means shmem THP can be enabled while anonymous > THP is disabled. However, in this case, khugepaged will not start to collapse > shmem THP, which is unreasonable. > > To fix this issue, we should call start_stop_khugepaged() to activate or > deactivate the khugepaged thread when setting shmem mTHP interfaces. > Moreover, add a new helper shmem_hpage_pmd_enabled() to help to check > whether shmem THP is enabled, which will determine if khugepaged should > be activated. > > Reported-by: Ryan Roberts > Signed-off-by: Baolin Wang > Reviewed-by: Ryan Roberts Looks reasonable, thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb