* Warning after "enforce overlap of memory.memblock and memory.reserved"
@ 2020-12-12 19:37 Heiner Kallweit
2020-12-14 8:06 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2020-12-12 19:37 UTC (permalink / raw)
To: Mike Rapoport; +Cc: linux-mm
Since 950c37691925 ("mm: memblock: enforce overlap of memory.memblock
and memory.reserved") I get the following warning (on x86).
memblock: reserved range [0x0000000000000000-0x0000000000001000] is not in memory
memblock: reserved range [0x000000000009f000-0x0000000000100000] is not in memory
According to comment "Some architectures (e.g. x86) have reserved pages
outside of memblock.memory." it seems there's nothing wrong with it,
then why a warning? Wouldn't debug level be better suited?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Warning after "enforce overlap of memory.memblock and memory.reserved"
2020-12-12 19:37 Warning after "enforce overlap of memory.memblock and memory.reserved" Heiner Kallweit
@ 2020-12-14 8:06 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2020-12-14 8:06 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: linux-mm
On Sat, Dec 12, 2020 at 08:37:49PM +0100, Heiner Kallweit wrote:
> Since 950c37691925 ("mm: memblock: enforce overlap of memory.memblock
> and memory.reserved") I get the following warning (on x86).
>
> memblock: reserved range [0x0000000000000000-0x0000000000001000] is not in memory
> memblock: reserved range [0x000000000009f000-0x0000000000100000] is not in memory
>
> According to comment "Some architectures (e.g. x86) have reserved pages
> outside of memblock.memory." it seems there's nothing wrong with it,
> then why a warning? Wouldn't debug level be better suited?
I think that this is wrong to consider memory reserved by firmware as
"not memory", hence the warning.
Anyway, this patch needs an update as it breaks arm [1] and maybe other
machines. During the update I'll reconsider the printk level.
[1] https://lore.kernel.org/lkml/127999c4-7d56-0c36-7f88-8e1a5c934cae@collabora.com/
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-14 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-12 19:37 Warning after "enforce overlap of memory.memblock and memory.reserved" Heiner Kallweit
2020-12-14 8:06 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox