From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEABEEB64DC for ; Fri, 21 Jul 2023 15:56:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C7B66B0071; Fri, 21 Jul 2023 11:56:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 378326B0072; Fri, 21 Jul 2023 11:56:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2183C8D0001; Fri, 21 Jul 2023 11:56:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 12ECC6B0071 for ; Fri, 21 Jul 2023 11:56:55 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D8DFDB147D for ; Fri, 21 Jul 2023 15:56:54 +0000 (UTC) X-FDA: 81036072348.19.9DA243F Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf08.hostedemail.com (Postfix) with ESMTP id 2D3F9160010 for ; Fri, 21 Jul 2023 15:56:51 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CJkbqJss; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf08.hostedemail.com: domain of xiaoyao.li@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689955012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u2QTvHpsphu6fVKinaQ98USt3OI1DUIGOu0ZYUs8Xws=; b=bHKfvuZGi9m+3UfL6mbgxG3PrFn1mmxJCs13VlcbLXiZnlLO1v7cUihJFKV5HVnTmcpkyZ YeeNvbDisXrlCja5jPO5yfbf/vrXEy8eZjpkmhjGbhan64HOJ4SGIbSY+pmpw53PXsStyK Bh90xHEALIHuiLhfP3SWlA4HHy4F0zg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CJkbqJss; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf08.hostedemail.com: domain of xiaoyao.li@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689955012; a=rsa-sha256; cv=none; b=yirMZnlfviL+Kk7+73beNtNKnDZD3wPdjojHY7qfH1TYyi4nD/NpcmU+Flhp/VYPUg2Fmj RKP3pxNT8Bzp19utDSqGRcNEyX1L24w86GJWgcdvU5eyjFkllrYrrYatil0vY9J12DKdlU +ErLeQ6S+9vIbhsAwrjbok+CZ96/b1M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689955012; x=1721491012; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=JA5Qpp5YniYsJOdvvzjD9DRgmiiQbKmX74OklM/B+X4=; b=CJkbqJsscNPEv6tBA3GELz0OORkDYvyWwY1GXwjyQlZcSnkgbQt8VvSC k1G9VARqDRlhAnSd2Evqo7IpQfbnKsmuXTVuyYQhf9sUnIJOx/taXnUs/ pfFoiP7sU4yMhJed15rRIb+GxoIEz6sz/MJsLD90oDq3/r0f3YTQSGpO8 ByLosH+MzfoayQymrGvSrSBQdUTbKiW0rrZZYrJUxKtlWqAIOkXdYpVWB SCMHkTfn5HJbTl7lXZKpmdjTsFRvhfQSyiTrdsEBIOHk+ikrt0FbllV0E M0r+vemyDAOiX8vUVZUWFNfDYdYYXjocXVJg8TDVoBXtixL0FqgUTVz0j A==; X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="351933276" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="351933276" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:56:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="795008982" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="795008982" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.6.77]) ([10.93.6.77]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:56:40 -0700 Message-ID: Date: Fri, 21 Jul 2023 23:56:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 08/29] KVM: Introduce per-page memory attributes Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-9-seanjc@google.com> From: Xiaoyao Li In-Reply-To: <20230718234512.1690985-9-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2D3F9160010 X-Stat-Signature: dnsosj53hipfjcweftmufnit4osdnc7b X-HE-Tag: 1689955011-60540 X-HE-Meta: U2FsdGVkX19xqE3Z/9Gs+Z8G10/269uw6CsI5zgMTuNt/mZAj4QxMDzol0Zf6CpOM6+ry8KupsJY4ovp6JEpYOZ1TkeeN6WBa2gPS0qCcUKYwLKodiKPKAefqHO0GJRgDaluy7rZXmkhedJ5435/U9yE/OFMqGABT9SMGJH2EKzNq4bqFZs7s2z5E5kyrV7hPuF18CklznXmCS8/3X0h901W6XkdZtNsS8LbH4ivW74c4/+X2Yd3Qq9wY4v2NhCzbPZlDur8EAzd49ZmOPuJp0NCeUT4+/B/z5Ay0dYTmqPwXS1R3UcTVh36eboSmf9zSJGWdusI+kOzDNspCgCukGh4ULODDIXZomn1i6Ez9ETwJUZwinToC1PCSJOG6NONbY5PTYPoWTWTP7y8ufHhBghqeonPLQT/sX6HTHv19B4M0K9tHHsmSmESbyffqvMsiZPCDP8R2k2C7iB5WYaw6bfSyytanS/TmCH6iSH8jJTXIR7LFSICoFOYlHmvy7G2wduS2fH4MnEcmresfBcoW7PPcWUfU+LSRfCaPJ6ST5hAA7Bi8J7qJ0WAyXILOy1zQGoXD+Xg752fXsGA85jGzjsVWcJVAtVdV/vlEXotqT7au11+E7jCkJJ38nC1ayQwn6l/cKKnXnW5Fyyo7A/V1AbvbB0SSjBKDnXtYcdRuvbA0vVcjBiW18DIiHwO9GsUgLwZ3WI/usHMi1gbFQgPEjp9hFKIEOw8Fp0F2ZWzY4GZCjNZ0isIAtSeFxtg7auYfoJL2ZL/zIjHf41olycDyeJ0QTY32HZa4N42YochcLYoqND7DNUY5zfITXpp+wenMvo1oAhCMlfE5QyZC7k4Dc5zvoolED0BW5/MvCYj4FAJ0ZkQu7/FS9mSjN2YwNB+VKQRXwmOgGa0j+2xhyHDzQsd80EPv70PJweOoXucpmKRNaW5Rb9JC9LXGdTFl3yLuqlL9eDmvKDs0L+dVal AbbkGJUU NGC2sg7DAMGfRIJOP+wwQpdZL0rgCxwicUofqv4pT5NH0KE/HvbOWKRuL9Lyfey3hGBL0iT3C2fVr0gnWnd7wpPsYSAOpagmff7CZMK2LOmqGnU7cXX3RduvF6OBWFcxNL68AvD33FgSaDWg7zSlEH3v94IAt3rPID42Ks/9AYoPVEsK8H6S9LuQhk/njPdaqUQNxw3sebBGT/FMh0IXhbq1IhMthuSF/HmQ1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/2023 7:44 AM, Sean Christopherson wrote: > +4.140 KVM_SET_MEMORY_ATTRIBUTES > +----------------------------------------- > + > +:Capability: KVM_CAP_MEMORY_ATTRIBUTES > +:Architectures: x86 > +:Type: vm ioctl > +:Parameters: struct kvm_memory_attributes(in/out) > +:Returns: 0 on success, <0 on error > + > +Sets memory attributes for pages in a guest memory range. Parameters are > +specified via the following structure:: > + > + struct kvm_memory_attributes { > + __u64 address; > + __u64 size; > + __u64 attributes; > + __u64 flags; > + }; > + > +The user sets the per-page memory attributes to a guest memory range indicated > +by address/size, and in return KVM adjusts address and size to reflect the > +actual pages of the memory range have been successfully set to the attributes. > +If the call returns 0, "address" is updated to the last successful address + 1 > +and "size" is updated to the remaining address size that has not been set > +successfully. The user should check the return value as well as the size to > +decide if the operation succeeded for the whole range or not. The user may want > +to retry the operation with the returned address/size if the previous range was > +partially successful. This does not match with the implementation. Please fix either one to make them consistent.