From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>, Jann Horn <jannh@google.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Hugh Dickins <hughd@google.com>, Oleg Nesterov <oleg@redhat.com>,
Michal Hocko <mhocko@suse.com>, Helge Deller <deller@gmx.de>,
Vlastimil Babka <vbabka@suse.cz>, Ben Hutchings <bwh@kernel.org>,
Willy Tarreau <w@1wt.eu>, Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mm: Enforce a minimal stack gap even against inaccessible VMAs
Date: Thu, 10 Oct 2024 18:31:06 +0100 [thread overview]
Message-ID: <de4577ed-8794-43f0-8d8d-980abeccbf57@lucifer.local> (raw)
In-Reply-To: <20241009140822.0628a4d09312cbc19d73c6e4@linux-foundation.org>
On Wed, Oct 09, 2024 at 02:08:22PM -0700, Andrew Morton wrote:
> On Wed, 9 Oct 2024 15:53:50 +0100 Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
>
> > > All errors (new ones prefixed by >>):
> > >
> > > mm/mmap.c: In function 'expand_upwards':
> > > >> mm/mmap.c:1069:39: error: 'prev' undeclared (first use in this function)
> > > 1069 | if (vma_is_accessible(prev))
> >
> > Suspect this is just a simple typo and should be next rather than prev :>)
>
> Agree, I'll make that change.
>
> CONFIG_STACK_GROWSUP is only a parisc thing. That makes runtime
> testing difficult.
Hi Andrew,
Would it be possible to drop this for now as it is not clear we want to
take this approach and there is some concern this could break some things?
I believe Jann was going to provide an alternative that attacked this from
the mmap()/mprotect() side also?
Thanks!
prev parent reply other threads:[~2024-10-10 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 22:55 Jann Horn
2024-10-08 11:39 ` Lorenzo Stoakes
2024-10-08 14:20 ` Jann Horn
2024-10-09 14:53 ` Lorenzo Stoakes
2024-10-09 17:02 ` Jann Horn
2024-10-08 22:45 ` kernel test robot
2024-10-09 14:53 ` Lorenzo Stoakes
2024-10-09 21:08 ` Andrew Morton
2024-10-10 17:31 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de4577ed-8794-43f0-8d8d-980abeccbf57@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bwh@kernel.org \
--cc=deller@gmx.de \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mhocko@suse.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oleg@redhat.com \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox