From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2192C77B7A for ; Wed, 31 May 2023 07:42:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74028280003; Wed, 31 May 2023 03:42:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F044280001; Wed, 31 May 2023 03:42:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DF26280003; Wed, 31 May 2023 03:42:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4F921280001 for ; Wed, 31 May 2023 03:42:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1F5B61A021D for ; Wed, 31 May 2023 07:42:37 +0000 (UTC) X-FDA: 80849757954.15.66A8CA5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id CF42C40018 for ; Wed, 31 May 2023 07:42:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OmrklKEs; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685518954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pu0dxF+jwnL1jQ+DhiyLdliDD3ireyhq8OENBi+96kc=; b=JxmSvWbwB2hR2SOitiy/8/PAHKhHnRY8okMXECZFazkUCh3R6QhRwqrLnzt6bW9nRTfcOM znbSYuFxcPN5nPctvrfLSqNq0OH6z3gr/E/XJMOs0ppvD/XQPKa63tsGTnn//GbnMY1YEd 6l48gfuAcMFTmt4gu6Xu5TREFCyHvsE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OmrklKEs; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685518954; a=rsa-sha256; cv=none; b=OBa7FpDVzTKR78XTp715BuOHAjlk+tpErq9J1KQ/tDAkTiKqnFrzX8+qPXX0SFe+PQspvS +L4aPqvTu1gBx/d1xKYXktts8CH8wCHPblvrqoRuxaX5uJBxAlHtqhdMdzaGemteFF2YtN g18WGQmJJoYy+jxP7TBmltr/YOXQCbA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685518953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pu0dxF+jwnL1jQ+DhiyLdliDD3ireyhq8OENBi+96kc=; b=OmrklKEsGvxQehIVfwU4d9Qo6kk6I59dfYomfvbW6Oal5Th4qZcxonHl1QhXNzdBdNhdG2 i34pOpdgPyZsOExZTw/LzXPGpeJcOSWG7APScm0A6Q6fvDdlWbpIo9CqWHyPiJiUcsnuAX ZPVfH8TBM33PyAIQEbCBE/kxI3ROR6c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-N_YdaqQmOHOXWCH-mpr5Nw-1; Wed, 31 May 2023 03:42:30 -0400 X-MC-Unique: N_YdaqQmOHOXWCH-mpr5Nw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30af3835de5so920606f8f.0 for ; Wed, 31 May 2023 00:42:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685518949; x=1688110949; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pu0dxF+jwnL1jQ+DhiyLdliDD3ireyhq8OENBi+96kc=; b=DvLZmWGiBYo/5kYE5C4JulWLf0ReOXziIFXATmAPpv1lmwE4LhhDsDF0KhzMmXQoqB oNDU7lg01tkgw6y2aI4AMW3AALFojUzq0ST1fKzwfCRaE1Qsq0zE62LLXI4So4psDrJF Ix7Y51WNnafNR/AFH9Ce73tJKLNtK4j1BW4P5REQAs5ZsOleOR1TmI9QGI/2iCDS1pHD X29+8KCTHEEUi7W9+GJpmK/zVVJzsUk/QHsal+3WPtkAppo3T2HTz2BElYcmSV/h/AkK xc62obGFb/7q+uub1kiCC6B0uMM5GGUwNtmSJiWCOaKkC22qDZPmFq7NXhVZEgV/IPLL CYCw== X-Gm-Message-State: AC+VfDzDPpEcwXRqWNyOqLcswd6uOOrI9CwWxehmFdElaJdWBkCkEk0y M44xwmoOlEDRyMSyrV0gpy+IvQAKV5w5JOoNQ4P45BcoPU5ARN7kCJufHXCIB2HmcNtowTil9MW 0E6UToADwKGE= X-Received: by 2002:adf:fac6:0:b0:30a:ea8b:4488 with SMTP id a6-20020adffac6000000b0030aea8b4488mr3243073wrs.16.1685518949148; Wed, 31 May 2023 00:42:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/TwaL/29NG4Q1Wh9FQAc5H0Tf7tBtuQA1EX6A8ez87/GPRHlCFpKjZKyenEHxOPL3HkoPpg== X-Received: by 2002:adf:fac6:0:b0:30a:ea8b:4488 with SMTP id a6-20020adffac6000000b0030aea8b4488mr3243049wrs.16.1685518948739; Wed, 31 May 2023 00:42:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:cb00:fc9f:d303:d4cc:9f26? (p200300cbc749cb00fc9fd303d4cc9f26.dip0.t-ipconnect.de. [2003:cb:c749:cb00:fc9f:d303:d4cc:9f26]) by smtp.gmail.com with ESMTPSA id p12-20020adfcc8c000000b0030adfa48e1esm5812964wrj.29.2023.05.31.00.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:42:28 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 09:42:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: David Howells , Christoph Hellwig , Lorenzo Stoakes Cc: Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , John Hubbard References: <20230526214142.958751-1-dhowells@redhat.com> <20230526214142.958751-3-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v4 2/3] mm: Provide a function to get an additional pin on a page In-Reply-To: <20230526214142.958751-3-dhowells@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CF42C40018 X-Rspam-User: X-Stat-Signature: s85o9gjki3xstkuc878hr1d6g7so5ir1 X-Rspamd-Server: rspam01 X-HE-Tag: 1685518954-681328 X-HE-Meta: U2FsdGVkX1/t/7BIUYnvimSyFzHsdmlTS0Ib2fcUiJ3V2YTdnIk55R1Qfy8gwbNUnfr0IbkcI/2x6a9QNA3LSdpfTH9TuW1O8pPat1gRSUAeVd+C6ef51Qah3TEYew22EQbTc+gSvzD5ypOjOQn14vbZEwfTEjnymWMNH6CkD0xWqOc9BybZRAACQ38xkGGr/NFswINqwn95/ITpUDbI0/+SH6Z4ZfVaN3FSqy47EMzHPbFXzfmy0FKFB6UBFkIPxsWpnB8rlSTQWtlXHlzCV3Fp7V3x+9+XIX5yRT27XoTm2vyTrtFbxzxGqM7D27HaJydAOs6bwE6oHt1XOKxm+zSdh3d10iLwTywZNB/3hihpIp8mDIscwcCRNWmTedaD9NtojquOb0C36tWFJy55RN6m4vci572rOTGBm/0KmWsb2H4Zi55XFQXSMtYXZkwfJ98f6TDnO7xU73xVcps3qXY6b+hd+kIO+QEnVaQmidXwAjzEqSybK1nzn1Aj55ztEgi00ZkaGbP1n5rr1oKujBM6mXYFaU1MmgBesr3nD+wLuEoIXajgmUZRQiMj8SzjsfDhklX0yq8EXtEeTT3lyt6fXpSv1WEG1Kuvw6GNvhIhdfnik73DZiE2RWxgomxX1zkaeVdlP8SwjLu8ORvst0Y9LNw+Y0upNijxUue3EWCN2leUZ8jv+3Q8Zx8ZT3+SNE5906Zq6HJ71oGXIQ37+ulK402LlZTOL9w9hD/+LvUSJCaGi9ZSZXoXs3jNdiTyc8BvfcKQpKfraKq5xZEQZamEcd7S4tdZbFY9i7UwGvAM9lbVZX8ITv+FUfa3gg2HFG9L/e/aGZeFxw7HFHojenz0phoyOxCOINFCIz4yHdAHTd9rfTGGiJxBbjOEAohI3onHBpoQBHa0+vXxZEyWWYS9DVsolUHehBbIy0DvkGF0llky8mvnuWjk+yNC8yBs/hmdAvFvM/8jJHH/S8m 6njESHcj 9FoDkTxfq+ox0b7GHnu+lF6F+WxA453D+lwrk3msWR2tgGnTL1nYtVyZZitolSIag0g4uignIPK2W+VvdCgV36T+KnruSsV17aUBXkrFipd3CILR7IIwM5atQ/aulREI4rXWsh3KnKT3D5nwDFxGCd5CZeHDnEbetaXvDsfJ6Bx84MqDReF44XsKyx53lEQ0MuGY6LECp80qZbAxRdw3geKh2QLJ1EIbNM/ktKIGFQXyJ8R2elOE8eS6YwebCT0YW6ta6ETmyxKqUnTXMcZPkPly1GVkHoo2TlPWqBL5/usR98BffUM/dI2inhC3a8aKq0xHI0soX7Q8B/oCszYfBdSUS34U0zgqjRZ9FW1Gr0fFGKzjjvzDD2qUfPH92U2QKileEdCNn9ieFLGH2iTXsa3O2W9oH67Uup7amsUZSEsY39/s8xSGYsGjy/8gyxvuP/Zgd/70gu2Z2O+kUXUKcdM3enA3Didr7f4OaBE2RCdAcwp5wBLF0oI8e8VkJIxSKNHIkaNKHRk7oyVwJF+OyKhkpsQxgCNyEhNcI4hq7rRqAjjFYSLexoVxCqkY67/hLqDeC2Zsu+WMU53WBRBhydOOUDyxpr+TMcDfFv/Tzb9KElX/k1TOZvGmOP4za7ycNYYLEwNJg9lXrnb7XMy5YlsGg/rq1odfvQqjZmVR/sdvGGJNiRJ+9/B9KwkaTZzvjxe7Z0WpJULJxwYuCUCkcGSSagPw6h3NdM2F+yE3KPZiMc8GP9+psivJeCce5UUnDjDYauzwljD6bmklkC9wF34UpvCaMGrx6UOxSSShGe/RnbkL7DzaSjTlXy26WF9S8mc4HKuscDvUYIC/2QbhPJcIDV+EBFyjGbtajPZ17L3VSr/2Pp/ANlfY4/e5R234LkhNC4KlmZKfn9fI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.05.23 23:41, David Howells wrote: > Provide a function to get an additional pin on a page that we already have > a pin on. This will be used in fs/direct-io.c when dispatching multiple > bios to a page we've extracted from a user-backed iter rather than redoing > the extraction. > I guess this function is only used for "replicating" an existing pin, and not changing the semantics of an existing pin: something that was pinned !FOLL_LONGTERM cannot suddenly become effectively pinned FOLL_LONGTERM. Out of curiosity, could we end up passing in an anonymous page, or is this almost exclusively for pagecache+zero pages? (I rememebr John H. had a similar patch where he said it would not apply to anon pages) > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: David Hildenbrand > cc: Lorenzo Stoakes > cc: Andrew Morton > cc: Jens Axboe > cc: Al Viro > cc: Matthew Wilcox > cc: Jan Kara > cc: Jeff Layton > cc: Jason Gunthorpe > cc: Logan Gunthorpe > cc: Hillf Danton > cc: Christian Brauner > cc: Linus Torvalds > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-kernel@vger.kernel.org > cc: linux-mm@kvack.org > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb