From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DB4C636CC for ; Mon, 6 Feb 2023 00:52:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0222F6B0072; Sun, 5 Feb 2023 19:52:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F14346B0073; Sun, 5 Feb 2023 19:52:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDB996B0074; Sun, 5 Feb 2023 19:52:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB5426B0072 for ; Sun, 5 Feb 2023 19:52:16 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9E818AAAD3 for ; Mon, 6 Feb 2023 00:52:16 +0000 (UTC) X-FDA: 80435040672.17.9432120 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf24.hostedemail.com (Postfix) with ESMTP id 29C90180004 for ; Mon, 6 Feb 2023 00:52:13 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675644734; a=rsa-sha256; cv=none; b=VLm71+uA9IYPezSJ3yEx0qkDmw7BzNCVNQhbHG0+ELrKQZHOcg6b+Dz/NyJPRVDeQ8kTru Rd2bWnlRAzZtJBCiU52rGnfPdC0oN5hsdrnH2sACy6PtciMlm1R8AAVzdH1fVGk/ySxKYe p2gIeoMHn9LXCM0zcZKK1J3PIrRrE+U= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675644734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x1E4Aj/u+SoXSkwdoXSxbEyfThrOlxZkyBzZKLjz9oE=; b=qTnVKq3LUm+MtfBLROmLnwHmrDTel+8RvzPoxy/cdQeUxliHkRNep+eqRHiTLBFPkIIVfC uylGwMvMhtP56G1iZjVeN+my6nyIE5va1zErcQIjmTizJ8iieiHb/qbSoBDnKwMBZnQjC2 FK7RMOkOOH/l3o8tTdR8NLosvE5pGRo= Received: from dggpemm500014.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4P972d2VW3znVxp; Mon, 6 Feb 2023 08:50:01 +0800 (CST) Received: from [10.174.178.120] (10.174.178.120) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 08:52:09 +0800 Message-ID: Date: Mon, 6 Feb 2023 08:52:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 CC: , , , , Subject: Re: [PATCH v3 0/4] Add overflow checks for several syscalls Content-Language: en-US To: , References: <20230128063229.989058-1-mawupeng1@huawei.com> <0b193743-b3ad-6e05-f6bb-ae5653fd5ef0@redhat.com> From: mawupeng In-Reply-To: <0b193743-b3ad-6e05-f6bb-ae5653fd5ef0@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.120] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 29C90180004 X-Rspamd-Server: rspam01 X-Stat-Signature: oawqrirbsna8tnomaj3gjbcxqzu8oy8h X-HE-Tag: 1675644733-986332 X-HE-Meta: U2FsdGVkX18oLuYpHX2d2BRqtFN2eZ/PZdSzeUSbtPcaYRUHRnWVOprIUaSMXpcDlKR/b7n1o4h4xF3cCsyHWA6b99fNlw1nwGwcMFBFMv/bMzydkNADNXU2O3pwpZzMb83K+647lC0B9tjspCta+8BXFpGSaLBdUxpSGlB9y/7urkjMvtn9a0XKoeuWrCtEZUsQf6pfOBSY91LPbSRfvCRx/OF23TFvmqvvqhLshQe90RPnGm6E3S+659B/ZTzmnCJ63he92MR98LVyNbWVn6NOYyyF9CbtvhHru+4pDstJAXLUcZtnSTryOuLRyUp0HB9njsT3qt+Eqf0U5vZfdDkLNd3r/t6OCx+Z79Gs+OLAhzzRhqUDqJDEI05y+KdfHmddA6N34amBeDdUYOvM8p6tAjLy/PrVFtKylpGNoDxWzbngVuAIrgqwe3dQI175A3pZor7tIM2bZW9XUNqjlIEBUH76kSbg+R/pWVz5dkYnBaY1u+3Jtwb4bd/x63LhYfUeHUulwKMGGsSQ40CzyO85jIa7h5Mm33ScfUyarNMcLGb9w4m921x+HV9tULHu9mKUmfXJptgbLUClFbYY/Eh7Fkh1ZtiMiZHWjBF47a+7EiRSglaiHuACGOGhSh09ozxcuVG0EdNfIsKE4Ovpb0bKziQQtNkwRmwpTPMpRsS6p2DzUo7q05Zi1iwqYdFwWKGQBk4ExbbgmZArYyp7te51Fymi9MLBujsaMFj6svkmswZtesUHuaJSHA/TfHu/8H6ydMdcWlYzkRuQaOsq6cewqrGEVo4Ln5jE/stSAakEhvRfbrkt6saSiDycOiTTj+gtE46F9ldb+qaWQBle/1LTAi7RaqTmOJE6TfX44wV8eDSBv9uuRtMSi5IdsHxbGy15EIj50nkTIv6BwS92BdUa5E6PtwJ64C7/cxpgkFfB4L+JTrtPtlnsw8EANbPKif0Gi02t/dFkxpGXNeb mr3MoTs2 LyeM3YBtLsh5jfV75T/1wsT7BRZ4kOXCdif9ibBQ4CVrrQwsMPJrd3jmbVidiRcniwNw2ICdhpNDxZCe/oHxV8nBTErnieuyGiTdKe/m6GgOdvH4MTNcMWDs2IdzBS41U5mXOWTnpMQMosXtUJT7kE3Xqx8dLZmmwVvl0QcRL2s7H4Fw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/2/4 1:10, David Hildenbrand wrote: > On 28.01.23 07:32, Wupeng Ma wrote: >> From: Ma Wupeng >> >> While testing mlock, we have a problem if the len of mlock is ULONG_MAX. >> The return value of mlock is zero. But nothing will be locked since the >> len in do_mlock overflows to zero due to the following code in mlock: >> >>    len = PAGE_ALIGN(len + (offset_in_page(start))); >> >> The same problem happens in munlock. >> >> Add new check and return -EINVAL to fix this overflowing scenarios since >> they are absolutely wrong. >> >> Similar logic is used to fix problems with multiple syscalls. >> >> Changelog since v2[2]: >> - modified the way of checking overflows based on Andrew's comments >> >> Changelog since v1[1]: >> - only check overflow rather than access_ok to keep backward-compatibility > > Do you have some test cases and could we add them to LTP, for example? The basic idea is setting param len to ULONG_MAX. while will overflow if PAGE_ALIGN(len). Here are some simple examples: mlock(addr, ULONG_MAX); set_mempolicy_home_node(addr, ULONG_MAX, 0, 0); mbind(addr, ULONG_MAX, MPOL_BIND, &nodemask, max_node, MPOL_MF_MOVE_ALL); msync(addr, ULONG_MAX, MS_ASYNC); >