From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
willy@infradead.org, linmiaohe@huawei.com,
naoya.horiguchi@nec.com, stable@vger.kernel.org
Subject: Re: [PATCH] mm/memory-failure: fix hardware poison check in unpoison_memory()
Date: Tue, 18 Jul 2023 07:25:53 -0700 [thread overview]
Message-ID: <de34306d-450c-019c-db43-55451e7929c6@oracle.com> (raw)
In-Reply-To: <20230717120002.8da3920c4006295bfb5234cb@linux-foundation.org>
On 7/17/23 12:00 PM, Andrew Morton wrote:
> On Mon, 17 Jul 2023 11:18:12 -0700 Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
>
>> It was pointed out[1] that using folio_test_hwpoison() is wrong
>> as we need to check the indiviual page that has poison.
>> folio_test_hwpoison() only checks the head page so go back to using
>> PageHWPoison().
>
> Please describe the user-visible effects of the bug, especially
> when proposing a -stable backport.
User-visible effects include existing hwpoison-inject tests possibly
failing as unpoisoning a single subpage could lead to unpoisoning an
entire folio. Memory unpoisoning could also not work as expected as the
function will break early due to only checking the head page and not the
actually poisoned subpage.
next prev parent reply other threads:[~2023-07-18 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 18:18 Sidhartha Kumar
2023-07-17 19:00 ` Andrew Morton
2023-07-18 14:25 ` Sidhartha Kumar [this message]
2023-07-17 23:21 ` Jane Chu
2023-07-18 0:14 ` Naoya Horiguchi
2023-07-18 0:39 ` Naoya Horiguchi
2023-07-18 14:30 ` Sidhartha Kumar
2023-07-18 23:59 ` Naoya Horiguchi
2023-07-20 9:06 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de34306d-450c-019c-db43-55451e7929c6@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox