From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FCAEC432C3 for ; Mon, 18 Nov 2019 02:52:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E31C206B6 for ; Mon, 18 Nov 2019 02:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E31C206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA4166B0007; Sun, 17 Nov 2019 21:52:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D54826B0008; Sun, 17 Nov 2019 21:52:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C42C96B000A; Sun, 17 Nov 2019 21:52:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id AB6066B0007 for ; Sun, 17 Nov 2019 21:52:48 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 435B5180AD804 for ; Mon, 18 Nov 2019 02:52:48 +0000 (UTC) X-FDA: 76167875616.11.tree67_528f4ffdf8d0d X-HE-Tag: tree67_528f4ffdf8d0d X-Filterd-Recvd-Size: 2959 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Nov 2019 02:52:46 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0TiMfBZg_1574045560; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TiMfBZg_1574045560) by smtp.aliyun-inc.com(127.0.0.1); Mon, 18 Nov 2019 10:52:41 +0800 Subject: Re: [PATCH v3 2/7] mm/lruvec: add irqsave flags into lruvec struct To: Shakeel Butt Cc: Cgroups , LKML , Linux MM , Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Vlastimil Babka , Dan Williams , Michal Hocko , Wei Yang , Johannes Weiner , Arun KS , Rong Chen References: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> <1573874106-23802-3-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: Date: Mon, 18 Nov 2019 10:52:40 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2019/11/16 =E4=B8=8B=E5=8D=882:31, Shakeel Butt =E5=86=99=E9=81= =93: > On Fri, Nov 15, 2019 at 7:15 PM Alex Shi w= rote: >> We need a irqflags vaiable to save state when do irqsave action, decla= re >> it here would make code more clear/clean. >> >> Rong Chen reported the 'irqflags' variable nee= d >> move to the tail of lruvec struct otherwise it causes 18% regressions = of >> vm-scalability testing on his machine. So add the flags and lru_lock t= o >> both near struct tail, even I have no clue of this perf losing. > Regressions compared to what? Also no need to have a separate patch. >=20 Thanks for question, Shakeel,=20 I will change the commit log and mention the original place: the head of = lruvec struct. As to the folding, the 3rd is already toooo long. May I leave it here to = relief a littel bit burden on reading? Thanks Alex