From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27DAAC47422 for ; Fri, 26 Jan 2024 09:41:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACB246B00A0; Fri, 26 Jan 2024 04:41:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7B596B00B4; Fri, 26 Jan 2024 04:41:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C3D6B00B5; Fri, 26 Jan 2024 04:41:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7CBEB6B00B4 for ; Fri, 26 Jan 2024 04:41:55 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0B26080EF9 for ; Fri, 26 Jan 2024 09:41:55 +0000 (UTC) X-FDA: 81720970590.27.7F2D3D7 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf17.hostedemail.com (Postfix) with ESMTP id 23E5F40013 for ; Fri, 26 Jan 2024 09:41:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=jirislaby@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706262113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6YzzmD/zSUVKR8z+zYD1/Hh2OhOIaQby83Sn0quY0TU=; b=zXFSuZp0cjOETP0X4m7jqUXgOHRpP1B8mHMDVBstDNZ5LLQdS+Wqb5YJKOjSn2WfD75VmI WlM/ht10Auq6mjW6V4Bm/KACUJRQHDp74zg4K1x6qT85Ws1gb7ZwX1Zaq/kwKKc22CJz4C hMDZmY0cvrZ+/p/3XZL4VIRiZ4bnnis= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=jirislaby@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706262113; a=rsa-sha256; cv=none; b=oizZ90XHAE9WCqtD/6JazifM5oWFRN5evrk+85arBB2Qab2RAnpPLL6ByrXT5MVDUhzj63 qWTO/c4X7XwdAr7uG3KyZL+ECJgswQ0C79e7wBYLLv8IdVBYvDJXxZVIvrm+HVg44fqVVp gcqucIDHWD0CsvNnZZiDffcky6uxsac= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a2d7e2e7fe0so36543266b.1 for ; Fri, 26 Jan 2024 01:41:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706262112; x=1706866912; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6YzzmD/zSUVKR8z+zYD1/Hh2OhOIaQby83Sn0quY0TU=; b=rIAPtzfmhu4aXQ7enr3lgNQ2VYX5coPyxe7HlT8VtQPNsycBs8A+Ys3SRqyN9v52kc XZ+5hzFfDyyBHJr0sseDXE9rknHEsUYdX5eiNPzKj+ANB1m197p/0S1eQZhKuWGu9x+V ImDfxrS39zbFbcg1I6E+c5iPq7XAdvaSGoQDBy/lYu+7QapPAt55hNykZVIXfJbVblCx 7R5NFDiHb5EJJcBkCI2sWDlYE7L7l+DEJI+PJgpox+N4sAOpbumxzKjdUOFL7amqTvFZ /rEPZ1ZTj41MUORzGDCkVMXs1EASVO1oWBAUSwB7C9P4zCIaILQHInOiL/3GUO74Jp8m tQOQ== X-Gm-Message-State: AOJu0Yx4GfMoPfxkGmxoS8DeC4OBtyWeaP6WkdgL+GHY0uXHB4JmXn2k Jc9Og0aqGU2qj0hr+gz4nSnvUhk3MrF2e6EypinE/pT6ors2DhDT X-Google-Smtp-Source: AGHT+IHsbiDe5EEckDL3MSORIWfVdvqB33J3OrMlcOqnBs6nFqmVk7zjTk+MRhVS8q7h2GhzRSz7Yw== X-Received: by 2002:a17:906:ad4:b0:a31:8944:2cf6 with SMTP id z20-20020a1709060ad400b00a3189442cf6mr551837ejf.8.1706262111426; Fri, 26 Jan 2024 01:41:51 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id gx3-20020a170906f1c300b00a19b7362dcfsm427085ejb.139.2024.01.26.01.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 01:41:51 -0800 (PST) Message-ID: Date: Fri, 26 Jan 2024 10:41:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit Content-Language: en-US From: Jiri Slaby To: akpm@linux-foundation.org Cc: surenb@google.com, riel@surriel.com, willy@infradead.org, cl@linux.com, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Bernhard M. Wiedemann" , Michal Hocko , Yang Shi References: <20240118133504.2910955-1-shy828301@gmail.com> <2afa54e6-90db-4ae0-a21c-78e5051aa83c@kernel.org> Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <2afa54e6-90db-4ae0-a21c-78e5051aa83c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 23E5F40013 X-Rspam-User: X-Stat-Signature: jm36wdbhq13m7qsmtds4an6zxhqp73tc X-Rspamd-Server: rspam01 X-HE-Tag: 1706262112-704636 X-HE-Meta: U2FsdGVkX1+GZJbiwPgON7os/3yn9Hm2pswQXcL3odzbEgMrbl9DJ7X7gCQbzoAXroBp1gAGMBAgqsTWLQBIBZk00VO9AXWCD1SMiN8F/e4BvaQki4naw+rA45Ljd11YItzijELyOAfoUHxjcaPpF5/7KDLUJ/8oGaU6nEmBisiZVjoVEnNDkNEM17B93q+p17+W+EPTM5ySb5BPW9vCGLPpF+80DRlXz0mefUmZsdV3XefCELv70sfOQoU3MjnqyHocqMAc2QEidLcu4tJ0LpJCHoWV8t/EwixjljxWuT8bZ2fBCsFpQSybht5zU7e2nycoxmrIk1QRG6dwqyYTxLfRg+OEuP3hhSE/6wCcJnVfnEIjAwaPzItbf4nCLCPYOArdeR4M6cA8WHX3LbkSalTwXiLVoAzbq5ZhPssXRBJaSB63rFHqvQaOycR7thG7hYnuznE9woWVklN/vd3vA+JJS3QI8vOaTaa7WUJcWjeexEV5Us6GEBTCs9S/QxBcN0syfVXd1S4jocDWhT3OLLkHKE2QK+NrsAi8FL1BW6QkVzmJLAehKzfzputyjiiQfPYK2wM7gLY6w+/xdwPFsmkzfn5oDHb+iYunERM0NY0NsrOIwR0hjKmtxKXReqbXREczEOnwKNdubrCZ4eVRuKCL8Qzir6ue5iharDls5lAFMiw+MZF5fIAOUfKu+hAuQrM+D5XPetqn2VDZ506m6hT6W4bAvyJjbuyEQZDKx+P41T8ANg+e04wNyR7ov5ziR1fSmQVTdcxh9TjbFvfXQsLDB02Zb8hTHvcK6spKdLWg96u+5/FEh/eBS2ivOLb/S8dbZCDiOFUkb5xAfgr5jXCVaIRsJN2946tx8Ezy6bdnqK4A2vabxMTMKbnt5TbzYjDCKlx3bca4uiCufvoo/x39bgswl3z7DBk5EP86sFZKPozj9Hhjl+1zYNJAN4BNS5hium0XsQu8RqbOhmI b/NfYyCh ek4CJq2BjhAvOJH0vitrdA1cM3tYQk+AUecFWW2dshW+pyuxOjenI+sHHU7iJqDefe8mxIGPFHRBXUnnhK/J3Bz+BJh9hW2nIRRWd/O0Avnao7FlpDFKiEuLQOrAuFvq1ct2+7psNMUVBUojKBvknnUV8/7RzK36CTcKkvx3Llm0iXz0viOGWAwk1his+ouM4a2kgHPOP+YU2M5CrPgpRstTVq2fCEoLrb7vNWzaE7XgK6ZslrmAurcznso75FKu+vB447oK3g6aw2AkG0r7oLDteRoNdhI62aL8zSZJp9848paZ2/ljnHbO1tXxuvGyJU9jkxO8pmGuLoII5BCiPRg4b4JBjyCeUYtInyc3cw5gLHCnZQEKD+Ten31A+cdvN77I9HImjdfZKQPmjpZxJL7ysYhk41pgmhDybc84Zn5o7TkNIeTCcRtv/z4gQ6JJpXVbwpHtpBzkz+Qr0RrQE1NuQ2BNIMkd4MPMFyzbHcfGD8JsOAr336HkgkcNeaX2aAc68DmLqndFtZDItfasF7VUL8KSG3Yfk8MJNu49G6uceSTlKXGdeK8aJxsl8JqKOfeglt/KgIpa9VN4yqsQMaC/xVPXavufsT+wBJNjz4QfqrByQiZCIyPOPxowfXa93IXN6o9sQauSTwAhdqJ4u1bevJYKaQBGssF1E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26. 01. 24, 10:36, Jiri Slaby wrote: >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -37,6 +37,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>   #include >>>   #include >>> @@ -811,6 +812,14 @@ static unsigned long >>> __thp_get_unmapped_area(struct file *filp, >>>       loff_t off_align = round_up(off, size); >>>       unsigned long len_pad, ret; >>> +    /* >>> +     * It doesn't make too much sense to froce huge page alignment on >>> +     * 32 bit system or compat userspace due to the contrained virtual >>> +     * address space and address entropy. >>> +     */ > > FWIW, > Bernhard noticed that "froce" and "contrained", could you fix that > before applying the patch? No, you can't: 1) it was merged to mm-stable already, and 2) the comment is not in that version at all [1] [1] https://lore.kernel.org/all/20240126075612.87780C433F1@smtp.kernel.org/ > thanks, -- js suse labs