From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: David Hildenbrand <david@redhat.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
Ryan Roberts <ryan.roberts@arm.com>
Subject: Re: [PATCH] selftests/mm: link with thp_settings when necessary
Date: Fri, 1 Aug 2025 12:14:34 +0100 [thread overview]
Message-ID: <de1d81bd-0178-4649-97a7-016f6f349cf4@lucifer.local> (raw)
In-Reply-To: <566ff1f0-e6f4-4888-a901-4995a84d15b7@redhat.com>
On Fri, Aug 01, 2025 at 11:02:35AM +0200, David Hildenbrand wrote:
> On 01.08.25 10:54, Wei Yang wrote:
> > Currently all test cases are linked with thp_settings, while only 6
> > out of 50+ targets rely on it.
> >
> > Instead of making thp_settings as a common dependency, link it only
> > when necessary.
>
>
> You don't state why we should care about that? I don't see how binary size
> is a problem, why do you think it is?
Yeah overall I'm with David on this, I'd rather we keep things simple (so
you don't need to remember to link against this file) and just plonk all
the stuff you need to link to together in the Makefile.
It's not really a big deal when it comes to test stuff I don't think.
Cheers, Lorenzo
next prev parent reply other threads:[~2025-08-01 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 8:54 Wei Yang
2025-08-01 9:02 ` David Hildenbrand
2025-08-01 11:14 ` Lorenzo Stoakes [this message]
2025-08-02 2:33 ` Wei Yang
2025-08-02 2:22 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1d81bd-0178-4649-97a7-016f6f349cf4@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox