From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385ECEB64D7 for ; Wed, 21 Jun 2023 14:16:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE8218D0003; Wed, 21 Jun 2023 10:16:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A70418D0002; Wed, 21 Jun 2023 10:16:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 910908D0003; Wed, 21 Jun 2023 10:16:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7F4E88D0002 for ; Wed, 21 Jun 2023 10:16:22 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1A962AFE13 for ; Wed, 21 Jun 2023 14:16:22 +0000 (UTC) X-FDA: 80926955004.14.17101BD Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 47658C0023 for ; Wed, 21 Jun 2023 14:16:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=i57nuMmb; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf28.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687356979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ilpKttK3hlbGmbwJHkqLrFgGH4qpQSnIREcU4evSldw=; b=h5S1vU8vQGt33qVyW1deMKoxNgf6DcQtaKmgelyeGlerUpE/V4/7X91wDzUb94rfMgfJIS Nhcw0pQ4XioPoUt1s5AatHtPb0dNZYMQyVkTcdXLGOgXWJ53Gu0+21n2NSiswsGIJF39Gw PZoYark5S2ifoE/J8CIFavq/JRHqzh0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=i57nuMmb; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf28.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687356979; a=rsa-sha256; cv=none; b=WEvObGQgYQjTLbOs5FU9Q9Bg5sRzOg3xdfNFZk6aVJcEGvnTkwRH907cg4B9tbGAOasqof 7mfFI5zzx36gUpaOM72KUNFiOsnwyZo/bBhQZHQc7bph/+srYQFZrn9tgxC8xhygLEZ0Fk LWVuwqbJCAjB+k/7KfUfx2ElXfH7ZW4= Received: from [192.168.10.54] (unknown [182.179.162.32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2D60A6606F95; Wed, 21 Jun 2023 15:16:10 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1687356977; bh=ZfrnBJpRDergXzvQfqh1+l1r+/MY/drS+UbPB4AW/uk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=i57nuMmb+8vcTd9/9oF/rAl+e8nxceBaB7h55tYAuxyov6Kermz+DV/q/aSfpXnfw fa8Wh1/O/jcyxUTiVaIDZsTJagLKkHdu3rAIkPCyLGIS7c/AUAAQ5cWjs6+wJ4YjFZ 28FYWQGCWE1W4Rg6Hv+ambt+3tBj+XtWDqtgLG3uUE6iz74JTwH00h6JkBcmciWkxY 1Rn4/ywv2h8ZMp4jhiilafjzHifzX+1iH3jW6WJm1DrfWIhhrqCyShcEIO3MfVWZ5Q 9Zxrt/Eheo7J3RVDJ9qCHBx6ebvjMNUq99xe6OyN5lGj2rWehMZ7VgF27366Y1QTbg lfsg9sPmQ4uYw== Message-ID: Date: Wed, 21 Jun 2023 19:16:07 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: Muhammad Usama Anjum , Peter Xu , David Hildenbrand , Andrew Morton , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v20 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= References: <20230621072404.2918101-1-usama.anjum@collabora.com> <20230621072404.2918101-3-usama.anjum@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 47658C0023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tkb4nittkbg3y6hq1wbwfku35r6nx65x X-HE-Tag: 1687356978-427811 X-HE-Meta: U2FsdGVkX191/76vjejTOa/M9mG6PXgBUc69S8MvgKKWWRF/7iZZe+Wo7UGwwSW1AJ4e7N5VJtauvIQO7Uy0VEG86Vet/ohFlPdkD3EcJW6xLVV6ln3mgGJgc5d39bnEvbaD4S9WgsxUrtrQ7USP2lGIj9GKn/FWhvROHftbg+APK1YOD6lVMJWjur+KtsAxtkbSU9mx7UkfCGBxjO0lvcc0a0KZAo151/OcCln1VrKBecim186FtK6+A+Sa55qrElp2Bib+3+GrhXOfoBqmAEKxFB4D1MJWmybO8SJNCNh4Sp3R6CQHS46Dr0g6Ty79yoMtGdlVfern246k1xGkI0+Ouh3WOszxzyuGvyw90uBeugMMjXe/iQhHC82n0+rN5pYvA5C70GnxeVR0eQ41cGqX/qM54beEDxo5f8Wi5/FRuoCbik5ANmm4FfesNIB23nVYki03FrIHtmbKkfEIsgs6DvKguFM5NBr2yy+qvZXF24gZIOH6LD2isH40bN//G6/ztAq3DEGqOJihABcXgCZQVQ9xPtq4WMXvjNpoI31O34mGKxw7+YmZl+oYDLe4GXYz5kxGwM1cWX4BrqXeNOB5mmYcZVxjDrEQB67mwlcLFMfqD+7puUb76w3EwFYFhgIf0k5YIEZXancBjg3okS7SLTwb8G7vGTHsEfrVUZdGomq/JcMm7xeh0hIL8Wr8BOVgRgtGWXzTTiWi/4nQDZbhMc6vd9B/oCGbZRwdHAveOu7oP7HtJhe6xCjMTvX7OPZwxNPnF+i+8wZGboTG3TQzv9L1OsHCtUUSeUSktElOO7V48C3vpV45KnXT97C0KEFO1ivWXhEeKSmnhelxlwe/wOAv5xb6TaYfIPzmig1a5O8x9Tjd80sdlrImQ9evPT6KpmClEcwxXUx+47fEGlNONDOZdhuG2j0UDSEx+A/sebISbCPfGxU9UAxUECEZ7iCF8LciM/CnNX/uD2j gQeZuNB5 vaOak9iQTagRlYpPMBHvC4ZX8pHUukOLO2xtyoXUfjf+T3lReyHvSOoeyx7chaG5Ioh/BmhqleegsOUP5jBj8fks+u4CRsnVFrORgMYzL8kGu7O/t6hlQjXx3TyIwSvIT1/QXCDTP0oRwOJCfJPPQZnLrqldS9Yi5PvqQ2CeOaiRQmt/a9G6xs40FwWSlv1JCb40wO0X1B8Q95VTI16V6wWqef+q9OcRjkkqEQ05Gpm/1BJqydRsSHR7wc9uiXG4m7gJfuMsSdWLYdpWj4HasUGPfKrTJGe/nQiGuP36DTPtQyjM90ImZKSwx9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/21/23 6:42 PM, Michał Mirosław wrote: > On Wed, 21 Jun 2023 at 09:24, Muhammad Usama Anjum > wrote: > [...] >> +static int pagemap_scan_test_walk(unsigned long start, unsigned long end, >> + struct mm_walk *walk) >> +{ >> + struct pagemap_scan_private *p = walk->private; >> + struct vm_area_struct *vma = walk->vma; >> + >> + if ((p->flags & PM_SCAN_REQUIRE_UFFD) && (!userfaultfd_wp_async(vma) || >> + !userfaultfd_wp_use_markers(vma))) >> + return -EPERM; >> + >> + if (vma->vm_flags & VM_PFNMAP) >> + return 1; >> + >> + return 0; >> +} > > This could actually short-circuit all vma flags (e.g. IS_FILE): if > (required_mask & IS_FILE && vma is not file-backed) return 0; Sorry, unable to understand you. Should we do something here? > > Best Regards > Michał Mirosław -- BR, Muhammad Usama Anjum