From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88962C4332F for ; Sat, 10 Dec 2022 03:38:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 985C48E0003; Fri, 9 Dec 2022 22:38:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90E698E0001; Fri, 9 Dec 2022 22:38:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AF028E0003; Fri, 9 Dec 2022 22:38:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 679768E0001 for ; Fri, 9 Dec 2022 22:38:02 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 35F8A401D1 for ; Sat, 10 Dec 2022 03:38:02 +0000 (UTC) X-FDA: 80224988004.01.5B3E125 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf29.hostedemail.com (Postfix) with ESMTP id DD808120003 for ; Sat, 10 Dec 2022 03:37:58 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670643480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ObGMYHPg92igpUsxwUwJzAauiEDCC+saRnTqhEIGaro=; b=ubykr7lrttx6rnHj+G8LhKS80zzvVG7OXjj+B65awFYfcmMYw5ud+WYXGJlbfVVpdp/aVa cYF90IYj/tJ8yZRH6LyaNToHqbeLjr2ZItAXb8Sx6GrrBbuw71Rm63jnViop2GQfVSfI2m pgc51c7CxIDZLvEgas8vHBEk3eqSI3E= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670643480; a=rsa-sha256; cv=none; b=YObFiDfA2Mx/pj5V7+HkTF8zfsAA5hgNFUv2ODBl97YzTQf3OSQEx5CcPy+YRICTN7zY3d yLNKWciA43RU9uP7Aokv0NxmsE++xgm2vrSl6fK1SGVqAWsxhjN+RtZedM7JzBeD+vVu6g aAaV+BsjmPoZa61fVxPsGOmsMAUmM8M= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NTYR15Qp3zJpF9; Sat, 10 Dec 2022 11:34:21 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 10 Dec 2022 11:37:55 +0800 Message-ID: Date: Sat, 10 Dec 2022 11:37:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next v2] mm: hwposion: support recovery from ksm_might_need_to_copy() Content-Language: en-US To: Andrew Morton CC: , , , , , Tong Tiangen References: <20221209021525.196276-1-wangkefeng.wang@huawei.com> <20221209072801.193221-1-wangkefeng.wang@huawei.com> <20221209165015.7de5f7173c534c10875e10fb@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20221209165015.7de5f7173c534c10875e10fb@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Stat-Signature: 3jhf3iu8a1q3bg9ztw3g6j479xagqamr X-Rspam-User: X-Rspamd-Queue-Id: DD808120003 X-Rspamd-Server: rspam06 X-HE-Tag: 1670643478-843626 X-HE-Meta: U2FsdGVkX19ZZkTiYhKSEbSKpMmPADiunTDojYuIL6+s9ldKt0I8FTgyT5ED+uJ+QXcjArpyVazOfq9oZ9Vih7Emz1iQcaEbKzl76uVSpF8fzFC0atZ2GfjZwAF1pWucYogOgyJyLySLiqss0SvJxn6GSZAb2q5jxEXgc1g66n7Lq+BAOAlqGyrUclUV3sMGYSlZx0x3HeTD1g406zpX69QRWEV3z1enfNkbaXQO46e8GxmI3M/0CK2oOjCmRpAsH9ESdgclselYlruGZuk6VIeOsAYrEYgM5sEtddKW2QmpBTMkLRJFWy5nOvIVbcFlYiTMeSIgtBmFYv8W/hb3fkoH5wpA3IhQ9SOj7G0TA2XtiN/Hkzox9Hxx8zQQtac3Zlm81ZtUoEx/I+BXRYkVCRuYETrJbJNfZX8mr73ExAukqB9REkQ2oxhUs3fUI951fv2hhwPbDt5aKboIDeKPOUJz5LnQYHOhDICilqChsCHBajCVJIhQJtQB+EULI+h6EYq0nC8HUjTtt+csuM0YBX9c87gHPddjmbXDgxaEd9c7kkMev8XywX4s0TOiZBx2pxs0ZuYbXhGjvxM1fv+ZAZw6SXc4qOlMnXzbcYYdqLJOX3liyELf/fFj0l7h9MzQ3X89U0UmtwZLOf8MBavRyH6PouMZiVG1hoAIfxeHjyXvSXIwezMO0t00e3TrBNVmOPdQsC356ewx3hWr2Qel+7vpCtjOx8kca82zPRZiuH1Zzfles2H2KOlmN5tbsmJUA6NixUEJ+sLsR3nVBu3NViaYJR39/yLiOQ9ISNhunBerN7eGUCj4QR8Br7I6dgIB3XpeZMX4ub+xDomSYKW8h+JSxmvC+yezXTE8/W6hfgqSmULYeUnSPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/10 8:50, Andrew Morton wrote: > On Fri, 9 Dec 2022 15:28:01 +0800 Kefeng Wang wrote: > >> When the kernel copy a page from ksm_might_need_to_copy(), but runs >> into an uncorrectable error, it will crash since poisoned page is >> consumed by kernel, this is similar to Copy-on-write poison recovery, >> When an error is detected during the page copy, return VM_FAULT_HWPOISON, >> which help us to avoid system crash. Note, memory failure on a KSM >> page will be skipped, but still call memory_failure_queue() to be >> consistent with general memory failure process. > Thanks. Sorry, lots of paperwork and bureaucracy: > > > Is a copy of the oops(?) output available? > > Did someone else report this? If so, is a Reported-by available for > that? And a Link: for the Reported-by:, which is a coming thing. > > Can we identify a Fixes: target? > > Is a cc:stable appropriate? We are trying to support ARCH_HAS_COPY_MC on arm64[1] and trying to recover from CoW faults[2], also tony do the same thing(recover from CoW) on X86[3]. The kernel copy in ksm_might_need_to_copy() could recover, this is an enhance of COPY_MC, so I think no need to add Fixes and stable. Thanks. [1] https://lore.kernel.org/linux-arm-kernel/20220812070557.1028499-1-tongtiangen@huawei.com/ [2] https://lore.kernel.org/linux-arm-kernel/20220812070557.1028499-5-tongtiangen@huawei.com/ [3] https://lore.kernel.org/lkml/20221031201029.102123-2-tony.luck@intel.com/ >