From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 263F8C47422 for ; Mon, 29 Jan 2024 05:49:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98E066B007B; Mon, 29 Jan 2024 00:49:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 916F26B007D; Mon, 29 Jan 2024 00:49:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B7626B007E; Mon, 29 Jan 2024 00:49:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 66CAA6B007B for ; Mon, 29 Jan 2024 00:49:17 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2E3D412026A for ; Mon, 29 Jan 2024 05:49:17 +0000 (UTC) X-FDA: 81731270754.30.7173462 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 2250080006 for ; Mon, 29 Jan 2024 05:49:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706507355; a=rsa-sha256; cv=none; b=swaNybDdVFvCRnlU/7v7lgX1Pxp8gp+GSexKmoETeuY7gbzvRhBxV8PLqF1n81jw8Z2mhu 6zo9nnyuKQYpHGO+SrmiChfpt0DSiaG4cV4qHSO9RPcu8Iz/TBp/Z2+AlvcxXRRxPwaILg M0snbSbJ1KP3cXevbc/zaT+s+605NQQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706507355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6jINreZ7FiMvtcWxSfDCWh/RTOtTZIMayGfK9QPtGzQ=; b=tvfmnrMWLa7abY/8BpOzVqwe8aCv/TngB/yeoCentyJMR0ul0u7+p7uLH6VNAj7ou12d97 7ePHyHUthWwZ8QjR99NWn1CGBhgl99H3x5eolFo+gFiFPAPZvMim2mnlIRuJ/I2LZUwf40 yIbINQ18gYfQrYWFF7sMlkbRCzF4pCY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 958931FB; Sun, 28 Jan 2024 21:49:57 -0800 (PST) Received: from [10.162.42.11] (a077893.blr.arm.com [10.162.42.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5FAE33F5A1; Sun, 28 Jan 2024 21:49:02 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 11:18:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 01/35] mm: page_alloc: Add gfp_flags parameter to arch_alloc_page() Content-Language: en-US To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-2-alexandru.elisei@arm.com> From: Anshuman Khandual In-Reply-To: <20240125164256.4147-2-alexandru.elisei@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2250080006 X-Stat-Signature: netqax7184opxyijkbe549hzs4h8z7q5 X-Rspam-User: X-HE-Tag: 1706507354-721434 X-HE-Meta: U2FsdGVkX1+6POCUDLIcB0rvdHazZT6ThBQPPd9NdHM1hc2LB3SV5hVdHBkJdw6SzFfW01Sow6pmqwlcetLuOO3Zc0gT5KuQSBlHlxhd/rL3+wcdZDVhOa98yDLUW6dIDimwbaicB4ZGaRxUqENW8w8hqnDar1BYb4uFupIR0marJ9e2Cqr2E/jbv4Xir4nmbJ+E5Y7tXHm1g31glTFcZuVCo19SryZKFusAX5C3E+lRAW5kpiKR3CUbns2Ay2EI88ljuRGMuEn0ASaJnQN6TQovzAnybvUnWk85+TsYUFViBUp7HRzzAYCPd4IaKJ93dZ6otzq4RVPdG+R9S0XtaYfeK2di+Do8Yi+yjrk7GucV+kEMiYW5RoeCmA3ogJabWY6VRjsJdzR1JTQ4xdoNFCBg2yFsAj+98tmvm57L1XDbtGhs1bCJANoHp2TeiytTMJFvUezzwXZ/uJehZb1hXVXRAArimtar6dgEv9UvS2mbBr1PC/6+YZ9nX1+5H3HKI9BK/1tPd10yKRaZwIw3Bc+RFeqqi6ITCSjYKBOSzF5VLESwVu8PQ0I/W0o+xjXQxco8pr087XLv6HXjGkQFtEPoRl4K8tpR4Bg49HLj2e5ZoHc2rYMR/w/OqqsJrpxgyl4Mz7ajPwpHanSEyE4rVXeHNrzshTrazOqu+VXVkSwdtX3g38LS5D3av9R6+4daeLo+EX8gMdyHTZDHE1qFukjqakh4v3ff9hk89r5sYALotQGt4du9qwuIz+goFBD+OfugM0b3K8Jxnqc8wYWii+iizeJsEc3cR3l+JPE+qZ4LWL9pQHmRmHCvDfm9HKzEzqLk3e/cwzRnOQvUyInixfSs6UAH7Xq5jtVLFKrByRUtTBYY0wQfGHEKtoy1rG1jOFah1N4JVDjHaxnvSKdQYr4V49P2tUAqloUJF9ZsdPxR/27yVh0HOfYnLNEIYRyi3diFAllJ9OMsbQe6hEw hAXDbyGj UwS2rw9w/sotA9hUYdFYbjQoC2tSkpxzDPV9F8aRZm93QUfpAI5GOoxkScPzyAGar0GUCW+pDePIY1ygu53ISwZqEXJf56iRqAc8/yBqOvHBTJn2J/OdN60u5+yGteak42rIKMzXG9vBqkmieZEV47Dn0zMI4+vv45uh0m7Oo8VQxzoRfa45rcJOvbs9ZGTeZC+1S4TYItG4rFLxq56jbBtQ8n7N2M7kJlmvi0/BQE/7YNeiHWtn3pZ3QvQ/sIO6yy5AW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/25/24 22:12, Alexandru Elisei wrote: > Extend the usefulness of arch_alloc_page() by adding the gfp_flags > parameter. Although the change here is harmless in itself, it will definitely benefit from some additional context explaining the rationale, taking into account why-how arch_alloc_page() got added particularly for s390 platform and how it's going to be used in the present proposal. > > Signed-off-by: Alexandru Elisei > --- > > Changes since rfc v2: > > * New patch. > > arch/s390/include/asm/page.h | 2 +- > arch/s390/mm/page-states.c | 2 +- > include/linux/gfp.h | 2 +- > mm/page_alloc.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/s390/include/asm/page.h b/arch/s390/include/asm/page.h > index 73b9c3bf377f..859f0958c574 100644 > --- a/arch/s390/include/asm/page.h > +++ b/arch/s390/include/asm/page.h > @@ -163,7 +163,7 @@ static inline int page_reset_referenced(unsigned long addr) > > struct page; > void arch_free_page(struct page *page, int order); > -void arch_alloc_page(struct page *page, int order); > +void arch_alloc_page(struct page *page, int order, gfp_t gfp_flags); > > static inline int devmem_is_allowed(unsigned long pfn) > { > diff --git a/arch/s390/mm/page-states.c b/arch/s390/mm/page-states.c > index 01f9b39e65f5..b986c8b158e3 100644 > --- a/arch/s390/mm/page-states.c > +++ b/arch/s390/mm/page-states.c > @@ -21,7 +21,7 @@ void arch_free_page(struct page *page, int order) > __set_page_unused(page_to_virt(page), 1UL << order); > } > > -void arch_alloc_page(struct page *page, int order) > +void arch_alloc_page(struct page *page, int order, gfp_t gfp_flags) > { > if (!cmma_flag) > return; > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index de292a007138..9e8aa3d144db 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -172,7 +172,7 @@ static inline struct zonelist *node_zonelist(int nid, gfp_t flags) > static inline void arch_free_page(struct page *page, int order) { } > #endif > #ifndef HAVE_ARCH_ALLOC_PAGE > -static inline void arch_alloc_page(struct page *page, int order) { } > +static inline void arch_alloc_page(struct page *page, int order, gfp_t gfp_flags) { } > #endif > > struct page *__alloc_pages(gfp_t gfp, unsigned int order, int preferred_nid, > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 150d4f23b010..2c140abe5ee6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1485,7 +1485,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order, > set_page_private(page, 0); > set_page_refcounted(page); > > - arch_alloc_page(page, order); > + arch_alloc_page(page, order, gfp_flags); > debug_pagealloc_map_pages(page, 1 << order); > > /* Otherwise LGTM.