From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E3BC2D0CD for ; Mon, 19 May 2025 19:28:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 021E66B0085; Mon, 19 May 2025 15:28:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEBE36B0088; Mon, 19 May 2025 15:28:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43116B0089; Mon, 19 May 2025 15:28:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B12706B0085 for ; Mon, 19 May 2025 15:28:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DCFC0140E8F for ; Mon, 19 May 2025 19:28:11 +0000 (UTC) X-FDA: 83460643182.27.7EC967E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 6D00F140004 for ; Mon, 19 May 2025 19:28:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UgUefIPO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747682889; a=rsa-sha256; cv=none; b=U9KyWgizDtyFL8HgI21wNTlWEvbFh682n5EeguCkQJLLCOFtTSdK3Sw5xEDDRbzAcJ6g0a yldYmMoZh3Z/9ZFm76fy0Gb7RTF8WVYDAMHShDUKKz568ansBXgYFlUbyZZtIonylV6DDd D7wZbeXg1aPzXLSRMI5WOzZZW6kfS78= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UgUefIPO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747682889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qVQZc5INnoqutZYmTut12ZA5XDVGTeIuyWo7ArztSjg=; b=GO9BLYL07TD6tH8bGxOImrTZeMWAKE7VzZSevSwF4Sjfx99jGQoY3ZH7MKTki271Iq0BKs AgjM0AvvXeC3GwYlHbLYJ4WPh2NHHdblaH7p+8Y2pgKHpRntMo1Nv3zrG8j6eKGLBqSosr zbclEJAjakBI0gwTt8k2oIaf2m6KhJg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747682888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qVQZc5INnoqutZYmTut12ZA5XDVGTeIuyWo7ArztSjg=; b=UgUefIPOtSaN77BqyNtBEiVrw6er5n6LweVaJYp09fONZ+PtKuJb60wiCW32pKlsAO3XyI bjBSbvU5YZRXtSpY/IgCVTNGmDsZrO3PTmZkqGldmM72YO3t+OREspHU3sG7lXvq5wh1mW w0hwR1W+ZPTAz/015Tv0OzKwz6a8Q2Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-ZzY3TpI-MDqqkj4qi2H_CA-1; Mon, 19 May 2025 15:28:05 -0400 X-MC-Unique: ZzY3TpI-MDqqkj4qi2H_CA-1 X-Mimecast-MFC-AGG-ID: ZzY3TpI-MDqqkj4qi2H_CA_1747682884 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43efa869b19so39520485e9.2 for ; Mon, 19 May 2025 12:28:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747682884; x=1748287684; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qVQZc5INnoqutZYmTut12ZA5XDVGTeIuyWo7ArztSjg=; b=s/nfxj1t+4MlKTtMT4ZWO38PcMwNScuBgQH+Ql+dBXCLsnXE2qUC1wANlh5EmjVzs2 AEZSUAjInIFbLL2a9jzCufSYdty+cDdQklAS48w2Lda55X/RnZooeFL9XxYjWqTUQQlK oODR4v5A0oEaMp7Db3xV6SJioTPGlAa0XNKe52aIaYkrN6NPsukSB4MEqYp0V5+kZa2T 6SaULs+3Q6PZYBcge3zSC1O7OX/d1iOKM0yis1MI4CPD6Opcd6BwitXvAlTgsXROuLZU /wMOj4+whehvOVejS6b7lI2fzyPy7pgKM+yy2UAn3gO10vY0+3Rt3C5/iPCkTp7tnUZ3 /tWg== X-Forwarded-Encrypted: i=1; AJvYcCUGkRyUQt0cX9lKb1BeZ3PZS0OOdimyXQO8R+hLXW7r7XjR9tPmxalgcrSCGPxZFV9XO681+h22Ig==@kvack.org X-Gm-Message-State: AOJu0YzBcDkbRT5eZpqtXZThCzgeM8UiGa21sbbQkjRHm3mJTEzJzdOO 7gXDf4IfkwnSEpVLc/fncGOMi2PjyZPV3EN7yUbqvc538Q2zDE1hvbAkkpekaHRQsP/5Avl0ron IKOwlTU19mXGAGAoKwfrAB7ZAnlE4Y6+4j6LIsiGk+hdaMk0mZ872 X-Gm-Gg: ASbGnctS/bfb71+mWJGFaJUR23wWk0X189jtBGnlxjzzjhpH1C1JNMeh7JAnKZFS+0u SAdAhoDmgrtCmWImSwESiw1VS+Wxv+8f8iv0+t/Qngd1HSFdKhgixT6/8uRAvHrEP5RviThelR+ m7nmPbTX9+FMgW0pSZ6eXFCTsEy/jOX3BABe1gSRtRkrRffsavdNUBAMkyuO7r0cxvjgJLmC3Te Auv8heWwKiDpu1tbtKp+93tyaTKAE6rnACNGH1IpHkigI2MORMIFcb6pUASAzWv6WgNZlkjhIjZ WFVTSxHqPHpQlAxaYV2dBGFwt3NAGGEKvtObeUwAWrmVdpqdmhdkqial39Y6shlgIR+rDV+tOj9 39GTJfDPlpAaf23uievcr5nz3tXdqz9ZvGGd62ZE= X-Received: by 2002:a05:600c:c1b:b0:43c:e481:3353 with SMTP id 5b1f17b1804b1-442feffbb8dmr150315575e9.17.1747682884060; Mon, 19 May 2025 12:28:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESb912KpWPc+1WCxDZznxhcbTv/hYw+6+52hmHHhfCLzW1q+2VC3U6RSKNRPFkZUWbVZWovg== X-Received: by 2002:a05:600c:c1b:b0:43c:e481:3353 with SMTP id 5b1f17b1804b1-442feffbb8dmr150315345e9.17.1747682883673; Mon, 19 May 2025 12:28:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f6f04334sm736785e9.10.2025.05.19.12.28.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 12:28:03 -0700 (PDT) Message-ID: Date: Mon, 19 May 2025 21:28:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: prevent KSM from completely breaking VMA merging To: Lorenzo Stoakes Cc: Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <418d3edbec3a718a7023f1beed5478f5952fc3df.1747431920.git.lorenzo.stoakes@oracle.com> <2be98bcf-abf5-4819-86d4-74d57cac1fcd@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Z_0rqYZKSWykCeCNC1MKHDaV0ydjcBekz20uQF6nTcc_1747682884 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6D00F140004 X-Stat-Signature: auhhr8wpmuscjkq8him9s89egj9aq6p8 X-HE-Tag: 1747682889-406488 X-HE-Meta: U2FsdGVkX19OGjk+p/gPGZAyQV9ZdMOyApUqLvNrdZOTLCjq5SNgfKeEz7L6biVad65wYSGP5UCWY+XtuHW8TGHJYW52/4YrNjQXL04yD4kmv/+dC5px9DQ+uXOAZDEPZaBKJOCpy+dhcT4R1bVj2b9DVISHsGTPcmZm71V53HdUKzpuniAnhHfAlcM2gdVbm+dRan2X4hO3qG0/cZcL21IZGJkIUbTeYqpIu5TKilkT2KFyJVC3484cN4ISvd0ibleBvGrUzuPoCp7X7zzbpCqI8XUPen614jXG2qdHQodh/1CmngyL61R+vS7FmaUllPve3v9PVt/UUnWuWPfgVxFKi9Q9f1ldpyjnKfB5XrBZwe6RhSjWV4J2qmIWDDsbVQTLT7q6vc7g8AWEr0WjB9hkIDFh1o8PN2J8QtOZ9wysTrPuLNjCtSjRZ2V9Fp3VTl2Dk/uAByFSnpvoZ3jWzPC4OebLzol/s1+62nlSgfujtuAVsF75WZDiMBfellLV34iyNR07OQd4EVva+LTOsZOZpXkT+ryYVKAj82hr1INdkoAS38GDI+RhGmyudddRYAMtFi/8O2+axmMAh71gAdtQschCJuZGadJNMGMEpX0MBOTfIzAz3Kn5ZU88YVT5QDfyo7YN1AJhkkG/sj54sVSjTYtRqX7jIlI4DqoKpW/gxj+9cgsMJpbJszNMNNHletZqI6znscx3HYdAv+8kPNQAvVO76wJbd2V5o++uoL5sG+Gst5iFe3UK51RVG8O02ABNQVPlhtG2RJftT6w0HcldRDdHPUKRIiWO+fS4VVUHk+X9LIa/cL69cshbAHjH1R4r0S/zdBhIm87ZhRc2DWWTFDbBCQxnjsv93kEUwVIja7EZXQgU8CUXXoaobjTZrT4T9fN+ltqU8IPtqjiudrbunowrYJSDWe1jq8Yc891D/1X2vNdpYkI0PdmAJFv6IMs9U1Qtdvd+OiNiXCS tW7xkIQF uCDexEk/+bDf2DV1wYaSMv3gY3uzkiFHsAS+hEi1zLbXXUfUmrhBWi9WmUbH1g/ASHL3G/PBLLk8dieGiC1N0/G21S0lurO8ANv5smWmOWOKt5BWXrzupF2HxlaqrSmwRXhKNXb3/BTF70/WgU40g3r60fuNCxvtQBB8TvDNCUd/Gi98nHMDwFLpZt5TRRF6XCUSf5btPmpPcz9LpCDnWrc9nVsl2qq+ph+Uvwkle1j6iMZYKXO+sxQHyhVb2Ld1eIcT4tBy4/JCNOO3SDuinZ1A4s93lSXxoQsHCR8wcKepiuzEdsY5KWnaDjUDrlSAwkRLfeoHMEJEaj3eZSny58QlnTwq2GK5ri5+vXMqu4mI8G3/SBnv5YgQxRe4E6muPVdkjWHSlMRBa3Kf2armrlmEVbsG5WdMtzovpxYIFAWTrSBs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>> >>>> So, assuming we could remove the VM_PFNMAP | VM_IO | VM_DONTEXPAND | >>>> VM_MIXEDMAP constraint from vma_ksm_compatible(), could we simplify? >>> >>> Well I question removing this constraint for above reasons. >>> >>> At any rate, even if we _could_ this feels like a bigger change that we >>> should come later. >> >> "bigger" -- it might just be removing these 4 flags from the check ;) >> >> I'll dig a bit more. > > Right, but doing so would be out of scope here don't you think? I'm fine with moving forward with this here. Just thinking how we can make more VMA merging "easily" possible and avoid the KSM magic in the mmap handling code. (that early ksm check handling is rather ugly) Your patch promises "prevent KSM from completely breaking VMA merging", and I guess that's true: after this patch merging with at least anon and MAP_PRIVATE of shmem it's not broken anymore. :) -- Cheers, David / dhildenb