From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B82C3ABC3 for ; Tue, 13 May 2025 07:49:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C1686B000A; Tue, 13 May 2025 03:49:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56D926B0083; Tue, 13 May 2025 03:49:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4356A6B0085; Tue, 13 May 2025 03:49:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 23CE56B000A for ; Tue, 13 May 2025 03:49:52 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3D7B3141B81 for ; Tue, 13 May 2025 07:49:53 +0000 (UTC) X-FDA: 83437110666.30.E281446 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf16.hostedemail.com (Postfix) with ESMTP id A3A57180002 for ; Tue, 13 May 2025 07:49:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ICyfMrK8; spf=pass (imf16.hostedemail.com: domain of joel.granados@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747122591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z+XKwlKxvho0rlpEIn0bjoCqOXNrPIEWodnNK5WbJJI=; b=3N5CWsD00h7A8+URZiz5fviA1W8X1/4q80rYsRXMvsNxaYd230T641I+Tm96sohtAlZMTx DB2HcxSo42VwsDwNzuh2sdHUXpYJ0C2iFTK5UI+wwJKER88ZaQkRYh9ObUAf6nf5Jq76Lx DQq46rcT4BUjklyzpiHfvaVKjZmNOAE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ICyfMrK8; spf=pass (imf16.hostedemail.com: domain of joel.granados@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747122591; a=rsa-sha256; cv=none; b=nCI/dG5OYlNYEGFYilpJAaN05OnfLZugc70Haw3Zgga+NYH3ZKoqGKZvOLUOQATZG6aiLH Or6uE7+rdIqQq/Qt8zdCORM/7QqtVD3fbYKXdzpRqty4nND8UUnkfDitAZGiPWzOoflXx9 3bhzjSfK01NoQSxeBTAVYA+CxyxcMDc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A5BD660007; Tue, 13 May 2025 07:49:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE39EC4CEE4; Tue, 13 May 2025 07:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747122590; bh=z+XKwlKxvho0rlpEIn0bjoCqOXNrPIEWodnNK5WbJJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ICyfMrK8mhiA/OukQgVVroae9K1GoFJUvWMzgTt2E9VSNfkJVyx/BiJXh7hDwRupN vQugGeWqM/CZbN07jv+GX+v7HG44hoBoz7j1e/xSsj/MrkgkUaxC8Vw0zpZT6eeXFR 5pDKYrmSzylrdVyA6z2oLJNWxwsu9Af9MqA46swDCjseS7ly4YQ6W7qzvB90G9vcKN gMPsr6tcbDpNY+sLEN8fVVA1Fe8zFmpd9TUPkKiRRjfBxBjA4oUQh/ABIb0I+ai1VE T6A0zExe59APk/1qaqjF8GO+BWLk9cBZFzQs2DCDYTAXkhKk1Slpx2OsT44RbP5ASH fZ8VPCWKfD5EQ== Date: Tue, 13 May 2025 09:49:43 +0200 From: Joel Granados To: Kees Cook Cc: Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 07/12] Input: sysrq: mv sysrq into drivers/tty/sysrq.c Message-ID: References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-7-d0ad83f5f4c3@kernel.org> <202505091010.F2F8C676@keescook> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4m4abidfdrbxi5yd" Content-Disposition: inline In-Reply-To: <202505091010.F2F8C676@keescook> X-Rspamd-Queue-Id: A3A57180002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1uoso8kxxrtepgek5ffazpxg8wyhuhh8 X-HE-Tag: 1747122591-109074 X-HE-Meta: U2FsdGVkX1/HN7i77BMX0gmAUARaJuU2gYZ6xY0soDOITXeb5BdEW6kr0VUIrFLJwO3/u3RizvPW/VRFjxrJDfzPLI4dJvj8vzuCH/5vnoCFAU1jcaV2s8TpZJ+/4Zn7Xg2qNSNl+wCD9DqPLMYd/mFcLKEwbFUSbLHWFuzGDerhg6Zdt2h6JG0vnz2LqeL6jWOSxEr+jTOhjhjXEawiw9nQHLxWRFLu1LWasOGXc41M2pyuKQUaNXgLWZLAgXm8HNppxB6cgSO1Ry2ni92xLiEYc5CkN/y1QviKSEicYd6216hsuVjwOlgTHhary9CfbBRY+MXURnegvn+xPh6xAA9g+4Xke0Z6OKxmAsX//ER+IZYAkP8LKnE/+Mw8dkHaDxWJcGl//dGpr903WdyLQvPGQBLwjX4h8YqlYJYa9mJyAGQOsO3cDt6Y4VqizcS3GuiRGxqh4lgn0d+JGZOwqrS0tlXf9ff6fc8CsF4apEBB/d/5vyHR/I4T4BmS2CBs9bpw6qynIP7wCCdcpTB56hwPKIq54LZY6X6WgUcuPGXjIG8Pm/mcFKQcIbHuHGUTh410k/MUOJI5Qqtz1M9DOeqk9xVjMRdO5jz14iViihikhuBYgBWUovJjduuWbM50a3Y93ybtQmc8mv3nyBfuTojfFrIT86PCtgSjSnAQsjSxvCYE2irovfk4356n0aYZWgxVdt3D/DqrgoNBdcSjFEog0mCGAPAioipSFkTA5DksH5ijkXPY/PnZLmNrH+YVjscu/VPBpGG1yfjQM/ej9Z7mckjG5irSuDEYo1YTcm1nsE2t9rwXqZl2McEAlBuB7Yz09htq9LnBqhuqGCuJTl66nWL36UlRzpuIyoonP/E32Of+GasoTzkj8mUCHJREgfChYEpkS8Nc8nAUothL7YwCrNPL8rppNdCQMBAdrygZ8qxRyJg7cT/pzL1zMNYPRUpatx3uBbdkF4Yxm06 WVX3CmKj VRuwlsh2BkW1UBiuNWJXUEJSduKEzs6D4FPSOvgiSR5nkCPYybG7g5u67q7BL3neKSDScWSEOv4RHgu3RJji/Y4zEjoBUwtFSowyQ8Pt8e98JvZhaJp0OXOo2at+xHoTro0jD2mGcgZbbyPLV84/tkt5nTbxjYVaRhIkzGCxY7RrwFG3kNm9DXcDLAwfQaINeESU+tHsZiBZU/6Xc8S88N48ZxdutKaal43MZF4hzChW0vpXDcxNjpDYUgB3womaG8h53mrdspjyoDue9ginWYdXDTuPM/lG4cqw+MExUvgEl1P/IxFxKe83yfLdoIWCON2yOYSABWldMkbnlswbQV0wxwueqyJNFA7Q3PtsyEVFXu3wLKS9n06Z0ZfSYjIsJLr06RHxDETXQvkuVP/q+HvmSHmkd+PG9i8CK1bcQeftobdc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --4m4abidfdrbxi5yd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 09, 2025 at 10:10:28AM -0700, Kees Cook wrote: > On Fri, May 09, 2025 at 02:54:11PM +0200, Joel Granados wrote: > > Move both sysrq ctl_table and supported sysrq_sysctl_handler helper > > function into drivers/tty/sysrq.c. Replaced the __do_proc_dointvec in > > helper function with do_proc_dointvec as the former is local to > > kernel/sysctl.c. >=20 > nit: do_proc_dointvec_minmax Thx. I even added a small comment to the commit message to clarify: ``` Move both sysrq ctl_table and supported sysrq_sysctl_handler helper function into drivers/tty/sysrq.c. Replaced the __do_proc_dointvec in helper function with do_proc_dointvec_minmax as the former is local to kernel/sysctl.c. Here we use the minmax version of do_proc_dointvec because do_proc_dointvec is static and calling do_proc_dointvec_minmax with a NULL min and max is the same as calling do_proc_dointvec. ``` I'll also put a comment in the code to make sure that a min max is not added by mistake. Best --=20 Joel Granados --4m4abidfdrbxi5yd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmgi+ZcACgkQupfNUreW QU+v4Qv/efXaubw/UZ0/uYrlHOJZg+VxZvyldRdbiHjo3Ub408gh2trrRYtceCsY ICssy3kBVRggr7y+KLqjXZZOVoAz8/PVXR38X+6FozTLuSpwrtIY0vLeXeew7GU0 kwYWrcn+MtqfBuo32INYySExZJs7/NoQLVqGwQrPIdRhuM/N/srMoe/uGeMwQnhl mLdzg3jlOdcYSxbKj6bdCMBg/2qHTWIv9iVQfdRNy3bALXOmvGJNlHBgd2qROsyg T7Y78uAfyz2h/mnTrRi0JxjssYLfjFQLoy2+Y/KBwonDdAyRRRQg6na93jB+DJWs Veq4CcLz5XA4OfxXNPosQYtrfzKUahzQSiwGvOq4F+fNhp2JrHf3jYmojoC2pPSN e0AV2jZBVk7Y+gkyeEkYgEF9A7AtHqFXLlCc5wovR/dYG8seSJWLuaVkphB0oXdC QK0b1e9pm6iy1k5xhRhP7KZCcoqynySk816gPhatZI0ARh0+5YJT8D2TEJYkCvJx IoAnZ+8h =dHUN -----END PGP SIGNATURE----- --4m4abidfdrbxi5yd--