From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B3AC43334 for ; Mon, 27 Jun 2022 14:30:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D6278E0001; Mon, 27 Jun 2022 10:30:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4857E6B0072; Mon, 27 Jun 2022 10:30:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34D088E0001; Mon, 27 Jun 2022 10:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 26BA46B0071 for ; Mon, 27 Jun 2022 10:30:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E502434495 for ; Mon, 27 Jun 2022 14:30:09 +0000 (UTC) X-FDA: 79624250538.29.0DA66EE Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 4858B100033 for ; Mon, 27 Jun 2022 14:30:09 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id i18so16944774lfu.8 for ; Mon, 27 Jun 2022 07:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=eFEE88CccHR5CkwS+vurL0zrLbEnGdsXJjb2ZKJiUh0=; b=JlDAoSXgRYC30V5DWW1Nd3hA7tf0emWM47e+Fbz8ds0PPHa12/9nYfrJ/0oDDYu4/w LQ9ju9Mmo1FHbnLcprAf8/1EhhzU/RI9bIO2Fb1XtVyQ62GubZ2Rub2BPE4e7fW4/w96 y76ZGCOCPXael+3OrQ6Cc/D4KI9VfyjUSAqNXkGgF/OVDp3xoN4/IfOsaVzhSBmQjKpH D8642wM3M7f69ZEj+8hCW5AeWzT3VXyM9xF/4PfblDq6txuFWHzG2Bgz8qHDf7GoIl5E XCgUyLrxrcK6dzVR9eqTdkZ3v0T5PeIpsnaEsl8EguQWdCYXY2/hpWd/EksRCpURBVv5 Xgqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eFEE88CccHR5CkwS+vurL0zrLbEnGdsXJjb2ZKJiUh0=; b=iP8Yx5WIBpBSwiEzK8qBJ0+0Z9pxyctlGgfjHfHSbkTao+qSyVOT1eckT8+d12X1HM 4HTxq+Llwvnbp5GSgmh0FL6wiIa0q8kSVbBDf0ACYvmodyPptg53N0urGDSYS1buLCsK CuIJV9PJLvo1+dNreaqGZygli9gTnrAAxKBfiTGHi+GxM3F/Jnbf60dSo9+8uK/iDUTS 4725ZZpOlXubZ8Z9PLqOQ7WLA54n+us9v8XRjOBQx+HlZ3BCbHCHPZz/RaVGQQW/g1tW UIXwrdQXGLnwk0XZyNnU152XT/URR+pyMIjQauUR2G+JnNorfCmXR22RjkM1JMvQcRbK bBlQ== X-Gm-Message-State: AJIora/NC5qWJV1brFZQm+pMtCH1L4H4yqnA2KNjmRt/Z/DkLeV19k0M eI5DAVTqmzs1q0Nf7H2cq3o= X-Google-Smtp-Source: AGRyM1tlgDmoI90ileKuTGzEu97gjy2yQONAwLjp124FI0Hi2sUwTDptZ1dcnH1Ao5NguSNyj8jnnA== X-Received: by 2002:a05:6512:32c5:b0:481:1822:c41f with SMTP id f5-20020a05651232c500b004811822c41fmr4601636lfg.373.1656340207490; Mon, 27 Jun 2022 07:30:07 -0700 (PDT) Received: from ?IPV6:2a02:6b8:0:107:3e85:844d:5b1d:60a? ([2a02:6b8:0:107:3e85:844d:5b1d:60a]) by smtp.gmail.com with ESMTPSA id q10-20020a056512210a00b00477a287438csm1837713lfr.2.2022.06.27.07.30.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 07:30:06 -0700 (PDT) Message-ID: Date: Mon, 27 Jun 2022 17:30:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] mm/kasan: Fix null pointer dereference warning in qlink_to_cache() Content-Language: en-US To: Gautam Menghani , glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, akpm@linux-foundation.org Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <20220626170355.198913-1-gautammenghani201@gmail.com> From: Andrey Ryabinin In-Reply-To: <20220626170355.198913-1-gautammenghani201@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JlDAoSXg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ryabinin.a.a@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=ryabinin.a.a@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656340209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eFEE88CccHR5CkwS+vurL0zrLbEnGdsXJjb2ZKJiUh0=; b=L7q6C1CHGZ91W3tD8zufhxPykzwR7IFBlMLf94sgZgMP0BSt5CBPJQybZwVoZbhom5usDT oSuAcoIMxy+GSBikPuCgH3236BsWONEhM0+9UOK+Ul5tzzEIKNNJt3Ogiky6AzAS27keg+ AseGGBESbUA0thcbSY1FNXLS7dYXFZY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656340209; a=rsa-sha256; cv=none; b=viL6xZGsdkgtUCcckrLw3u3kVLGzSjh8WUBIvQ+B+LWVfRf+Mui2XKG637JuLlm2XIiK1e hi6QWYoxZs0TA2zLs7iAzuGODmDeaMnwL31lL3PNGkVp7fBF84971lvgbrJXdJpbUjt0KU KqbtxCYsAOMUNz/rL1QtDeI5p8LtU28= X-Stat-Signature: hu4raobns5w87qrxn6g1nnxzhw444o1g X-Rspamd-Queue-Id: 4858B100033 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JlDAoSXg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ryabinin.a.a@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=ryabinin.a.a@gmail.com X-Rspamd-Server: rspam12 X-HE-Tag: 1656340209-810679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/26/22 20:03, Gautam Menghani wrote: > The function virt_to_slab() declared in slab.h can return NULL if the > address does not belong to a slab. This case is not handled in the > function qlink_to_cache() in the file quarantine.c, which can cause a > NULL pointer dereference in "virt_to_slab(qlink)->slab_cache". qlink is always slab address, so I don't think this patch makes sense. NAK.