From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08261E7716A for ; Tue, 17 Dec 2024 07:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8909E6B00A9; Tue, 17 Dec 2024 02:48:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 841556B00AA; Tue, 17 Dec 2024 02:48:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E0FA6B00BA; Tue, 17 Dec 2024 02:48:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4E7806B00A9 for ; Tue, 17 Dec 2024 02:48:01 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6871C14052E for ; Tue, 17 Dec 2024 07:48:00 +0000 (UTC) X-FDA: 82903670556.09.497A51A Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf26.hostedemail.com (Postfix) with ESMTP id C820B140006 for ; Tue, 17 Dec 2024 07:47:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf26.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734421650; a=rsa-sha256; cv=none; b=qWFa1JhVAGElE7v6rV2pnQNfXPYM2R43wcAw6/WSCl66u/RZoKs1ozB/mMj8ogCKwKvvgS Fcng8xSWVINnZ5RjfY4di8jCbDs7RdVbOYRHRyJvyKASt4qPZBAz9qOR9l1ITnqGOXrMHn VAReqrZBdbwtNjR4NGI0ukz7hpOx5gU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf26.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734421650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u+CROXNMQB4zsFWzTxbDDJajvghMgBuYZmlPGZXhJXg=; b=L/EO9TKXzsQm/qxAzsJnJJSh4xhGJiC3Q1ZyjYB0XAaoEMLZPUDrejx78COULDdtcFQJ1g vKWwKnbXmZSaU8kBAQxe2p0Im4XtqdmqJOVcVlArvxu28lKGlO52R+FcErGFdVcrljl1v5 59c1xPvCMoCIH6jlUF1f/Nr3rdUnwl8= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4YC86z6Lcmz9sPd; Tue, 17 Dec 2024 08:47:55 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fC7tw8E5ccA2; Tue, 17 Dec 2024 08:47:55 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4YC86z5K7qz9rvV; Tue, 17 Dec 2024 08:47:55 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A3F418B768; Tue, 17 Dec 2024 08:47:55 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id iR2VLUnfgYsc; Tue, 17 Dec 2024 08:47:55 +0100 (CET) Received: from [192.168.232.97] (unknown [192.168.232.97]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 73D238B763; Tue, 17 Dec 2024 08:47:54 +0100 (CET) Message-ID: Date: Tue, 17 Dec 2024 08:47:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/ptdump: Drop GENERIC_PTDUMP To: Anshuman Khandual , linux-mm@kvack.org Cc: steven.price@arm.com, Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20241217034807.2541349-1-anshuman.khandual@arm.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20241217034807.2541349-1-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: yfqqpw4hhgd1qdwumkyt4aub7ekbf9k8 X-Rspam-User: X-Rspamd-Queue-Id: C820B140006 X-Rspamd-Server: rspam08 X-HE-Tag: 1734421654-995561 X-HE-Meta: U2FsdGVkX18HgLe/1SKjgeLTj2aeL9NxOV8PEbyfQRTRqfV9um8KvtKgC92WjGSHOCLo9d2fbqvSVqLiKeRfUaNfDsdcBrUIqbe3Gi2RBVfKoIjqSohk1NWkut4lCxUiAF2PwAIVEZdx1uZIVYMuXYqtDqwgzznI2VZ/6fEGEJ7+DqcjkFk1IFLsURkmQX5ZW4Twf2v1DI237vo1hfisuvfbcdl+lFUqqafnORfYJ8ClIX9Xl+wnuo+OkoZM6Hbsmdx9vb89aeyH5maVefukjLN+iN/geUx7KO7DBhV+fbfozObak2UfHeU/bfKzteDIRW56e3+crfKiaRE4rjfGkm5tCkE+SsfVaI+hwGHMQuo3tWRD0Q44ONnOSsLQpweG/llmyMdMp824zom6AtK56666TYvbnSiYpy0hn52zWXDgrz9wxsSz9qaoNVqzTgT2Mz+wSopyCheQ7ox0dUc1R8y7zqkONqSNkn24IG4iPO8dP21PBHol6PlJ8zOCNBlH5anEw9uBWftPB56wX8cw8+olrw0BthjZiJpaJHCKobmzJ8OLgf2zGRxR9yCTshGy1Xab38ppxgJyoS3nJhj5/oXIF6qbqnhW+wm/Q+LHe1t6e2lCq/xpUWFIFvWkXO1vJDff3k5iiFCwPeGwuuSPxqrWqo8QAYug/cuYV6c4PHFQ724fmnkQal8RMUlNVpWDCBtke1lYsZuIGjoW6oIB5RTaxxOcPyMo/dOnxXuqgZr3VLOzGE0WfVBRs/W2ZKDIp0vm8rJbPqwQ6xW0BqzR9QP0oTrOEni9Kb/JW90hnN7PEeYeEEW+ywpMV2Z14JILW3gOg8BcJfyp47wrF8CUv9LdUefBBzo8wOLHlsj6Xi8ZwR1QFYMqN50VmpxMWm0d1Ftc7myNJkdHbM1p+u6Y5eqtI+n5UFfjD/9dYfK5Z8nWIoRqdh8UY4MhwooSOAnSGq6JIKtJ3xktNxJ0saV FVTN6VWj x6GRSIPkvydh4VOSoNhXARYHbDQMSxfqoDOcPUNjbzjjCMGoZHmv1c6L+YjLdmW73pJ0mEuNB0WC3BVBjkF0ZAuXQl/AfAscVks2Y/mYPV/US1NjnfpGlMZrkoRzu3TK7XHavpUlnZ56zM/Qo9Q9O3YFBWp/HMJJ1DhC5Li55zTdjxK+grDC02v1cL2d+fyaWrAXx90+LMK5tSdyQAR2mIk7zMqXOesQR7nEOgvcoHAv+bwtJ8XGwhI+PEVrzkC00tF1qKcFvMkQ0NW2brDOWAjm6x0G2lF5CyS1+rO5aDbwBJTn7gHvkglU23ZTaDRUTe2/ES+XQcV18MhBUflztzee9zA/XcoNbgSDQSPNvIO5o6/0D89eOd/TRPj7PINyrNFAYABSfhC1uyiME7rxN38u1SLM7rbOl71po6KSWCaxZ6I2kgIBRpS3UiNarQNYiupyixDzuhvvc5jn9me3Eoc+R0MKkXInVkXpfmjHG28IkmxyNEBALflqpjDKgSsnM+0taONxrcMDWLe/4zOBabIWWF+jLuYmukCR5L4FHoa/UBgzPaBXAa3Zt/rWBFrx3keo+YcV9YQ9pFw7yR5RfaJRtrnHGZL1Ca8U2aFmlHnbBzHj9pMbtSS6wKohCPwjOM6CzmOhHWygMO83auIUPMirQz10H6vi0TmSybjjsI90d6nPQ5PCgWk2rk+tcLNkX9MyfJzw0sGQopsGj5T09UmyVbJxY1YemCG8Pj95B5l4o4DEvS3PMhj4xlAxWPdWCO07m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 17/12/2024 à 04:48, Anshuman Khandual a écrit : > GENERIC_PTDUMP does not guard any code but instead just used for platform's > subscription into core ptdump defined under PTDUMP_CORE, which is selected. > Instead use PTDUMP_CORE for platform subscription and drop GENERIC_PTDUMP. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Jonathan Corbet > Cc: Marc Zyngier > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Andrew Morton > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: kvmarm@lists.linux.dev > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: Anshuman Khandual > --- > This patch applies on v6.13-rc3 and has been tested on arm64, although it > also clears build tests on impacted platforms. > > Documentation/arch/arm64/ptdump.rst | 1 - > arch/arm64/Kconfig | 2 +- > arch/arm64/kvm/Kconfig | 3 +-- > arch/powerpc/Kconfig | 2 +- > arch/powerpc/configs/mpc885_ads_defconfig | 1 - > arch/riscv/Kconfig | 2 +- > arch/s390/Kconfig | 2 +- > arch/x86/Kconfig | 2 +- > arch/x86/Kconfig.debug | 2 +- > kernel/configs/debug.config | 1 - > mm/Kconfig.debug | 8 ++------ > 11 files changed, 9 insertions(+), 17 deletions(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index a0ce777f9706..c716f8df10de 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -203,7 +203,7 @@ config PPC > select GENERIC_IRQ_SHOW > select GENERIC_IRQ_SHOW_LEVEL > select GENERIC_PCI_IOMAP if PCI > - select GENERIC_PTDUMP > + select PTDUMP_CORE Please keep alphabetical order. > select GENERIC_SMP_IDLE_THREAD > select GENERIC_TIME_VSYSCALL > select GENERIC_VDSO_TIME_NS > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index 41a58536531d..b206e5a11f96 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -187,7 +187,7 @@ config DEBUG_WX > bool "Warn on W+X mappings at boot" > depends on ARCH_HAS_DEBUG_WX > depends on MMU > - select PTDUMP_CORE > + depends on PTDUMP_CORE This change is unclear to me. It works because all arch selecting ARCH_HAS_DEBUG_WX also select GENERIC_PTDUMP. For riscv it's even more tricking, Riscv only selects GENERIC_PTDUMP when MMU is set, so it works because here it also depends on MMU. But what happens if in the future an architecture selects ARCH_HAS_DEBUG_WX without selecting PTDUMP_CORE ? > help > Generate a warning if any W+X mappings are found at boot. > > @@ -212,9 +212,6 @@ config DEBUG_WX > > If in doubt, say "Y". > > -config GENERIC_PTDUMP > - bool > - > config PTDUMP_CORE > bool > > @@ -222,8 +219,7 @@ config PTDUMP_DEBUGFS > bool "Export kernel pagetable layout to userspace via debugfs" > depends on DEBUG_KERNEL > depends on DEBUG_FS > - depends on GENERIC_PTDUMP > - select PTDUMP_CORE > + depends on PTDUMP_CORE > help > Say Y here if you want to show the kernel pagetable layout in a > debugfs file. This information is only useful for kernel developers